feat: Support transient identities and traits#4325
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Skipped Deployments
|
Contributor
|
|
Contributor
|
|
Contributor
|
|
Contributor
|
|
Contributor
|
|
f82a97f to
a47b4bc
Compare
Contributor
|
Uffizzi Preview |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4325 +/- ##
==========================================
+ Coverage 96.61% 96.78% +0.17%
==========================================
Files 1196 1159 -37
Lines 39123 38152 -971
==========================================
- Hits 37797 36925 -872
+ Misses 1326 1227 -99 ☔ View full report in Codecov by Sentry. |
Contributor
matthewelwell
left a comment
There was a problem hiding this comment.
I've added a few fairly minor comments, but one additional thing that (I think) is missing, is a test that verifies that transient traits are correctly used when evaluating segments / segment overrides. Maybe this is implicit from other tests but I certainly expected to see an explicit test for this case.
Contributor
Docker builds report
|
815b6e3 to
3929b2d
Compare
matthewelwell
approved these changes
Jul 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
pre-committo check lintingdocs/if required so people know about the feature!Changes
Closes #4279.
Contributes to #4278.
This adds support for
transientparametertransientattribute for traitsfor the
/api/v1/identitiesSDK endpoint (GET, POST).When including top-level
transient: true, identity is evaluated against segments but is not persisted at all.When calling the endpoint with traits marked as transient, these traits get evaluated against segments but do not get persisted.
Additionally,
Identity.update_traitsdoes not perform twoSELECTqueries anymore.How did you test this code?
Added unit tests for views and serializers.