Skip to content

fix: Fix generateIdentitiesCacheKey#90

Merged
matthewelwell merged 3 commits intoFlagsmith:mainfrom
fgiova:fix/generate-identities-cache-key
Mar 28, 2025
Merged

fix: Fix generateIdentitiesCacheKey#90
matthewelwell merged 3 commits intoFlagsmith:mainfrom
fgiova:fix/generate-identities-cache-key

Conversation

@fgiova
Copy link
Contributor

@fgiova fgiova commented Mar 27, 2025

Fix #89

@fgiova fgiova force-pushed the fix/generate-identities-cache-key branch from 16d8325 to 3cbaf45 Compare March 27, 2025 16:03
@matthewelwell
Copy link
Contributor

Thanks for submitting @fgiova - I've fixed the issue with the workflows in a separate PR here: #91 . Please remove the change from your PR and you can rebase onto main once that is merged.

@fgiova
Copy link
Contributor Author

fgiova commented Mar 28, 2025

Thanks for submitting @fgiova - I've fixed the issue with the workflows in a separate PR here: #91 . Please remove the change from your PR and you can rebase onto main once that is merged.

k

@matthewelwell
Copy link
Contributor

@fgiova #91 was merged yesterday so you're good to rebase and fix the conflict, then we can get this merged. Thanks!

# Conflicts:
#	.github/workflows/pull-requests.yml
@fgiova
Copy link
Contributor Author

fgiova commented Mar 28, 2025

@fgiova #91 was merged yesterday so you're good to rebase and fix the conflict, then we can get this merged. Thanks!
@matthewelwell conflict fixed

@matthewelwell
Copy link
Contributor

Thanks @fgiova , can you fix the linting error?

@fgiova fgiova force-pushed the fix/generate-identities-cache-key branch from 730190d to 5572945 Compare March 28, 2025 10:41
@fgiova
Copy link
Contributor Author

fgiova commented Mar 28, 2025

Thanks @fgiova , can you fix the linting error?
@matthewelwell Sorry fixed!

@matthewelwell matthewelwell merged commit 4cc896a into Flagsmith:main Mar 28, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

IdentitiesGenerator::generateIdentitiesCacheKey return always the string 'Transient'

2 participants