Flagsmith instance clonning#75
Merged
matthewelwell merged 2 commits intoFlagsmith:mainfrom Aug 28, 2024
Merged
Conversation
Contributor
|
I'm not sure why CI hasn't run on this PR but I'm definitely keen to see the tests run given this is a change to quite a fundamental part of the library. Can you make sure that you're up to date with the latest from the |
Contributor
Author
|
I synced the repos. |
matthewelwell
approved these changes
Aug 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
clonning the instance with every configuration change is very expensive and not necessary in context of this library, I propose just setting the property and returning original object.
This also fixes Flagsmith.php line 183