Skip to content

Change cache key for getIdentityFlagsFromApi #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matthewelwell merged 2 commits into from
Mar 14, 2024
Merged

Change cache key for getIdentityFlagsFromApi #62

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8a7a8ff
Change cache key for getIdentityFlagsFromApi
tm1000 Feb 18, 2024
1377d1a
🔧 chore(composer.json): enable php-http/discovery plugin to allow aut…
tm1000 Feb 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,5 +30,10 @@
"Flagsmith\\": "src",
"FlagsmithTest\\": "tests"
}
},
"config": {
"allow-plugins": {
"php-http/discovery": true
}
}
}
3 changes: 2 additions & 1 deletion src/Flagsmith.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -418,8 +418,9 @@ private function getIdentityFlagsFromApi(string $identifier, ?object $traits): F
{
try {
$data = IdentitiesGenerator::generateIdentitiesData($identifier, $traits);
$cacheKey = IdentitiesGenerator::generateIdentitiesCacheKey($identifier, $traits);
$apiFlags = $this->cachedCall(
'Global',
$cacheKey,
'POST',
$this->identities_url,
$data
Expand Down
6 changes: 6 additions & 0 deletions src/Utils/IdentitiesGenerator.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,4 +19,10 @@ public static function generateIdentitiesData(string $identifier, ?object $trait

return $identities;
}

public static function generateIdentitiesCacheKey(string $identifier, ?object $traits)
{
$hashedTraits = $traits !== null ? '.'.sha1(serialize($traits)) : '';
return 'Identity.'.$identifier.$hashedTraits;
}
}