Merged
Conversation
emyller
reviewed
Oct 7, 2025
Contributor
emyller
left a comment
There was a problem hiding this comment.
Just one small fix.
Do you think we should cover for \w matching unicode?
Co-authored-by: Evandro Myller <22429+emyller@users.noreply.github.com>
Member
Author
Even though it slightly falls out of scope for #13 (none of the SDK unit test suites have it), I'm inclined to add it. Out of curiosity, is there a particular reason to have such a test? |
Contributor
I don't have many solid examples in mind, but I'm looking into allowing the pattern to run against non-English text as well. e.g. internationalised DNS. |
Contributor
On a second thought, I think it's appropriate to have this better documented in a separate issue. |
emyller
approved these changes
Oct 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to #13.
In this PR, we add test cases converted by Claude 4 from all of the server-side SDK regex operator unit tests, including those added to PHP test suite in Flagsmith/flagsmith-php-client#72.