refactor: plotter config

[rbx]

No description provided.

[coderabbitai]

📝 Walkthrough

Walkthrough

Consolidates plotting configuration into a new PlotConfig dataclass and updates environment, plotting modules, training script, and tests to accept and read plotting flags via plot_config instead of many separate boolean parameters/attributes.

Changes

Cohort / File(s)	Summary
Configuration Dataclass powersched/src/plot_config.py	Added PlotConfig dataclass with boolean fields for plotting toggles (quick_plot, plot_rewards, plot_once, plot_eff_reward, plot_price_reward, plot_idle_penalty, plot_job_age_penalty, plot_total_reward, skip_plot_price, skip_plot_online_nodes, skip_plot_used_nodes, skip_plot_job_queue).
Core Environment Module src/environment.py	Replaced many plotting constructor flags with plot_config: PlotConfig; added self.plot_config and self.plots_dir; rewired internal plotting conditionals to self.plot_config.<flag>.
Plotting Modules src/plot.py, src/plotter.py	Replaced flag checks from env.<flag> to env.plot_config.<flag> across plotting logic and panel inclusion. Minor label text correction in plot labels.
Training Script train.py	Construct PlotConfig from CLI args and pass plot_config into ComputeClusterEnv instead of many plotting flags; preserved workload CLI changes.
Tests (env / sanity / checkenv) test/test_env.py, test/test_sanity_env.py, test/test_checkenv.py	Updated imports and ComputeClusterEnv instantiations to pass plot_config=PlotConfig(...) instead of individual plotting keyword args.
Plotter Tests & Mock test/test_plotter.py	MockEnv and tests refactored to set env.plot_config = PlotConfig(...) and remove per-flag attributes; tests updated to configure plotting via the dataclass.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• PR Part 1: Add sanity test harness and new plotter/dashboard module #4 — Overlapping changes to plotting modules and train integration; likely touches same plotting codepaths.
• Integration of early Dropped-Jobs, RNG Seeding and Workload generator & alternative "prices" script. #3 — Modifies ComputeClusterEnv.__init__; may conflict with the constructor signature changes here.
• Add plotter functions tests #9 — Related refactor and tests for plotting/plotter behavior; overlaps with test/test_plotter.py updates.

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 18.18% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check	❓ Inconclusive	No pull request description was provided by the author, making it impossible to assess relevance to the changeset.	Add a description explaining the motivation for consolidating plotting configuration into a PlotConfig dataclass and how it improves code maintainability.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'refactor: plotter config' accurately describes the main change: consolidating multiple plotting parameters into a single PlotConfig object across the codebase.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Fix all issues with AI agents

In `@src/plot.py`:
- Line 38: The plot label string for the job age penalties is duplicated; in the
ax2.plot call referencing env.metrics.job_age_penalties change the label from
"Job Age Penalties Penalties" to "Job Age Penalties" so the legend reads
correctly. Update the label argument in the ax2.plot(...) invocation to the
corrected text.