Delete unused code#163
Merged
Merged
Conversation
This reverts commit 8fd8479.
Member
|
@mscroggs tests look green - is this ready to go? |
Member
Author
I think there's still more that can be deleted, so was still planning to add more to this PR. I'm on holiday this week, but will continue on Monday |
dham
requested changes
Jun 2, 2023
…nto mscroggs/delete-unused-code
Member
Author
|
@dham Can you trigger the Firedrake CI to test with this branch to see if I've broken anything? |
Contributor
Member
Author
|
|
garth-wells
approved these changes
Jul 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Working though the functions that vulture suggests are unused.
Opening the PR as a draft to run tests on CI.