[IOS] Add smartInsertDelete prop to TextInput component#40
Merged
roryabraham merged 14 commits intoExpensify:Expensify-0.71.2-alpha.0from Feb 13, 2023
Conversation
2 tasks
Author
mountiny
approved these changes
Feb 10, 2023
mountiny
left a comment
There was a problem hiding this comment.
code is looking good to me although I dont have much experience with this code.
React/Fabric/Mounting/ComponentViews/TextInput/RCTTextInputComponentView.mm
Show resolved
Hide resolved
sketchydroide
approved these changes
Feb 10, 2023
sketchydroide
left a comment
There was a problem hiding this comment.
LGTM
Nothing iOS wise catches my eye as wrong, let's see if this tests good
|
@mananjadhav can you see this? |
55 tasks
roryabraham
requested changes
Feb 12, 2023
roryabraham
left a comment
There was a problem hiding this comment.
Sorry for the inconvenience, but this PR needs to be updated to target the Expensify-0.71.2-alpha.0 branch
…utoformatting-behaviors-expensify-0.71.0-alpha1
Author
|
Hi @roryabraham, could you please review the changes? |
mananjadhav
approved these changes
Feb 13, 2023
|
@sketchydroide I just reviewed this today. |
57 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream PR Link
facebook#36111
Summary
This PR add support to configure the smartInsertDeleteType property in iOS inputs as described here, making possible toggle this autoformatting behavior.
This will allow fixing this issue: Expensify/App#14049
Changelog
[IOS] [ADDED] - Add smartInsertDelete prop to TextInput component
Test Plan
smartInsertDeleteprop istrueorundefined, the system will use the default autoformatting behavior.smartInsertDeleteprop isfalse, the system will disable the autoformatting behavior.Simulator.Screen.Recording.-.iPhone.14.-.2023-02-09.at.15.40.07.mp4