add mock#578
Merged
Merged
Conversation
50 tasks
tomekzaw
reviewed
Dec 10, 2024
Kicu
approved these changes
Dec 11, 2024
Contributor
There was a problem hiding this comment.
I think the mock itself looks good.
I'm not sure about the NativeLiveMarkdownModule.install() part because I don't have much experience interacting with TurboModuleRegistry. I will trust @s77rt on this one :D
Everything else seems reasonable to me 👍
tomekzaw
approved these changes
Dec 11, 2024
tomekzaw
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, also tested all example apps and everything looks good. Thanks for the PR!
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @tomekzaw
Details
Related Issues
Expensify/App#52475
Manual Tests
Linked PRs