Skip to content

Fix multiple text selection issues#377

Merged
mountiny merged 1 commit into
Expensify:mainfrom
ShridharGoel:patch-1
Jun 9, 2024
Merged

Fix multiple text selection issues#377
mountiny merged 1 commit into
Expensify:mainfrom
ShridharGoel:patch-1

Conversation

@ShridharGoel

@ShridharGoel ShridharGoel commented Jun 9, 2024

Copy link
Copy Markdown
Contributor

Details

Fix multiple text selection issues caused by #370.

Related Issues

Expensify/App#43332
Expensify/App#43312
Expensify/App#43310

Testing steps:

  • Test mention by typing @ in chat.
  • Test emoji addition at the end of text.
  • Test editing comment by selecting text at the beginning of the comment and deleting it. It should not select some other text automatically.
  • All the above should work as expected.
Screen.Recording.2024-06-10.at.12.59.04.AM.mov

@github-actions

github-actions Bot commented Jun 9, 2024

Copy link
Copy Markdown

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@ShridharGoel

Copy link
Copy Markdown
Contributor Author

@mountiny

@ShridharGoel

Copy link
Copy Markdown
Contributor Author

I have read the CLA Document and I hereby sign the CLA.

@mountiny mountiny left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straight revert to fix blocking issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants