Update react-fast-pdf to use modern pdfjs-dist lib - #40
Merged
Conversation
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
adhorodyski
approved these changes
Dec 17, 2024
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
CLABotify
added a commit
to Expensify/CLA
that referenced
this pull request
Dec 18, 2024
rinej
marked this pull request as ready for review
December 18, 2024 14:56
This was referenced Dec 18, 2024
mountiny
self-requested a review
December 18, 2024 22:10
Contributor
jjcoffee
reviewed
Feb 18, 2025
| { | ||
| // eslint-disable-next-line prefer-regex-literals | ||
| test: new RegExp('node_modules/pdfjs-dist/legacy/build/pdf.worker.min.mjs'), | ||
| test: new RegExp('node_modules/pdfjs-dist/build/pdf.worker.min.mjs'), |
There was a problem hiding this comment.
Coming from Expensify/App#55176. Switching to the new version broke PDF rendering on iOS 17.x.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
In the PR we want to load only the modern version of
pdf.worker.jsfrompdfjs-dist, it allows to use new features and perf optimisations technics.slack discussion -> https://callstack-hq.slack.com/archives/C05LX9D6E07/p1734018797851159?thread_ts=1734018163.878969&cid=C05LX9D6E07
Related Issues
Expensify/App#54095
Manual Tests
Linked PRs
Expensify/App#54250