Fix fastMerge worklet#869
Merged
mollfpr merged 1 commit intoJul 10, 2025
Merged
Conversation
|
This is needed for using the latest versions of markdown library. |
Contributor
|
Thank you |
51 tasks
Contributor
51 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We've tried updating
expensify-commonto the latest version (2.0.144) in thereact-native-live-markdownrepo, but encountered crashes due to invalid fastMerge file workletization caused by #855. Because in this file we can find double-function recursion and worklets aren't hoisted, it results in a crash with an error:Cannot access 'fastMerge' before initialization.In this PR, I'm breaking double function recursion and moving the
mergeObjectcode inside thefastMergefunction. It shouldn't affect anything sincemergeObjectisn't exported, onlyfastMergewas using it.Fixed Issues
$ Expensify/App#39518
Tests
live-markdownexample app isn't crashing too with this changeQA
Same as Tests