Skip to content

feat: add extraData parameter to info function - #762

Merged
puneetlath merged 3 commits into
Expensify:mainfrom
callstack-internal:hur/feat/add-extra-data-to-info
Jul 29, 2024
Merged

feat: add extraData parameter to info function#762
puneetlath merged 3 commits into
Expensify:mainfrom
callstack-internal:hur/feat/add-extra-data-to-info

Conversation

@hurali97

@hurali97 hurali97 commented Jul 24, 2024

Copy link
Copy Markdown
Contributor

Fixed Issues

$ Expensify/App#45275

Tests

  1. What unit/integration tests cover your change? What autoQA tests cover your change?
    • Adjusted Logger-test.js to test for extraData argument
  2. What tests did you perform that validates your changed worked?
    • Applied the changes locally to this PR. The extraData parameter will not be printed in the Debug Console and it's only exported to the logs file.

QA

  1. What does QA need to do to validate your changes?
  2. What areas to they need to test for regressions?

Following are the steps from the linked PR, which can be followed by the QA for testing.

Testing:

  • Run the app on environment other than Dev
  • Enable Client side logging
  • Close the App and re launch it
  • Click on View debug console in Settings-> Trouble Shoot
  • Click on the three dot menu
  • Filter the logs to Network
  • You should only see logs with Network keyword
  • Download the network only logs
  • Change the extension to .json and open in any editor
  • Verify that the output is readable and contains request and response data for API related logs

You can also follow the video:

Video
logs.mp4

@github-actions

github-actions Bot commented Jul 24, 2024

Copy link
Copy Markdown

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@hurali97

Copy link
Copy Markdown
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@hurali97
hurali97 marked this pull request as ready for review July 26, 2024 12:48
@hurali97
hurali97 requested a review from a team as a code owner July 26, 2024 12:48
@melvin-bot
melvin-bot Bot requested review from pecanoro and removed request for a team July 26, 2024 12:49
@pecanoro
pecanoro requested a review from puneetlath July 26, 2024 15:27
@puneetlath
puneetlath merged commit 720929d into Expensify:main Jul 29, 2024
@github-actions

Copy link
Copy Markdown

🚀Published to npm in v2.0.60

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants