[TS migration] Migrate str to Typescript (expensify-common)

[blazejkustra]

The PR aims to migrate Str module to Typescript, it also removes almost all underscore usage from str and instead uses native JS.

Fixed Issues

$ GH_LINK

[Skalakid]

LGTM, left some small comments connected to function descriptions, to make them have a consistent format

[github-actions]

🚀Published to npm in v2.0.10

[aldo-expensify]

Hmmm, now that str.js was migrated to str.ts, Web-Expensify complains if I try to update expensify-common to the current version;

Running "browserify:web" (browserify) task
>> Error: Can't walk dependency graph: Cannot find module 'expensify-common/lib/str' from '/Users/aldocanepa/Expensidev/Web-Expensify/site/shared.js'
>>     required by /Users/aldocanepa/Expensidev/Web-Expensify/site/shared.js
Warning: Error running grunt-browserify. Use --force to continue.

I wonder if the Web-Expensify project supports ts in its dependencies or not.

[blazejkustra]

@aldo-expensify What command do you use to update expensify-common? (I think you need to install it from npm with npm install expensify-common)

[aldo-expensify]

hmm I updated manually the expensify-common hash in package.json (it is pointing to a specific commit), then I run npm install which updates package-lock.json. Does that give a different result compared to what you proposed?

[blazejkustra]

Does that give a different result compared to what you proposed?

Yes, this is because with TS there is a build step before the package is published to NPM. It was introduced here.

You can also try building locally to test your changes (npm run build & npm pack and copy the package contents to Expensify-Web's node_modules)

[aldo-expensify]

ahh, maybe if I had updated the imports in Web-Expensify to look like this it could have worked:

Currently the import looks like this:

I think Web-Expensify uses a pretty old/custom import system