allow heading inside a quote

[eh2077]

Fixed Issues

Expensify/App#17367

Tests

1. Send a message, > # heading
2. Verify the text is displayed in as header inside the quote
3. Send following message

========= test case 1 ========
> [quote] case 1
> # heading
> [quote] case 1

[normal] case 1
# heading
[normal] case 1

========= test case 2 ========
> [quote] case 2
> 
> # heading
> 
> [quote] case 2

[normal] case 2

# heading

[normal] case 2

4. Verify normal heading and heading inside quote have the same line break handling

Screen.Recording.2023-04-25.at.11.57.42.AM.mov

QA

Same as Tests above

[pecanoro]

@Santhosh-Sellavel I think if you leave a comment I will be able to add you as a reviewer, I think the settings for this repo are not properly set so I can't add external people.

[Santhosh-Sellavel]

Adding myself as a reviewer

[hayata-suenaga]

The test cases make sense. I'm not well versed in markdown and string manipulation. I'd wait other people's preview.

[Santhosh-Sellavel]

LGTM, @pecanoro all yours!

Will test PR against E/APP!

[pecanoro]

Tested well!

[pecanoro]

@Santhosh-Sellavel @eh2077 Do you know why we remove the empty line after the heading in case 2 but we leave the one above the heading? I mean, that's the behavior with and without quotes but I find it pretty odd.

[eh2077]

@Santhosh-Sellavel @eh2077 Do you know why we remove the empty line after the heading in case 2 but we leave the one above the heading? I mean, that's the behavior with and without quotes but I find it pretty odd.

@pecanoro That's an interesting question. I guessed it's just because the product team want to have line breaks before heading and want to keep content after heading look compact(so removing line breaks after heading).

[hayata-suenaga]

LGTM!

[eh2077]

@Santhosh-Sellavel @eh2077 Do you know why we remove the empty line after the heading in case 2 but we leave the one above the heading? I mean, that's the behavior with and without quotes but I find it pretty odd.

@pecanoro I just encountered this again in another issue when addressing proposal review feedback from C+ team, see Expensify/App#17998 (comment). I think it's possible to improve this weird line break handling issue in that issue.

[Santhosh-Sellavel]

I believe we are good to go here, for now. We have an active issue to fix or improve that behavior

@pecanoro Do you got your query resolved or still need clarfications?

[pecanoro]

Yes! Sorry, all comments are solved! I took a day off so I couldn't get back to this until today!