Skip to content

[NoQA] fix links for Expensify Help site #9925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marcochavezf merged 4 commits into from
Jul 15, 2022
Merged

[NoQA] fix links for Expensify Help site #9925

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6f5674b
fix links for navigateBack
marcochavezf Jul 14, 2022
6ac6612
add eslint-disable to the main.js file
marcochavezf Jul 14, 2022
486cd3a
disable only "no-unused-vars" eslint rule
marcochavezf Jul 14, 2022
8b6c31f
fix homepage link and move it to a function
marcochavezf Jul 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/_includes/home-lhn.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<ul class="lhn-items">
<li class="home-link">
<a href="/index.html">Home</a>
<div class="link" onclick="navigateToHome()">Home</div>
</li>
<li>
<div onclick="navigateTo('/hubs/send-money')" class="icon-with-link">
Expand Down
2 changes: 1 addition & 1 deletion docs/_includes/request-money-lhn.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<ul class="lhn-items">
<li class="home-link">
<a href="/index.html">Home</a>
<div class="link" onclick="navigateToHome()">Home</div>
</li>
<li>
<div onclick="navigateTo('/hubs/send-money')" class="icon-with-link">
Expand Down
2 changes: 1 addition & 1 deletion docs/_includes/send-money-lhn.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<ul class="lhn-items">
<li class="home-link">
<a href="/index.html">Home</a>
<div class="link" onclick="navigateToHome()">Home</div>
</li>
<li>
<div class="icon-with-link selected">
Expand Down
16 changes: 11 additions & 5 deletions docs/assets/js/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,15 @@

function navigateTo(path) { // eslint-disable-line no-unused-vars
/* eslint-disable no-unused-vars */
function navigateTo(path) {
window.location.href = path;
}

function toggleHeaderMenu() { // eslint-disable-line no-unused-vars
function navigateToHome() {
// TODO: Change to '/index' when the site is live
navigateTo('/main');
}

function toggleHeaderMenu() {
const lhn = document.getElementById('lhn');
const lhnContent = document.getElementById('lhn-content');
const anguleUpIcon = document.getElementById('angle-up-icon');
Expand All @@ -23,11 +29,11 @@ function toggleHeaderMenu() { // eslint-disable-line no-unused-vars
}
}

function navigateBack() { // eslint-disable-line no-unused-vars
function navigateBack() {
if (window.location.pathname.includes('/request-money/')) {
window.location.href = '/hubs/request-money/';
window.location.href = '/hubs/request-money';
} else {
window.location.href = '/hubs/send-money/';
window.location.href = '/hubs/send-money';
}

// Add a little delay to avoid showing the previous content in a fraction of a time
Expand Down