[No QA] Update iOS build workflows to Xcode 26.6 - #97593
Conversation
Cache Pod dependencies cache key|
@thelullabyy Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 48814fb3e4
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
This comment has been minimized.
This comment has been minimized.
|
🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
Explanation of Change
Re-applies the Xcode 26.6 bump (previously #97452, reverted in #97580 after it broke the staging TestFlight build). This time the version is extracted into a single
getXcodeVersioncomposite action that exportsDEVELOPER_DIR, so future bumps change one place instead of five. It also adds the Xcode version to theCache Pod dependencieskey, so a toolchain change busts the cache instead of linking Pods compiled by a different Xcode (the mixed-toolchain link that crashed 9.4.47.0 on launch).Fixed Issues
$ #97450
PROPOSAL:
Tests
remote-build-ios.ymlagainst this branch withreviewed_code=true.Set up Xcode versionstep runs andDEVELOPER_DIR=/Applications/Xcode_26.6.app/Contents/Developeris exported.testBuild.ymlwithIOS=trueandREVIEWED_CODE=true; verify the ad-hoc IPA builds, installs on a device, and the app launches to the sign-in screen with nodyld"Symbol not found" crash.buildIOS.ymlrun log, open theCache Pod dependenciesstep and verify the cache key contains the Xcode version segment (e.g....-pods-cache-26.6-...).Offline tests
N/A — CI build-configuration change only, no app runtime behavior.
QA Steps
[No QA] — GitHub Actions / iOS build-pipeline change only; no user-facing behavior. Validated via the CI dispatches in the Tests section.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari