Bump Onyx to 3.0.89 (re-land of #93436) by fabioh8010 · Pull Request #96523 · Expensify/App

fabioh8010 · 2026-07-20T19:50:11Z

Explanation of Change

Bumps Onyx to 3.0.89, which includes this changes:

Remove waitForCollectionCallback from Onyx react-native-onyx#799

Fixed Issues

$ #94331
PROPOSAL:

Tests

We are basically just removing waitForCollectionCallback usage here, functionality should stay the same so we only need to test the two files where we actually did some meaningful change (Report/index.ts and replaceOptimisticReportWithActualReport.ts).

Go to Offline mode.
Start a chat with an user that exists but you never messaged before.
Send a message to that user.
Go back to Online mode, assert the message is still there and the user is still the correct one.
Delete the message you just sent, assert it works.

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Same as Tests.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

Screen.Recording.2026-06-30.at.08.46.47.mov

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-06-30.at.08.40.31.mov

…eature/onyx-store-pr-1" This reverts commit e6b8b0f.

…nal PR These 5 subscriptions were introduced on main after PR Expensify#93436 merged, so the revert-the-revert did not cover them. All used whole-collection mode already; with Onyx 3.0.89 the option no longer exists, so drop it. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

github-actions · 2026-07-20T19:50:29Z

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

codecov · 2026-07-20T20:00:52Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/libs/Fullstory/common.ts	`0.00% <ø> (ø)`
src/libs/Middleware/Pagination.ts	`98.41% <ø> (ø)`
...s/Navigation/guards/SubmitPlanWelcomeModalGuard.ts	`97.14% <ø> (ø)`
src/libs/Notification/LocalNotification/index.ts	`0.00% <ø> (ø)`
...ion/PushNotification/shouldShowPushNotification.ts	`30.76% <ø> (ø)`
src/libs/OptionsListUtils/index.ts	`86.89% <ø> (ø)`
src/libs/Parser.ts	`93.33% <ø> (ø)`
src/libs/ReportActionsUtils.ts	`78.42% <ø> (ø)`
src/libs/ReportTitleUtils.ts	`100.00% <ø> (ø)`
src/libs/ReportUtils.ts	`86.23% <ø> (+0.06%)`	⬆️
... and 18 more
... and 6 files with indirect coverage changes

…alReport allReportActions is now the whole-collection snapshot keyed by full Onyx keys, but this hasReportActions check (added on main after PR Expensify#93436) still indexed by the bare parentReportID, so it always resolved to false and openReport received hasReportActions: false. Use the full REPORT_ACTIONS key. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

melvin-bot · 2026-07-20T20:13:50Z

@truph01 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 17a720f882

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

joekaufmanexpensify · 2026-07-20T20:50:44Z

No product review needed.

truph01 · 2026-07-21T16:40:59Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained """"why"""" the code was doing something instead of only explaining """"what"""" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-07-22.at.01.57.54.mov

mountiny

Thanks

github-actions · 2026-07-21T21:44:23Z

🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-07-21T21:51:18Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #96523.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-1121b1329d6-7656fc8-cd239a83389a593672e29f7f12c4fb7a5140662d/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-1121b13-7656fc8-4a5cbd9eca5521c1ec8b13c7be3bbbeb0d1090e3/index.html

Web 🕸️
https://96523.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-07-22T06:32:32Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.4.42-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MelvinBot · 2026-07-22T06:34:09Z

🤖 Help site review: no changes required.

I reviewed the changes in this PR against Expensify's help site files under App/docs/articles.

This PR bumps react-native-onyx to 3.0.89 and removes the now-unnecessary waitForCollectionCallback flag from Onyx.connect calls across internal libraries and tests. As the PR description notes, functionality is unchanged — there are no new or modified user-facing features, flows, settings labels, tab names, or buttons.

Because nothing user-facing changed, no help site documentation updates are needed and no draft docs PR was created.

@fabioh8010, if you believe a user-facing behavior did change and warrants a help site update, let me know and I'll draft the docs PR.

IuliiaHerets · 2026-07-22T07:08:22Z

@fabioh8010 it is a dupe of #93436

mountiny · 2026-07-22T13:08:39Z

@IuliiaHerets That Pr was reverted so we are re-landing it now, can you do the QA based on the test steps?

IuliiaHerets · 2026-07-22T13:25:11Z

@mountiny We tested it here in the current regression.
Do we need to recheck? The steps are the same

mountiny · 2026-07-22T14:20:09Z

Ah I see the confusion the original PR was also listed on the checklist. Then no need to test again thanks

IuliiaHerets · 2026-07-22T14:39:54Z

Original PR was passed, so I checked off both of them

OSBotify · 2026-07-22T21:22:00Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.4.42-1 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android

fabioh8010 and others added 2 commits July 20, 2026 20:43

Reapply "Merge pull request Expensify#93436 from callstack-internal/f…

b6e30b1

…eature/onyx-store-pr-1" This reverts commit e6b8b0f.

melvin-bot Bot assigned fabioh8010 Jul 20, 2026

fabioh8010 marked this pull request as ready for review July 20, 2026 20:13

fabioh8010 requested review from a team as code owners July 20, 2026 20:13

melvin-bot Bot requested review from joekaufmanexpensify and truph01 July 20, 2026 20:13

melvin-bot Bot removed request for a team July 20, 2026 20:13

fabioh8010 mentioned this pull request Jul 20, 2026

[Due for payment 2026-07-29] [$250] Collapse Onyx collection-key subscriptions to a single whole-collection delivery mode and remove the waitForCollectionCallback option #94331

Open

chatgpt-codex-connector Bot reviewed Jul 20, 2026

View reviewed changes

Comment thread package.json

joekaufmanexpensify removed their request for review July 20, 2026 20:50

truph01 approved these changes Jul 21, 2026

View reviewed changes

melvin-bot Bot requested a review from mountiny July 21, 2026 18:59

mountiny approved these changes Jul 21, 2026

View reviewed changes

mountiny merged commit 1121b13 into Expensify:main Jul 21, 2026
47 of 49 checks passed

github-actions Bot mentioned this pull request Jul 21, 2026

[Due for payment 2026-07-29] Investigate workflow job failing on main: typecheck / typecheck #96691

Closed

OSBotify mentioned this pull request Jul 22, 2026

Deploy Checklist: New Expensify 2026-07-22 #96704

Closed

49 tasks

wildan-m mentioned this pull request Jul 24, 2026

[$250] [DEV] Expense report/thread not loading properly #96718

Open

7 tasks

KJ21-ENG mentioned this pull request Jul 24, 2026

[$250] [DEV] Infinite loading when switching to Inbox #96716

Open

7 tasks

Uh oh!

Conversation

fabioh8010 commented Jul 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

github-actions Bot commented Jul 20, 2026

Uh oh!

codecov Bot commented Jul 20, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot Bot commented Jul 20, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

joekaufmanexpensify commented Jul 20, 2026

Uh oh!

truph01 commented Jul 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Jul 21, 2026

Uh oh!

github-actions Bot commented Jul 21, 2026

Uh oh!

OSBotify commented Jul 22, 2026

Uh oh!

MelvinBot commented Jul 22, 2026

Uh oh!

IuliiaHerets commented Jul 22, 2026

Uh oh!

mountiny commented Jul 22, 2026

Uh oh!

IuliiaHerets commented Jul 22, 2026

Uh oh!

mountiny commented Jul 22, 2026

Uh oh!

IuliiaHerets commented Jul 22, 2026

Uh oh!

OSBotify commented Jul 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

fabioh8010 commented Jul 20, 2026 •

edited

Loading

codecov Bot commented Jul 20, 2026 •

edited by github-actions Bot

Loading

truph01 commented Jul 21, 2026 •

edited

Loading