Skip to content

[CP Staging] Revert "Fix: Circle icon showing behind back button on workspace pages in landscape mode"#95999

Merged
jasperhuangg merged 1 commit into
mainfrom
revert-94218-90374/circle-icon-in-landscape-mode
Jul 13, 2026
Merged

[CP Staging] Revert "Fix: Circle icon showing behind back button on workspace pages in landscape mode"#95999
jasperhuangg merged 1 commit into
mainfrom
revert-94218-90374/circle-icon-in-landscape-mode

Conversation

@jasperhuangg

@jasperhuangg jasperhuangg commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Reverts #94218

$ #95863
$ #90374

cc @mountiny

@jasperhuangg
jasperhuangg requested review from a team as code owners July 13, 2026 20:23
@melvin-bot
melvin-bot Bot requested review from Gonals and heyjennahay and removed request for a team July 13, 2026 20:23
@melvin-bot

melvin-bot Bot commented Jul 13, 2026

Copy link
Copy Markdown

@Gonals Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@mountiny mountiny changed the title Revert "Fix: Circle icon showing behind back button on workspace pages in landscape mode" [CP Staging] Revert "Fix: Circle icon showing behind back button on workspace pages in landscape mode" Jul 13, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 96e7224839

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/libs/Navigation/AppNavigator/useSplitNavigatorScreenOptions.ts
@jasperhuangg
jasperhuangg merged commit 52c31d2 into main Jul 13, 2026
45 of 48 checks passed
@jasperhuangg
jasperhuangg deleted the revert-94218-90374/circle-icon-in-landscape-mode branch July 13, 2026 20:40
@jasperhuangg

Copy link
Copy Markdown
Contributor Author

straight revert

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify pushed a commit that referenced this pull request Jul 13, 2026
…on-in-landscape-mode

[CP Staging] Revert "Fix: Circle icon showing behind back button on workspace pages in landscape mode"

(cherry picked from commit 52c31d2)

(cherry-picked to staging by jasperhuangg)
@OSBotify OSBotify added the CP Staging marks PRs that have been CP'd to staging label Jul 13, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🚧 jasperhuangg has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/jasperhuangg in version: 9.4.33-4 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor

🤖 I reviewed the changes in this PR and no help site changes are required.

This PR reverts a UI/layout fix — it only changes internal navigation screen options (useSplitNavigatorScreenOptions.ts) and a style rule (src/styles/index.ts). It removes a contentStyle/backgroundColor (appBG) applied to split-navigator screens and a header bar background.

There are no new or changed features, settings, tab names, buttons, or user-facing workflows — nothing that any article under App/docs/articles describes. Because the help site documents product behavior and features rather than internal rendering/layout details, there is nothing to add, remove, or correct here.

No draft docs PR was created since there are no help site changes to make.

@jasperhuangg, since no user-facing behavior changed, there is no linked help site PR to review here. If you believe a docs update is warranted, let me know what behavior changed and I'll draft one.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/lakchote in version: 9.4.33-8 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/jasperhuangg in version: 9.4.34-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor

🤖 I reviewed the changes in this PR and no help site changes are required.

This PR reverts a UI/layout fix. It only changes internal navigation screen options (useSplitNavigatorScreenOptions.ts) and one style rule (src/styles/index.ts), removing a contentStyle/backgroundColor (appBG) applied to split-navigator screens and a header bar background.

There are no new or changed features, tab names, settings labels, buttons, or user-facing workflows — nothing that any article under App/docs/articles describes. The help site documents product behavior and features, not internal rendering/layout details, so there's nothing to add, remove, or correct.

No draft docs PR was created since there are no help site changes to make.

@jasperhuangg, since no user-facing behavior changed, there is no linked help site PR to review here. If you believe a docs update is warranted, let me know which behavior changed and I'll draft one.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/roryabraham in version: 9.4.34-14 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 failure ❌
🍎 iOS 🍎 failure ❌

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/roryabraham in version: 9.4.34-14 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CP Staging marks PRs that have been CP'd to staging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants