[CP Staging] Fix e-card search not working#95996
Conversation
|
@bernhardoj Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
[CP Staging] Fix e-card search not working (cherry picked from commit 25a26ed) (cherry-picked to staging by jasperhuangg)
|
🚧 jasperhuangg has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Cherry-picked to staging by https://github.com/jasperhuangg in version: 9.4.33-3 🚀
|
|
🤖 No help site changes required. I reviewed the changes in this PR against Expensify's help site files under Why: This PR is a single-file bug fix to the shared It does not add or change any user-facing feature, workflow, setting, tab, or button label, and no help article documents this table/search empty-state rendering behavior. There is therefore nothing to update on the help site and no draft PR to create. @JS00001, since no help site changes are required, no draft PR was created. If you believe a specific article should still be updated, reply here with the article and what should change and I'll take another look. |
|
🚀 Deployed to production by https://github.com/lakchote in version: 9.4.33-8 🚀
Bundle Size Analysis (Sentry): |
|
🚀 Cherry-picked to staging by https://github.com/jasperhuangg in version: 9.4.34-0 🚀
|
|
🤖 I already reviewed this PR against the help site files under This is an internal bug fix to the shared @JS00001, if you believe a specific article should still be updated, reply here with the article and what should change and I'll take another look. |
|
🚀 Deployed to production by https://github.com/roryabraham in version: 9.4.34-14 🚀
|
|
🚀 Deployed to production by https://github.com/roryabraham in version: 9.4.34-14 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Fixed Issues
$ #95960
Tests
Precondition:
Workspace has at least one Expensify Card.
Go to workspace settings > Expensify Card.
Click on the search field.
Enter anything that will not return result.
Ensure that an empty state is shown
Offline tests
N/A
QA Steps
Same as tests
PR Author Checklist
Reviewer Checklist
### Fixed Issuessection aboveTestssectionQA stepssectiontoggleReportand notonIconClick).Avatar, I verified the components usingAvatarhave been tested & I retested again)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Screen.Recording.2026-07-13.at.4.03.19.PM.mov