[CP Staging] Revert "[No QA] Fix leader-election deadlock in ActiveClientManager (SequentialQueue unable to flush)" by grgia · Pull Request #95718 · Expensify/App

grgia · 2026-07-09T15:09:48Z

#95148 added: if a tab sees the list without its own GUID, it re-appends itself. Sign-in resets ACTIVE_CLIENTS, so every open tab re-appends simultaneously. Each append puts that tab last in the list, so while the writes race, multiple tabs simultaneously pass the isClientTheLeader() check.

RequestNewValidateCode is one persisted request in the shared queue. Each self-believed leader flushes it before seeing another tab's dequeue, so it's sent once per tab: 7 tabs, 7 API calls, 7 emails. BeginSignIn wasn't duplicated because it bypasses the queue. Any queued write is affected, which is why SignUpUser duplicated too.

…SequentialQueue unable to flush)"

github-actions · 2026-07-09T15:14:48Z

🚧 grgia has triggered a test Expensify/App build. You can view the workflow run here.

melvin-bot · 2026-07-09T15:15:27Z

@pecanoro Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

grgia · 2026-07-09T15:15:47Z

@pecanoro added the team from offending PR, no worries

melvin-bot · 2026-07-09T15:16:08Z

@pecanoro Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

codecov · 2026-07-09T15:16:19Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/libs/ActiveClientManager/index.ts	`0.00% <0.00%> (-76.48%)`	⬇️
... and 14 files with indirect coverage changes

github-actions · 2026-07-09T15:18:29Z

🚧 grgia has triggered a test Expensify/App build. You can view the workflow run here.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: fcd33c590d

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-07-09T15:18:29Z

+        if (removed) {
            setActiveClients(activeClients);


Re-register a live client after ACTIVE_CLIENTS is cleared

When a live Onyx reset path that does not preserve ONYXKEYS.ACTIVE_CLIENTS runs (for example clearOnyxAndResetApp()/the 2FA clear path using KEYS_TO_PRESERVE), this callback now accepts the incoming empty or stale list and only writes back when trimming. That leaves every surviving tab without its own GUID in activeClients, so isClientTheLeader() returns false and SequentialQueue.flush() takes the follower early return; queued writes such as the OpenApp issued immediately after the reset are persisted but never sent until a later app-state transition or refresh calls init() again.

Useful? React with 👍 / 👎.

grgia · 2026-07-09T15:36:27Z

tested, confirmed fix

OSBotify · 2026-07-09T15:42:01Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

…ader-election-deadlock [CP Staging] Revert "[No QA] Fix leader-election deadlock in ActiveClientManager (SequentialQueue unable to flush)" (cherry picked from commit b1e92e9) (cherry-picked to staging by grgia)

github-actions · 2026-07-09T16:20:50Z

🚧 grgia has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-07-09T16:50:21Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #95718.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-b1e92e97f55-3ded924-45913a17ee4f50472e6f778a4b6e4b35b2cd6d08/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-b1e92e9-3ded924-060e6da5d4ced56a2f15ac08a064d4f485845238/index.html

Web 🕸️
https://95718.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-07-09T16:57:13Z

🚀 Cherry-picked to staging by https://github.com/grgia in version: 9.4.32-1 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

MelvinBot · 2026-07-09T17:06:43Z

🤖 No help-site changes required.

I reviewed the changes in this PR against docs/articles, and no updates are needed. This is a purely internal-infrastructure revert with no user-facing impact:

src/libs/ActiveClientManager/index.ts — client-side leader election for the SequentialQueue (which browser tab drains the persisted request queue). Internal plumbing only.
contributingGuides/SEQUENTIAL_QUEUE.md — a contributor guide, not a help-site article.
tests/unit/ActiveClientManagerTest.ts — a unit test.

None of these touch a documented, user-facing feature, setting, tab, or button. The help site (docs/articles) has no article describing multi-tab leader election or sequential-queue behavior — the only near-match (Partner-Billing-Guide.md) uses "active clients" in a billing-seat sense, which is unrelated. Since no docs changes are needed, I did not open a draft help-site PR.

@grgia, there's no linked help site PR to review here since no documentation changes were required. If you believe this revert does affect a user-facing behavior that's documented, let me know and I'll open one.

OSBotify · 2026-07-09T19:15:29Z

🚀 Cherry-picked to staging by https://github.com/grgia in version: 9.4.32-1 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	cancelled 🔪
🍎 iOS 🍎	success ✅

MelvinBot · 2026-07-09T19:18:23Z

🤖 No help site changes required.

I reviewed the changes in this PR. This is a revert of an internal leader-election fix in ActiveClientManager / SequentialQueue. The files touched are:

contributingGuides/SEQUENTIAL_QUEUE.md — an internal contributing guide (not part of the public help site)
src/libs/ActiveClientManager/index.ts — internal source code
tests/unit/ActiveClientManagerTest.ts — a unit test (deleted)

These are purely internal plumbing changes (cross-tab leader election / persisted request queue) with no user-facing feature, setting, or UI behavior change. Nothing here corresponds to any article under App/docs/articles, so no draft docs PR was created.

@grgia, if you believe there's a customer-facing behavior change I've missed that should be documented, let me know and I'll draft the help site update.

OSBotify · 2026-07-10T13:44:56Z

🚀 Deployed to production by https://github.com/grgia in version: 9.4.32-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android

OSBotify · 2026-07-10T16:20:11Z

🚀 Cherry-picked to staging by https://github.com/grgia in version: 9.4.33-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	cancelled 🔪

MelvinBot · 2026-07-10T16:23:17Z

🤖 No help site changes required.

I reviewed the changes in this PR against the help site files under docs/articles. No draft docs PR is needed.

Why: This PR reverts an internal, client-side fix — it has no customer-facing behavior to document. The three changed files are all internal:

src/libs/ActiveClientManager/index.ts — leader-election logic across browser tabs (ACTIVE_CLIENTS)
contributingGuides/SEQUENTIAL_QUEUE.md — an internal contributor guide, not a help site article
tests/unit/ActiveClientManagerTest.ts — a unit test

The help site (docs/articles) documents customer-facing product behavior — billing, workspaces, integrations, expense/report flows, etc. Nothing in this revert changes any of that, so there is no article to update.

Since no docs changes are required, no draft help site PR was created — there's nothing to mark Ready for review. cc @grgia

OSBotify · 2026-07-14T11:18:18Z

🚀 Deployed to production by https://github.com/lakchote in version: 9.4.33-8 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android

Revert "[No QA] Fix leader-election deadlock in ActiveClientManager (…

fcd33c5

…SequentialQueue unable to flush)"

melvin-bot Bot assigned grgia Jul 9, 2026

grgia changed the title ~~Revert "[No QA] Fix leader-election deadlock in ActiveClientManager (SequentialQueue unable to flush)"~~ [CP Staging] Revert "[No QA] Fix leader-election deadlock in ActiveClientManager (SequentialQueue unable to flush)" Jul 9, 2026

grgia marked this pull request as ready for review July 9, 2026 15:14

grgia requested review from a team as code owners July 9, 2026 15:14

melvin-bot Bot requested review from joekaufmanexpensify and removed request for a team July 9, 2026 15:14

grgia requested review from elirangoshen, luacmartins and mountiny July 9, 2026 15:15

melvin-bot Bot requested review from pecanoro and removed request for a team July 9, 2026 15:15

grgia requested review from a team and removed request for joekaufmanexpensify and pecanoro July 9, 2026 15:15

melvin-bot Bot requested review from pecanoro and removed request for a team July 9, 2026 15:16

chatgpt-codex-connector Bot reviewed Jul 9, 2026

View reviewed changes

pecanoro approved these changes Jul 9, 2026

View reviewed changes

This comment has been minimized.

Sign in to view

grgia merged commit b1e92e9 into main Jul 9, 2026
52 checks passed

grgia deleted the revert-95148-eliran/94963-leader-election-deadlock branch July 9, 2026 15:36

grgia mentioned this pull request Jul 9, 2026

Sign in - Single button press sends 4-5 magic code emails #95705

Closed

7 tasks

OSBotify added the CP Staging marks PRs that have been CP'd to staging label Jul 9, 2026

OSBotify mentioned this pull request Jul 9, 2026

Deploy Checklist: New Expensify 2026-07-09 #95677

Closed

94 tasks

Uh oh!

Conversation

grgia commented Jul 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 9, 2026

Uh oh!

melvin-bot Bot commented Jul 9, 2026

Uh oh!

grgia commented Jul 9, 2026

Uh oh!

melvin-bot Bot commented Jul 9, 2026

Uh oh!

codecov Bot commented Jul 9, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions Bot commented Jul 9, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Jul 9, 2026

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

This comment has been minimized.

grgia commented Jul 9, 2026

Uh oh!

Uh oh!

OSBotify commented Jul 9, 2026

Uh oh!

github-actions Bot commented Jul 9, 2026

Uh oh!

github-actions Bot commented Jul 9, 2026

Uh oh!

OSBotify commented Jul 9, 2026

Uh oh!

MelvinBot commented Jul 9, 2026

Uh oh!

OSBotify commented Jul 9, 2026

Uh oh!

MelvinBot commented Jul 9, 2026

Uh oh!

OSBotify commented Jul 10, 2026

Uh oh!

OSBotify commented Jul 10, 2026

Uh oh!

MelvinBot commented Jul 10, 2026

Uh oh!

OSBotify commented Jul 14, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

grgia commented Jul 9, 2026 •

edited

Loading

codecov Bot commented Jul 9, 2026 •

edited by github-actions Bot

Loading