Skip to content

[No QA] Docs updates for E/A#95488 empty value validation for CSV card import#95688

Merged
greg-schroeder merged 2 commits into
mainfrom
docs-empty-mapped-field-csv-95488
Jul 24, 2026
Merged

[No QA] Docs updates for E/A#95488 empty value validation for CSV card import#95688
greg-schroeder merged 2 commits into
mainfrom
docs-empty-mapped-field-csv-95488

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Explanation of Change

#95488 added validation to the Import transactions from file flow so that mapping a required field (Card Number, Date, Amount, or Merchant) to a spreadsheet column that contains one or more empty values now shows an error and blocks the import until every row in that column has a value.

This PR documents that new behavior by adding a short FAQ entry to the Import Company Card Transactions From a Spreadsheet help article, alongside the existing FAQ about mapping the same column twice.

Related


@Gonals, please review the files changed and confirm they reflect the current behavior. Then mark this PR Ready for review.

…umns

Co-authored-by: Alberto Gonzalez-Cela <Gonals@users.noreply.github.com>
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Jul 9, 2026
@github-actions github-actions Bot changed the title Docs updates for E/A#95488 empty value validation for CSV card import [No QA] Docs updates for E/A#95488 empty value validation for CSV card import Jul 9, 2026
@OSBotify

This comment has been minimized.

@stephanieelliott
stephanieelliott marked this pull request as ready for review July 14, 2026 04:38
@stephanieelliott
stephanieelliott self-requested a review as a code owner July 14, 2026 04:38
@OSBotify

Copy link
Copy Markdown
Contributor

A preview of your ExpensifyHelp changes have been deployed to https://f30cb3e3.helpdot.pages.dev ⚡️

Updated articles:

@github-actions

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR adds a single, focused FAQ entry to the Import Company Card Transactions From a Spreadsheet article, documenting the new "Oops!" empty-value validation error introduced in the source PR. The change is small, well-scoped, and sits naturally alongside the existing FAQ about mapping the same column twice. Assessment is based only on the added lines in the diff.

Scores Summary

  • Readability: 9/10 - The answer is clear, concise, and actionable, telling the user exactly what caused the error and how to resolve it. Well suited to the FAQ format.
  • AI Readiness: 9/10 - The heading is a natural-language question starting with a question word ("Why"), matching real search intent, and uses full, UI-exact field names. Fits the single-workflow FAQ pattern. No metadata changes needed since this is an addition to an existing article.
  • Style Compliance: 8/10 - Field names (Card Number, Date, Amount, Merchant) are correctly bolded and consistent with the required-columns list already in the article. "Oops!" is quoted, which is acceptable here as it reflects the exact error text shown in the product.

Key Findings

  • Positive: The entry is task/question-based, matches the exact UI error wording, and reuses the same bolded field labels already defined in this article, so terminology stays consistent.
  • Positive: Scope is tight and the placement next to the related mapping-error FAQ is logical.
  • Minor: The new heading line has trailing whitespace that should be removed.
  • Minor: Confirm "Oops!" matches the exact casing/punctuation of the product error string; if the UI shows different text, align the heading and body to it.

Recommendations

  • Remove the trailing whitespace on the new heading line.
  • Verify the "Oops!" wording against the actual product error string for exact-match compliance.

Files Reviewed

  • docs/articles/new-expensify/connect-credit-cards/Import-Company-Card-Transactions-From-a-Spreadsheet.md - One new FAQ entry added; compliant with authoring and naming conventions, minor whitespace nit.

Note: Detailed line-by-line feedback has been provided as inline comments.

@stephanieelliott
stephanieelliott requested a review from a team July 14, 2026 05:04
@melvin-bot

melvin-bot Bot commented Jul 14, 2026

Copy link
Copy Markdown

Concierge reviewer checklist:

  • I have verified the accuracy of the article
    • The article is within a hub that makes sense, and the navigation is correct
    • All processes, screenshots, and examples align with current product behavior.
    • All links within the doc have been verified for correct destination and functionality.
  • I have verified the readability of the article
    • The article's language is clear, concise, and free of jargon.
    • The grammar, spelling, and punctuation are correct.
    • The article contains at least one image, or that an image is not necessary
  • I have verified the formatting of the article
    • The article has consistent formatting (headings, bullet points, etc.) with other HelpDot articles and that aligns with the HelpDot formatting standards.
    • The article has proper text spacing and breaks for readability.
  • I have verified the article has the appropriate tone and style
    • The article's tone is professional, friendly, and suitable for the target audience.
    • The article's tone, terminology, and voice are consistent throughout.
  • I have verified the overall quality of the article
    • The article is not missing any information, nor does it contain redundant information.
    • The article fully addresses user needs.
  • I have verified that all requested improvements have been addressed

For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member?

cc @greg-schroeder

@melvin-bot
melvin-bot Bot requested review from greg-schroeder and removed request for a team July 14, 2026 05:04
@melvin-bot

melvin-bot Bot commented Jul 14, 2026

Copy link
Copy Markdown

@greg-schroeder Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@stephanieelliott

Copy link
Copy Markdown
Contributor

Bump @greg-schroeder

@greg-schroeder
greg-schroeder merged commit 6dd0120 into main Jul 24, 2026
19 checks passed
@greg-schroeder
greg-schroeder deleted the docs-empty-mapped-field-csv-95488 branch July 24, 2026 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants