[NoQA] Revert onyx bump

package.json

@@ -195,7 +195,7 @@
     "react-native-localize": "^3.5.4",
     "react-native-nitro-modules": "0.35.0",
     "react-native-nitro-sqlite": "9.6.0",
-    "react-native-onyx": "3.0.89",
+    "react-native-onyx": "3.0.88",
     "react-native-pager-view": "8.0.0",
     "react-native-pdf": "7.0.2",
     "react-native-permissions": "^5.4.0",

src/libs/DistanceRequestUtils.ts

@@ -37,6 +37,7 @@ let allPolicies: OnyxCollection<Policy>;
 
 Onyx.connectWithoutView({
     key: ONYXKEYS.COLLECTION.POLICY,
+    waitForCollectionCallback: true,
     callback: (value) => (allPolicies = value),
 });
 

src/libs/Fullstory/common.ts

@@ -18,6 +18,7 @@ import type {GetChatFSClass, ShouldInitialize} from './types';
 let allReports: OnyxCollection<Report>;
 Onyx.connectWithoutView({
     key: ONYXKEYS.COLLECTION.REPORT,
+    waitForCollectionCallback: true,
     callback: (value) => {
         allReports = value;
     },

src/libs/Middleware/Pagination.ts

@@ -67,12 +67,14 @@ function registerPaginationConfig<TResourceKey extends OnyxCollectionKey, TPageK
     } as unknown as PaginationConfigMapValue);
     Onyx.connectWithoutView<OnyxCollectionKey>({
         key: config.resourceCollectionKey,
+        waitForCollectionCallback: true,
         callback: (data) => {
             resources.set(config.resourceCollectionKey, data);
         },
     });
     Onyx.connectWithoutView<OnyxPagesKey>({
         key: config.pageCollectionKey,
+        waitForCollectionCallback: true,
         callback: (data) => {
             pages.set(config.pageCollectionKey, data);
         },

src/libs/Notification/LocalNotification/index.ts

@@ -14,6 +14,7 @@ let allPolicies: OnyxCollection<Policy>;
 // see https://github.com/Expensify/App/issues/66336
 Onyx.connectWithoutView({
     key: ONYXKEYS.COLLECTION.POLICY,
+    waitForCollectionCallback: true,
     callback: (value) => {
         allPolicies = value;
     },
@@ -24,6 +25,7 @@ let allPolicyTags: OnyxCollection<PolicyTagLists>;
 // see https://github.com/Expensify/App/issues/66336
 Onyx.connectWithoutView({
     key: ONYXKEYS.COLLECTION.POLICY_TAGS,
+    waitForCollectionCallback: true,
     callback: (value) => {
         allPolicyTags = value;
     },

src/libs/Notification/PushNotification/shouldShowPushNotification.ts

@@ -29,12 +29,14 @@ Onyx.connectWithoutView({
 let allReportActions: OnyxCollection<ReportActions>;
 Onyx.connectWithoutView({
     key: ONYXKEYS.COLLECTION.REPORT_ACTIONS,
+    waitForCollectionCallback: true,
     callback: (value) => (allReportActions = value),
 });
 
 let allReports: OnyxCollection<ReportType>;
 Onyx.connectWithoutView({
     key: ONYXKEYS.COLLECTION.REPORT,
+    waitForCollectionCallback: true,
     callback: (value) => (allReports = value),
 });
 

src/libs/OptionsListUtils/index.ts

@@ -233,6 +233,7 @@ import {doesPersonalDetailMatchSearchTerm, getCurrentUserSearchTerms, getPersona
 let allReports: OnyxCollection<Report>;
 Onyx.connect({
     key: ONYXKEYS.COLLECTION.REPORT,
+    waitForCollectionCallback: true,
     callback: (value) => {
         allReports = value;
     },
@@ -248,6 +249,7 @@ const deprecatedCachedOneTransactionThreadReportIDs: Record<string, string | und
 let deprecatedAllReportActions: OnyxCollection<ReportActions>;
 Onyx.connect({
     key: ONYXKEYS.COLLECTION.REPORT_ACTIONS,
+    waitForCollectionCallback: true,
     callback: (actions) => {
         if (!actions) {
             return;

src/libs/Parser.ts

@@ -11,6 +11,7 @@ const accountIDToNameMap: Record<string, string> = {};
 let reportIDToNameMap: Record<string, string> = {};
 Onyx.connect({
     key: ONYXKEYS.COLLECTION.REPORT,
+    waitForCollectionCallback: true,
     callback: (value) => {
         // Clear the map so removed reports don’t linger
         reportIDToNameMap = {};

src/libs/ReportActionsUtils.ts

@@ -104,6 +104,7 @@ function isHarvestCreatedExpenseReport(origin?: string, originalID?: string): bo
 let allReportActions: OnyxCollection<ReportActions>;
 Onyx.connect({
     key: ONYXKEYS.COLLECTION.REPORT_ACTIONS,
+    waitForCollectionCallback: true,
     callback: (actions) => {
         if (!actions) {
             return;
@@ -115,6 +116,7 @@ Onyx.connect({
 let allReports: OnyxCollection<Report>;
 Onyx.connect({
     key: ONYXKEYS.COLLECTION.REPORT,
+    waitForCollectionCallback: true,
     callback: (value) => {
         allReports = value;
     },
@@ -141,6 +143,7 @@ Onyx.connect({
 let allReportNameValuePair: OnyxCollection<ReportNameValuePairs>;
 Onyx.connectWithoutView({
     key: ONYXKEYS.COLLECTION.REPORT_NAME_VALUE_PAIRS,
+    waitForCollectionCallback: true,
     callback: (value) => {
         if (!value) {
             return;

src/libs/ReportTitleUtils.ts

@@ -20,6 +20,7 @@ let allReportNameValuePairs: Record<string, ReportNameValuePairs> = {};
  */
 Onyx.connectWithoutView({
     key: ONYXKEYS.COLLECTION.REPORT_NAME_VALUE_PAIRS,
+    waitForCollectionCallback: true,
     callback: (val) => {
         allReportNameValuePairs = (val as Record<string, ReportNameValuePairs>) ?? {};
     },

src/libs/ReportUtils.ts

@@ -1058,13 +1058,15 @@ Onyx.connect({
 let deprecatedAllReportsDraft: OnyxCollection<Report>;
 Onyx.connect({
     key: ONYXKEYS.COLLECTION.REPORT_DRAFT,
+    waitForCollectionCallback: true,
     callback: (value) => (deprecatedAllReportsDraft = value),
 });
 
 let allPolicies: OnyxCollection<Policy>;
 let policiesArray: Policy[] = [];
 Onyx.connect({
     key: ONYXKEYS.COLLECTION.POLICY,
+    waitForCollectionCallback: true,
     callback: (value) => {
         allPolicies = value;
         policiesArray = Object.values(value ?? {}).filter((policy): policy is Policy => !!policy);
@@ -1074,13 +1076,15 @@ Onyx.connect({
 let allPolicyDrafts: OnyxCollection<Policy>;
 Onyx.connect({
     key: ONYXKEYS.COLLECTION.POLICY_DRAFTS,
+    waitForCollectionCallback: true,
     callback: (value) => (allPolicyDrafts = value),
 });
 
 let deprecatedAllReports: OnyxCollection<Report>;
 let deprecatedReportsByPolicyID: ReportByPolicyMap;
 Onyx.connect({
     key: ONYXKEYS.COLLECTION.REPORT,
+    waitForCollectionCallback: true,
     callback: (value) => {
         deprecatedAllReports = value;
 
@@ -1112,6 +1116,7 @@ let deprecatedAllTransactions: OnyxCollection<Transaction> = {};
 let deprecatedReportsTransactions: Record<string, Transaction[]> = {};
 Onyx.connect({
     key: ONYXKEYS.COLLECTION.TRANSACTION,
+    waitForCollectionCallback: true,
     callback: (value) => {
         if (!value) {
             return;
@@ -1137,6 +1142,7 @@ Onyx.connect({
 let allReportActions: OnyxCollection<ReportActions>;
 Onyx.connect({
     key: ONYXKEYS.COLLECTION.REPORT_ACTIONS,
+    waitForCollectionCallback: true,
     callback: (actions) => {
         if (!actions) {
             return;
@@ -1149,6 +1155,7 @@ let allReportMetadata: OnyxCollection<ReportMetadata>;
 const allReportMetadataKeyValue: Record<string, ReportMetadata> = {};
 Onyx.connect({
     key: ONYXKEYS.COLLECTION.REPORT_METADATA,
+    waitForCollectionCallback: true,
     callback: (value) => {
         if (!value) {
             return;
@@ -1178,6 +1185,7 @@ Onyx.connectWithoutView({
 let allReportNameValuePair: OnyxCollection<ReportNameValuePairs>;
 Onyx.connect({
     key: ONYXKEYS.COLLECTION.REPORT_NAME_VALUE_PAIRS,
+    waitForCollectionCallback: true,
     callback: (value) => {
         if (!value) {
             return;

src/libs/UnreadIndicatorUpdater/index.ts

@@ -43,6 +43,7 @@ let allReportNameValuePairs: OnyxCollection<ReportNameValuePairs> = {};
 // This subscription is used to update the unread indicators count which is not linked to UI and it does not update any UI state.
 Onyx.connectWithoutView({
     key: ONYXKEYS.COLLECTION.REPORT_NAME_VALUE_PAIRS,
+    waitForCollectionCallback: true,
     callback: (value) => {
         allReportNameValuePairs = value;
     },
@@ -52,6 +53,7 @@ let allReportActions: OnyxCollection<ReportActions> = {};
 // This subscription is used to update the unread indicators count which is not linked to UI and it does not update any UI state.
 Onyx.connectWithoutView({
     key: ONYXKEYS.COLLECTION.REPORT_ACTIONS,
+    waitForCollectionCallback: true,
     callback: (value) => {
         allReportActions = value;
     },
@@ -60,6 +62,7 @@ Onyx.connectWithoutView({
 let allDraftComments: OnyxCollection<string> = {};
 Onyx.connectWithoutView({
     key: ONYXKEYS.COLLECTION.REPORT_DRAFT_COMMENT,
+    waitForCollectionCallback: true,
     callback: (value) => {
         allDraftComments = value;
     },
@@ -132,6 +135,7 @@ const triggerUnreadUpdate = debounce(() => {
 // This subscription is used to update the unread indicators count which is not linked to UI and it does not update any UI state.
 Onyx.connectWithoutView({
     key: ONYXKEYS.COLLECTION.REPORT,
+    waitForCollectionCallback: true,
     callback: (value) => {
         allReports = value;
         triggerUnreadUpdate();

src/libs/actions/App.ts

@@ -116,12 +116,14 @@ let allReports: OnyxCollection<OnyxTypes.Report>;
 let allPolicies: OnyxCollection<OnyxTypes.Policy>;
 Onyx.connectWithoutView({
     key: ONYXKEYS.COLLECTION.REPORT,
+    waitForCollectionCallback: true,
     callback: (value) => {
         allReports = value;
     },
 });
 Onyx.connectWithoutView({
     key: ONYXKEYS.COLLECTION.POLICY,
+    waitForCollectionCallback: true,
     callback: (value) => {
         allPolicies = value;
     },

src/libs/actions/ClearReportActionErrors.ts

@@ -19,12 +19,14 @@ type IgnoreDirection = 'parent' | 'child';
 let allReportActions: OnyxCollection<OnyxTypes.ReportActions>;
 Onyx.connectWithoutView({
     key: ONYXKEYS.COLLECTION.REPORT_ACTIONS,
+    waitForCollectionCallback: true,
     callback: (value) => (allReportActions = value),
 });
 
 let allReports: OnyxCollection<OnyxTypes.Report>;
 Onyx.connectWithoutView({
     key: ONYXKEYS.COLLECTION.REPORT,
+    waitForCollectionCallback: true,
     callback: (value) => {
         allReports = value;
     },

src/libs/actions/Export.ts

@@ -60,6 +60,7 @@ function clearStaleExportDownloads() {
     // to the entire collection, which would cause unnecessary re-renders on every change.
     const connectionID = Onyx.connectWithoutView({
         key: ONYXKEYS.COLLECTION.EXPORT_DOWNLOAD,
+        waitForCollectionCallback: true,
         callback: (exportDownloads) => {
             Onyx.disconnect(connectionID);
             if (!exportDownloads) {

src/libs/actions/IOU/index.ts

@@ -18,6 +18,7 @@ Onyx.connect({
 let allTransactions: NonNullable<OnyxCollection<OnyxTypes.Transaction>> = {};
 Onyx.connect({
     key: ONYXKEYS.COLLECTION.TRANSACTION,
+    waitForCollectionCallback: true,
     callback: (value) => {
         if (!value) {
             allTransactions = {};
@@ -31,6 +32,7 @@ Onyx.connect({
 let allTransactionDrafts: NonNullable<OnyxCollection<OnyxTypes.Transaction>> = {};
 Onyx.connect({
     key: ONYXKEYS.COLLECTION.TRANSACTION_DRAFT,
+    waitForCollectionCallback: true,
     callback: (value) => {
         allTransactionDrafts = value ?? {};
     },
@@ -40,6 +42,7 @@ Onyx.connect({
 let allTransactionViolations: NonNullable<OnyxCollection<OnyxTypes.TransactionViolations>> = {};
 Onyx.connect({
     key: ONYXKEYS.COLLECTION.TRANSACTION_VIOLATIONS,
+    waitForCollectionCallback: true,
     callback: (value) => {
         if (!value) {
             allTransactionViolations = {};
@@ -53,6 +56,7 @@ Onyx.connect({
 let allPolicyTags: OnyxCollection<OnyxTypes.PolicyTagLists> = {};
 Onyx.connect({
     key: ONYXKEYS.COLLECTION.POLICY_TAGS,
+    waitForCollectionCallback: true,
     callback: (value) => {
         if (!value) {
             allPolicyTags = {};
@@ -65,6 +69,7 @@ Onyx.connect({
 let allReports: OnyxCollection<OnyxTypes.Report>;
 Onyx.connect({
     key: ONYXKEYS.COLLECTION.REPORT,
+    waitForCollectionCallback: true,
     callback: (value) => {
         allReports = value;
     },
@@ -73,6 +78,7 @@ Onyx.connect({
 let allReportNameValuePairs: OnyxCollection<OnyxTypes.ReportNameValuePairs>;
 Onyx.connect({
     key: ONYXKEYS.COLLECTION.REPORT_NAME_VALUE_PAIRS,
+    waitForCollectionCallback: true,
     callback: (value) => {
         allReportNameValuePairs = value;
     },
@@ -97,6 +103,7 @@ Onyx.connect({
 let allReportActions: OnyxCollection<OnyxTypes.ReportActions>;
 Onyx.connect({
     key: ONYXKEYS.COLLECTION.REPORT_ACTIONS,
+    waitForCollectionCallback: true,
     callback: (actions) => {
         if (!actions) {
             return;

src/libs/actions/OnyxDerived/index.ts

@@ -207,6 +207,7 @@ function init() {
                 if (OnyxKeys.isCollectionKey(dependencyOnyxKey)) {
                     Onyx.connectWithoutView({
                         key: dependencyOnyxKey,
+                        waitForCollectionCallback: true,
                         callback: (value, collectionKey) => {
                             Log.info(`[OnyxDerived] dependency ${collectionKey} for derived key ${key} changed, recomputing`);
                             setDependencyValue(dependencyIndex, value as Parameters<typeof compute>[0][typeof dependencyIndex]);

src/libs/actions/Policy/Member.ts

@@ -75,6 +75,7 @@ function hasPolicyAdminsRoomsAccess(role: string | undefined): boolean {
 let allReportActions: OnyxCollection<ReportActions>;
 Onyx.connect({
     key: ONYXKEYS.COLLECTION.REPORT_ACTIONS,
+    waitForCollectionCallback: true,
     callback: (actions) => (allReportActions = actions),
 });
 

src/libs/actions/Report/DeleteReport.ts

@@ -15,12 +15,14 @@ import Onyx from 'react-native-onyx';
 let allReports: OnyxCollection<Report>;
 Onyx.connectWithoutView({
     key: ONYXKEYS.COLLECTION.REPORT,
+    waitForCollectionCallback: true,
     callback: (value) => (allReports = value),
 });
 
 let allReportActions: OnyxCollection<ReportActions>;
 Onyx.connectWithoutView({
     key: ONYXKEYS.COLLECTION.REPORT_ACTIONS,
+    waitForCollectionCallback: true,
     callback: (value) => (allReportActions = value),
 });
 

src/libs/actions/Report/MarkAllMessageAsRead.tsx

@@ -18,12 +18,14 @@ import Onyx from 'react-native-onyx';
 let allReportActions: OnyxCollection<ReportActions>;
 Onyx.connectWithoutView({
     key: ONYXKEYS.COLLECTION.REPORT_ACTIONS,
+    waitForCollectionCallback: true,
     callback: (value) => (allReportActions = value),
 });
 
 let allReports: OnyxCollection<Report>;
 Onyx.connectWithoutView({
     key: ONYXKEYS.COLLECTION.REPORT,
+    waitForCollectionCallback: true,
     callback: (value) => (allReports = value),
 });