Skip to content

[NoQA] fix: recover stuck isLoadingApp that blocks Inbox and Workspaces#95569

Merged
NicolasBonet merged 6 commits into
Expensify:mainfrom
callstack-internal:fix/stuck-isloadingapp-recovery
Jul 8, 2026
Merged

[NoQA] fix: recover stuck isLoadingApp that blocks Inbox and Workspaces#95569
NicolasBonet merged 6 commits into
Expensify:mainfrom
callstack-internal:fix/stuck-isloadingapp-recovery

Conversation

@BartekObudzinski

@BartekObudzinski BartekObudzinski commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Explanation of Change

IS_LOADING_APP can get permanently stranded at true, which blocks Inbox and Workspaces behind loading skeletons forever while Search keeps working (it is a separate request). Refreshing never heals it; only switching browsers does.

Root cause: openApp() writes IS_LOADING_APP=true optimistically to storage immediately, but the clearing finallyData of WRITE commands is queued in memory (QueuedOnyxUpdates) until the SequentialQueue flushes. If the page reloads or the tab closes in that window, the clearing update is lost while true stays on disk. On the next boot HAS_LOADED_APP=true makes the app run ReconnectApp only (never OpenApp), and ReconnectApp did not touch the flag, so nothing ever clears it. The existing recovery in DelegateAccessHandler only handles isLoadingApp === undefined, not a stuck true.

This was confirmed in production: a user's Onyx state export showed isLoadingApp: true, hasLoadedApp: true, empty request queues and a stale lastFullReconnectTime, while server logs showed two hours of successful partial ReconnectApp calls that could not heal the flag.

Two complementary changes:

  1. getOnyxDataForOpenOrReconnect now clears IS_LOADING_APP in finallyData for every command in the OpenApp/ReconnectApp family, not just OpenApp, so the next successful reconnect self-heals a stranded flag within minutes.
  2. DelegateAccessHandler gets a second recovery effect: if isLoadingApp stays true for 10s while the app is loaded, online, and there is no OpenApp/ReconnectApp pending in the ongoing slot or persisted queue, it re-fires openApp(). The pending-request guard prevents duplicate OpenApp calls during a legitimate in-flight load.

Fixed Issues

$ #95571
PROPOSAL:

Tests

  • Verify that no errors appear in the JS console

Automated unit tests covering this fix pass (101 tests across 7 related suites, including mutation validation that each fix is detected by its test).

Offline tests

N/A

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Same as tests

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@mountiny

mountiny commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

@codex review
@MelvinBot review

@MelvinBot

Copy link
Copy Markdown
Contributor

🤖 Reviewed on request from mountiny. Overall: looks good. The root-cause analysis is sound and the fix is well-targeted and defensively layered. No blocking issues — a few minor observations below.

Summary of the change

  • Durable self-healApp.ts:377-386: the IS_LOADING_APP=false finallyData now applies to the whole OpenApp/ReconnectApp family instead of OpenApp only, so any successful reconnect clears a stranded true.
  • Active recoveryDelegateAccessHandler.tsx:88-111: after 10s of isLoadingApp === true while loaded/online with no reconnect-family request pending, it re-fires openApp().

Why the fix is safe

  • No premature clearing from change 1. OpenApp and ReconnectApp are both WRITE_COMMANDS on the SequentialQueue, so they never run concurrently — a partial ReconnectApp can't clear the flag while a legitimate OpenApp is still in flight (OpenApp's own finallyData runs first). During initial load reconnectApp() also defers to openApp() when hasLoadedApp is falsy, so the flag isn't cleared before the first load completes.
  • Low false-positive risk in change 2. Only openApp() sets isLoadingApp=true optimistically (ReconnectApp doesn't), so normal partial reconnects never schedule the timer. The two recovery effects gate on mutually exclusive states (!== undefined vs !== true), so they can't both fire.
  • Double-guarded against duplicate OpenApp. The pending-request check plus openApp() going through writeWithNoDuplicatesConflictAction means a redundant OpenApp is deduped even if the check races.

Minor observations (non-blocking)

Details
  1. One-shot within a session. The hasHandledStrandedIsLoadingAppRef guard means the active recovery fires at most once per mount. Two sub-cases:

    • If a reconnect-family request is pending at the 10s mark, the timer returns early without setting the ref — but since the effect deps (hasLoadedApp, isLoadingApp, …) don't change, it won't reschedule. If that in-flight request later strands, this session won't retry.
    • If the recovery's own openApp() itself strands (e.g. user goes offline right after), no further retry this session.

    Both are acceptable because change 1 self-heals on the next successful reconnect / boot — just confirming that's the intended fallback and not an oversight.

  2. Log wording nitDelegateAccessHandler.tsx:103 says "stranded true with no pending OpenApp" but the guard also covers ReconnectApp. Trivial.

  3. Component naming — housing an app-wide loading-recovery effect in DelegateAccessHandler is a slight naming mismatch, but it's consistent with the existing "isLoadingApp missing" recovery already living here, so no change needed.

I did not execute the two new suites locally (sandbox restriction); CI will run them. The logic and the mutation-tested coverage described in the PR body line up with the code.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 015364b09e

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread src/DelegateAccessHandler.tsx Outdated
Comment on lines +99 to +100
if (hasPendingReconnectRequest) {
return;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Reschedule the stranded check while a reconnect is pending

When the first 10s timer fires during a slow OpenApp/ReconnectApp, this branch returns and the effect has no dependency change to schedule another timer while isLoadingApp remains true. If that in-flight request later gets removed without applying finallyData (for example after the SequentialQueue retry/give-up or cancellation paths), the flag is still stranded and this recovery never calls openApp() until the component remounts, leaving Inbox/Workspaces blocked in the case this guard is meant to heal.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, the check reschedules itself now while a request is pending. Added a test.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Addresses a production issue where ONYXKEYS.IS_LOADING_APP can remain stranded at true across reloads, leaving Inbox/Workspaces stuck behind skeleton loaders. The PR makes the loading flag self-healing via reconnect-family finallyData, and adds a client-side recovery in DelegateAccessHandler to re-run openApp() when the app is “loaded” but still stuck “loading”.

Changes:

  • Clear IS_LOADING_APP in finallyData for the OpenApp/ReconnectApp Onyx data helper to self-heal stranded persisted state.
  • Add a stranded-isLoadingApp === true recovery effect in DelegateAccessHandler that re-fires openApp() after a delay when no pending reconnect-family request exists.
  • Add unit/UI tests to cover the stranded-state reproduction and the recovery behavior.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File Description
src/libs/actions/App.ts Expands finallyData behavior for OpenApp/ReconnectApp Onyx data to clear stranded IS_LOADING_APP.
src/DelegateAccessHandler.tsx Adds a timer-based recovery that reopens the app if isLoadingApp remains true without pending requests.
tests/actions/IsLoadingAppStrandedTest.ts Adds regression tests reproducing the stranded state and verifying ReconnectApp heals it.
tests/ui/DelegateAccessHandlerTest.tsx Adds UI-level tests ensuring the recovery re-fires openApp() only when appropriate.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/libs/actions/App.ts Outdated
Comment thread src/DelegateAccessHandler.tsx Outdated
Comment thread tests/actions/IsLoadingAppStrandedTest.ts Outdated
@BartekObudzinski
BartekObudzinski marked this pull request as ready for review July 8, 2026 12:44
@BartekObudzinski
BartekObudzinski requested review from a team as code owners July 8, 2026 12:44
@melvin-bot
melvin-bot Bot requested review from heyjennahay and mountiny and removed request for a team July 8, 2026 12:44
@melvin-bot

melvin-bot Bot commented Jul 8, 2026

Copy link
Copy Markdown

@mountiny Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot requested review from a team and NicolasBonet and removed request for a team July 8, 2026 12:44
@melvin-bot

melvin-bot Bot commented Jul 8, 2026

Copy link
Copy Markdown

@NicolasBonet Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 015364b09e

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread src/libs/actions/App.ts Outdated
Comment thread src/DelegateAccessHandler.tsx Outdated
@BartekObudzinski

Copy link
Copy Markdown
Contributor Author

Point 1 handled, the check reschedules while a request is pending. On naming, agreed, keeping it for consistency, can rename in a follow up.

@codecov

codecov Bot commented Jul 8, 2026

Copy link
Copy Markdown

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
src/DelegateAccessHandler.tsx 91.66% <100.00%> (-1.67%) ⬇️
src/hooks/useIsLoadingAppRecovery.ts 100.00% <100.00%> (ø)
src/libs/actions/App.ts 51.09% <100.00%> (+0.54%) ⬆️
... and 24 files with indirect coverage changes

@ZhenjaHorbach

ZhenjaHorbach commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
2026-07-08.15.38.11.mov
Android: mWeb Chrome
2026-07-08.15.31.41.mov
iOS: HybridApp
2026-07-08.15.38.11.mov
iOS: mWeb Safari
2026-07-08.15.31.41.mov
MacOS: Chrome / Safari
2026-07-08.15.29.29.mov
2026-07-08.15.35.17.mov

@ZhenjaHorbach

Copy link
Copy Markdown
Contributor

Changes look good!

Comment thread src/hooks/useIsLoadingAppRecovery.ts Outdated
@NicolasBonet

NicolasBonet commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

@NicolasBonet
NicolasBonet merged commit eb94b3d into Expensify:main Jul 8, 2026
37 checks passed
@OSBotify

OSBotify commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

🚧 NicolasBonet has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

OSBotify commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/NicolasBonet in version: 9.4.32-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor

🤖 Help site review: no docs changes required

I reviewed the changes in this PR against Expensify's help site files under App/docs/articles.

Conclusion: No help site updates are needed.

This is a purely internal bug fix that recovers a stranded IS_LOADING_APP Onyx state flag (which could permanently block the Inbox and Workspaces behind loading skeletons). The two changes — clearing the flag in finallyData for the whole OpenApp/ReconnectApp family, and a new useIsLoadingAppRecovery effect that re-fires openApp() when the flag stays stuck — are behind-the-scenes state-management mechanics. They introduce:

  • No new feature, setting, tab, button, or label
  • No change to any documented user workflow
  • No user-facing copy

The fix simply makes the app self-heal from a stuck loading state that users previously could only escape by switching browsers. Help site articles document features and workflows, not internal loading-state recovery, so there is nothing in App/docs/articles that needs to change. I searched the help articles for loading/skeleton/troubleshooting content and found only incidental, unrelated references (e.g., "loading company cards").

Since no changes are required, I did not create a draft docs PR.

@m-natarajan

Copy link
Copy Markdown

@BartekObudzinski @ZhenjaHorbach NO QA steps, OK to checkoff this one?

@mountiny mountiny changed the title fix: recover stuck isLoadingApp that blocks Inbox and Workspaces [NoQA] fix: recover stuck isLoadingApp that blocks Inbox and Workspaces Jul 9, 2026
@mountiny

mountiny commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

@m-natarajan I think so we dont have reliable repro steps for this

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/grgia in version: 9.4.32-3 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants