[No QA] Automate PR checklist batch 2: callback naming, prop docs, file headers#95545
Closed
kacper-mikolajczak wants to merge 1 commit into
Closed
Conversation
…headers Add reviewer rules CONSISTENCY-12/13/14 and trim the matching author + reviewer checklist items, plus remove reviewer lines now dead-covered by existing rules (CONSISTENCY-9, CLEAN-REACT-5, CLEAN-REACT-8). Issue: Expensify#92599
Contributor
|
I have read the CLA Document and I hereby sign the CLA Kacper Mikołajczak seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. |
Contributor
Author
|
Reopening from the Callstack internal fork ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Phase 2 (batch 2) of automating the deterministic PR-checklist items behind the
code-inline-reviewer, following the merged Phase 1 (#92926). Converts three more checklist items into auto-discovered reviewer rules and trims the checklists accordingly.New reviewer rules (
.claude/skills/coding-standards/rules/, also registered inSKILL.md):CONSISTENCY-12toggleReportnotonIconClick)CONSISTENCY-13/** */block comment (presence check; complementsCONSISTENCY-10which owns style + mixed cases, so no double-flag)/** comment above it */"CONSISTENCY-14Checklist trims
PULL_REQUEST_TEMPLATE.mdandREVIEWER_CHECKLIST.md.CONSISTENCY-9), "only data ... necessary for rendering" (CLEAN-REACT-5), and the three Class Componentthis-binding / render-method items (moot underCLEAN-REACT-8, which bans class components).Trimming
REVIEWER_CHECKLIST.mdshortens it, which re-triggers the exact regression fixed by #94161 (the reviewer-checklist action caps completed items atcount + 2). #94161 must merge before this PR or in-flight reviewer checklists written against the longer template will fail.Fixed Issues
$ #92599
Tests
Deterministic rule/markdown changes; no runtime surface. Verified by inspection that each removed checklist line maps to a rule that enforces it (table above).
QA Steps
[No QA]
PR Author Checklist
### Fixed Issuessection above