Skip to content

[No QA] Update help docs for Release 1: global HR import (Workday, HiBob, BambooHR)#95474

Merged
VictoriaExpensify merged 6 commits into
mainfrom
docs-global-hr-import-release-1
Jul 9, 2026
Merged

[No QA] Update help docs for Release 1: global HR import (Workday, HiBob, BambooHR)#95474
VictoriaExpensify merged 6 commits into
mainfrom
docs-global-hr-import-release-1

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Explanation of Change

Adds help site documentation for Release 1 of the "Add support for global HR import" project, which brings Workday, HiBob, and BambooHR into New Expensify via the merge.dev unified integration layer (Gusto-parity employee sync).

Per the direction on the Resource Updates issue, each provider is documented as a standalone integration with its own help page, rather than a single consolidated article:

  • docs/articles/new-expensify/connections/Connect-Workday-to-Expensify.md
  • docs/articles/new-expensify/connections/Connect-HiBob-to-Expensify.md
  • docs/articles/new-expensify/connections/Connect-BambooHR-to-Expensify.md

Each article is modeled on the existing Connect Gusto to Expensify and TriNet HR-integration articles, and covers who can connect, how to connect (via the HR tab), what happens after connecting, approval mode configuration, manual re-sync, and disconnecting — plus an FAQ. They reflect the Release 1 behavioral differences from Gusto:

  • Connection happens through an embedded connection window (Merge Link), followed by a company selector step.
  • Manual re-sync and disconnect are surfaced via the three dots (⋮) menu (Sync now / Disconnect).
  • Manual syncs are limited to twice per day, after which the next sync runs the following day.

Articles follow docs/HELP_AUTHORING_GUIDELINES.md, docs/HELPSITE_NAMING_CONVENTIONS.md, and docs/TEMPLATE.md. They are auto-discovered by the Connections hub (like the existing Gusto/TriNet articles), so no _routes.yml change is required.

Note for reviewers: these describe upcoming Release 1 UI. Exact labels (card names, button text, the company selector, and the three-dots menu items) should be confirmed against the built feature before merging alongside the release.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/630908

PROPOSAL:

Tests

// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validate your change worked.

  • Verify that no errors appear in the JS console

Offline tests

N/A — documentation-only change.

QA Steps

// TODO: The human co-author must fill out the QA tests (or mark the PR title with "[No QA]") before marking this PR as "ready for review".

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above

Screenshots/Videos

Documentation-only change; no app UI changes.

Co-authored-by: Stephanie Elliott <stephanieelliott@users.noreply.github.com>
@MelvinBot
MelvinBot requested a review from a team July 7, 2026 07:35
@github-actions github-actions Bot changed the title Update help docs for Release 1: global HR import (Workday, HiBob, BambooHR) [No QA] Update help docs for Release 1: global HR import (Workday, HiBob, BambooHR) Jul 7, 2026
@OSBotify

This comment has been minimized.

@OSBotify

This comment has been minimized.

@OSBotify

This comment has been minimized.

@stephanieelliott
stephanieelliott marked this pull request as ready for review July 8, 2026 20:13
@stephanieelliott
stephanieelliott self-requested a review as a code owner July 8, 2026 20:13
@OSBotify

This comment has been minimized.

@OSBotify

This comment has been minimized.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3c2dd13122

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

5. In the connection window that opens, sign in with your Workday administrator account and authorize Expensify to access your Workday account.
6. Wait for the initial connection to complete.
7. After the connection is established, Workday displays a green status indicator.
8. Click the green status indicator, then click **Complete setup**.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Point setup to the actual Complete setup action

In the Merge HR post-connect setup state, the app does not render a green status indicator: HRProviderCard shows the Connected. Complete setup... link in the card description and a Complete setup item in the three-dots menu while card.completeSetupRoute is set (src/pages/workspace/hr/HRProviderCard.tsx:99-103, 188-192). These Workday/BambooHR/HiBob instructions therefore send admins looking for a control that doesn't exist, which can make them miss the required group-selection step after Merge Link returns.

Useful? React with 👍 / 👎.

1. In the navigation tabs (on the left on web, on the bottom on mobile), select **Workspaces**.
2. Click the name of the workspace connected to Workday.
3. In the left menu, click **HR**.
4. Click **Workday**.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Remove the dead provider-click step

After reaching the HR page, the provider card itself is rendered with interactive={false} and the three-dots menu is already the right-side control on that same row (src/pages/workspace/hr/HRProviderCard.tsx:167-199); there is no Workday/BambooHR/HiBob detail page to open before choosing Sync now or Disconnect. In the connected-provider scenario these steps will stall users at a click that does nothing before they can access the menu.

Useful? React with 👍 / 👎.

Co-authored-by: Stephanie Elliott <stephanieelliott@users.noreply.github.com>
@MelvinBot

Copy link
Copy Markdown
Contributor Author

🤖 Fixed the failing spellcheck check and pushed to this branch.

Cause: A typo — Workdayb — in Connect-Workday-to-Expensify.md:121. cspell flagged it as an unknown word.

Fix: Corrected it to Workday. This was the only spellcheck issue across the three changed docs (the other two files passed).

@MelvinBot

Copy link
Copy Markdown
Contributor Author

🤖 The spellcheck failure is already fixed. My earlier commit corrected the typo WorkdaybWorkday in Connect-Workday-to-Expensify.md:121, and spellcheck now passes.

No checks are currently failing — build is still pending (running), and everything else is passing or skipping.

@OSBotify

OSBotify commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment
This PR adds three new HR-integration articles for Release 1 of the global HR import project: Connect-Workday-to-Expensify.md, Connect-HiBob-to-Expensify.md, and Connect-BambooHR-to-Expensify.md. All three are near-identical in structure, modeled on the existing Gusto/TriNet articles. The docs are well-organized, follow the single-workflow-per-article principle, and are largely compliant with the governance files. A few consistency and content issues should be fixed before merge.

Scores Summary

  • Readability: 9/10 - Clear, scannable, action-oriented steps; strong numbered procedures and short bulleted outcomes. One content typo (Workdayb) and a few trailing-whitespace lines detract slightly.
  • AI Readiness: 9/10 - Complete YAML frontmatter including internalScope, task-based H2 headings, correct hierarchy (single H1 title plus FAQ, no H3), full feature names in headings, and realistic keyword phrasing.
  • Style Compliance: 7/10 - Navigation phrasing, three-dots (vertical ellipsis) formatting, and button/tab bolding all follow HELPSITE_NAMING_CONVENTIONS.md. Deduction for inconsistent approval-mode label casing and unconfirmed UI labels (flagged by the author).

Key Findings

  • Positive: Correct unified navigation phrasing 'In the navigation tabs (on the left on web, on the bottom on mobile).'
  • Positive: Three-dots menu correctly written per the Three Dots Menu Rule.
  • Positive: Frontmatter is complete; internalScope states audience, coverage, and exclusions in all three files.
  • Positive: Headings are task-based (Who/How/What) with clean hierarchy (only H1 and H2, plus exempt FAQ).
  • Issue (content): Connect-Workday-to-Expensify.md has a typo -- 'Disconnecting Workdayb stops future employee syncs'.
  • Issue (style/consistency): Approval modes appear as 'Basic Approval'/'Manager Approval'/'Custom Approval' in one section but 'Basic approval'/'Manager approval'/'Custom approval' in another within the same file. The Deterministic Writing Rule requires exact, consistent UI casing.
  • Issue (risk): The author notes exact labels (card names, button text, company selector, three-dots menu items) are not yet confirmed against the built feature, so exact-UI-terminology compliance cannot be fully verified.
  • Minor: Trailing-whitespace-only lines appear before some separators.

Recommendations

  • Fix the Workdayb typo in the Workday article.
  • Standardize approval-mode label capitalization to match the actual UI exactly and use it consistently throughout each file.
  • Confirm all UI labels against the built Release 1 feature before merging, as the author flagged.
  • Remove trailing-whitespace-only lines for cleanliness.

Files Reviewed

  • Connect-Workday-to-Expensify.md - Compliant; fix Workdayb typo and approval-mode casing.
  • Connect-HiBob-to-Expensify.md - Compliant; fix approval-mode casing consistency.
  • Connect-BambooHR-to-Expensify.md - Compliant; fix approval-mode casing consistency.

Note: Detailed line-by-line feedback has been provided as inline comments.

@VictoriaExpensify
VictoriaExpensify merged commit cb29792 into main Jul 9, 2026
16 checks passed
@VictoriaExpensify
VictoriaExpensify deleted the docs-global-hr-import-release-1 branch July 9, 2026 02:32
@OSBotify

OSBotify commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/VictoriaExpensify in version: 9.4.32-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/grgia in version: 9.4.32-3 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants