[No QA] Update help docs for Release 1: global HR import (Workday, HiBob, BambooHR)#95474
Conversation
Co-authored-by: Stephanie Elliott <stephanieelliott@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3c2dd13122
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| 5. In the connection window that opens, sign in with your Workday administrator account and authorize Expensify to access your Workday account. | ||
| 6. Wait for the initial connection to complete. | ||
| 7. After the connection is established, Workday displays a green status indicator. | ||
| 8. Click the green status indicator, then click **Complete setup**. |
There was a problem hiding this comment.
Point setup to the actual Complete setup action
In the Merge HR post-connect setup state, the app does not render a green status indicator: HRProviderCard shows the Connected. Complete setup... link in the card description and a Complete setup item in the three-dots menu while card.completeSetupRoute is set (src/pages/workspace/hr/HRProviderCard.tsx:99-103, 188-192). These Workday/BambooHR/HiBob instructions therefore send admins looking for a control that doesn't exist, which can make them miss the required group-selection step after Merge Link returns.
Useful? React with 👍 / 👎.
| 1. In the navigation tabs (on the left on web, on the bottom on mobile), select **Workspaces**. | ||
| 2. Click the name of the workspace connected to Workday. | ||
| 3. In the left menu, click **HR**. | ||
| 4. Click **Workday**. |
There was a problem hiding this comment.
Remove the dead provider-click step
After reaching the HR page, the provider card itself is rendered with interactive={false} and the three-dots menu is already the right-side control on that same row (src/pages/workspace/hr/HRProviderCard.tsx:167-199); there is no Workday/BambooHR/HiBob detail page to open before choosing Sync now or Disconnect. In the connected-provider scenario these steps will stall users at a click that does nothing before they can access the menu.
Useful? React with 👍 / 👎.
Co-authored-by: Stephanie Elliott <stephanieelliott@users.noreply.github.com>
|
🤖 Fixed the failing Cause: A typo — Fix: Corrected it to |
|
🤖 The No checks are currently failing — |
|
A preview of your ExpensifyHelp changes have been deployed to https://1e2b6417.helpdot.pages.dev ⚡️ Updated articles: |
|
HelpDot Documentation Review Overall Assessment Scores Summary
Key Findings
Recommendations
Files Reviewed
Note: Detailed line-by-line feedback has been provided as inline comments. |
|
🚀 Deployed to staging by https://github.com/VictoriaExpensify in version: 9.4.32-0 🚀
|
|
🚀 Deployed to production by https://github.com/grgia in version: 9.4.32-3 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Adds help site documentation for Release 1 of the "Add support for global HR import" project, which brings Workday, HiBob, and BambooHR into New Expensify via the merge.dev unified integration layer (Gusto-parity employee sync).
Per the direction on the Resource Updates issue, each provider is documented as a standalone integration with its own help page, rather than a single consolidated article:
docs/articles/new-expensify/connections/Connect-Workday-to-Expensify.mddocs/articles/new-expensify/connections/Connect-HiBob-to-Expensify.mddocs/articles/new-expensify/connections/Connect-BambooHR-to-Expensify.mdEach article is modeled on the existing Connect Gusto to Expensify and TriNet HR-integration articles, and covers who can connect, how to connect (via the HR tab), what happens after connecting, approval mode configuration, manual re-sync, and disconnecting — plus an FAQ. They reflect the Release 1 behavioral differences from Gusto:
Articles follow
docs/HELP_AUTHORING_GUIDELINES.md,docs/HELPSITE_NAMING_CONVENTIONS.md, anddocs/TEMPLATE.md. They are auto-discovered by the Connections hub (like the existing Gusto/TriNet articles), so no_routes.ymlchange is required.Fixed Issues
$ https://github.com/Expensify/Expensify/issues/630908
PROPOSAL:
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validate your change worked.
Offline tests
N/A — documentation-only change.
QA Steps
// TODO: The human co-author must fill out the QA tests (or mark the PR title with "[No QA]") before marking this PR as "ready for review".
PR Author Checklist
### Fixed Issuessection aboveScreenshots/Videos
Documentation-only change; no app UI changes.