Refactor getSubmitToEmail and getSubmitToAccountID by bernhardoj · Pull Request #95458 · Expensify/App

bernhardoj · 2026-07-07T03:57:15Z

Explanation of Change

Fixed Issues

$ #66391
PROPOSAL:

Tests

Same as QA Steps

Verify that no errors appear in the JS console

Offline tests

Same as QA Steps

QA Steps

Prerequisite:

Have a submit workspace beta
Create a new account
On onboarding steps > Choose "Submit Expense to my employeer" > Complete onboarding
Create an expense to your workspace you've created in onboarding

Notice when submitting expense a popup will be opened for you to select mananger email.

Open the workspace chat
Press the Submit button on the report preview. A popup to select a manager will appear
Verify the report manager is selected

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

…-useonyx-13

melvin-bot · 2026-07-07T03:57:21Z

@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

codecov · 2026-07-07T04:02:36Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/hooks/useReportSubmitToPopover.tsx	`70.73% <100.00%> (+0.36%)`	⬆️
src/libs/PolicyUtils.ts	`77.10% <100.00%> (-0.16%)`	⬇️
src/pages/ReportSubmitToContent.tsx	`0.00% <0.00%> (ø)`
... and 80 files with indirect coverage changes

shubham1206agra · 2026-07-07T18:00:51Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

shubham1206agra · 2026-07-07T18:02:28Z

+ */
+function getSubmitToAccountID(policy: OnyxEntry<Policy>, expenseReport: OnyxEntry<Report>, ownerLogin: string | undefined): number {
+    const submitToEmail = getSubmitToEmail(policy, expenseReport, ownerLogin);
+    return submitToEmail ? (getAccountIDsByLogins([submitToEmail]).at(0) ?? -1) : -1;


@bernhardoj NAB: Please refrain from using -1 here. Use CONST.DEFAULT_NUMBER_ID here

shubham1206agra

One Nit comment to address.

…-useonyx-13

OSBotify · 2026-07-08T15:42:17Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-07-08T16:33:51Z

🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-07-08T16:44:07Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #95458.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-f36b4c5a1cf-ee2dd9f-fe62a3b0bdfcf3a4f1694d87ced58ce9237f78b8/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-f36b4c5-ee2dd9f-f3d05acb0f666b450fc30a1f5f64d1d3a6dbd5dd/index.html

Web 🕸️
https://95458.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-07-09T11:06:50Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.4.32-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MelvinBot · 2026-07-09T11:08:36Z

🤖 I reviewed the changes in this PR against the help site content under App/docs/articles.

No help site changes are required.

This PR is a pure internal refactor (part of deprecating Onyx.connect() — linked issue #66391). It:

Splits/refactors getSubmitToEmail and getSubmitToAccountID in PolicyUtils.ts so the report owner's login is passed in as a parameter instead of being resolved via an Onyx.connect()-backed lookup.
Updates the two callers (useReportSubmitToPopover, ReportSubmitToContent) to source that login from useOnyx.
Updates a unit test call signature.

There is no change to user-facing behavior, UI labels, feature names, settings, or workflows — the submit-to recipient resolution logic is functionally unchanged. Since the help articles document user-facing product behavior, there's nothing to update, so I did not create a draft docs PR.

@bernhardoj, please confirm you agree no help site changes are needed here. If you think a doc update is warranted, let me know and I'll open a draft PR.

OSBotify · 2026-07-10T13:43:53Z

🚀 Deployed to production by https://github.com/grgia in version: 9.4.32-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android

bernhardoj added 3 commits July 6, 2026 13:39

refactor getSubmitToEmail and getSubmitToAccountID

d2faade

fix test

a66d67c

Merge branch 'main' into chore/66391-refactor-personal-details-to-use…

76bc642

…-useonyx-13

bernhardoj requested review from a team as code owners July 7, 2026 03:57

melvin-bot Bot assigned bernhardoj Jul 7, 2026

melvin-bot Bot requested review from shubham1206agra and removed request for a team July 7, 2026 03:57

melvin-bot Bot requested review from joekaufmanexpensify and removed request for a team July 7, 2026 03:57

remove unused import

92649a3

shubham1206agra reviewed Jul 7, 2026

View reviewed changes

shubham1206agra approved these changes Jul 7, 2026

View reviewed changes

melvin-bot Bot requested a review from mountiny July 7, 2026 18:03

bernhardoj added 2 commits July 8, 2026 13:16

use default number id fallback

a14177b

Merge branch 'main' into chore/66391-refactor-personal-details-to-use…

6c22ae4

…-useonyx-13

mountiny approved these changes Jul 8, 2026

View reviewed changes

mountiny merged commit f36b4c5 into Expensify:main Jul 8, 2026
34 checks passed

OSBotify mentioned this pull request Jul 9, 2026

Deploy Checklist: New Expensify 2026-07-09 #95677

Closed

94 tasks

melvin-bot Bot mentioned this pull request Jul 10, 2026

[Due for payment 2026-07-29] Remove Onyx.connect() for the key: ONYXKEYS.PERSONAL_DETAILS_LIST in src/libs/PersonalDetailsUtils.ts #66391

Open

Uh oh!

Conversation

bernhardoj commented Jul 7, 2026

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Jul 7, 2026

Uh oh!

codecov Bot commented Jul 7, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

shubham1206agra commented Jul 7, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

shubham1206agra Jul 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bernhardoj Jul 8, 2026

Choose a reason for hiding this comment

Uh oh!

shubham1206agra left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Jul 8, 2026

Uh oh!

github-actions Bot commented Jul 8, 2026

Uh oh!

github-actions Bot commented Jul 8, 2026

Uh oh!

OSBotify commented Jul 9, 2026

Uh oh!

MelvinBot commented Jul 9, 2026

Uh oh!

OSBotify commented Jul 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

codecov Bot commented Jul 7, 2026 •

edited by github-actions Bot

Loading

shubham1206agra Jul 7, 2026 •

edited

Loading