fix known DMs missing in recent chats on fresh sign-in by apeyada · Pull Request #95454 · Expensify/App

apeyada · 2026-07-07T03:09:40Z

Explanation of Change

Fixed Issues

$ #94800
PROPOSAL: #94800 (comment)

Precondition

Account has several 1:1 DMs in its recent chats
Clear cache and restart so the DM reports aren't cached yet

Tests

Open the Search router
In the search input, type part of the name of a contact you have a 1:1 DM with (e.g. "jason").
Verify that the matching DM appears under the "Recent chats" section right away
Watch the results as the server response comes back (wait ~2–3 seconds)
Verify that DM stays in "Recent chats" and keeps its position — it does not disappear, and it does not jump down into the "Search results" section
Verify that any additional chats the server returns show up under "Search results" below, without displacing the already-shown recent chats

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Same as Tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

after.fix.mov

apeyada · 2026-07-07T03:10:27Z

@codex review

chatgpt-codex-connector · 2026-07-07T03:15:12Z

Codex Review: Didn't find any major issues. Delightful!

Reviewed commit: 64930a70c2

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

codecov · 2026-07-07T03:16:05Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/components/Search/SearchAutocompleteList.tsx	`93.06% <100.00%> (+0.21%)`	⬆️
... and 78 files with indirect coverage changes

melvin-bot · 2026-07-07T07:29:20Z

@mkhutornyi Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 432e6c24b5

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

trjExpensify

Commented here in the thread for this, just to make sure @carlosmiceli has eyes on it as he's doing some refactoring to SearchForReports.

mkhutornyi · 2026-07-07T14:39:48Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

android.mov

Android: mWeb Chrome

iOS: HybridApp

ios.mov

iOS: mWeb Safari

MacOS: Chrome / Safari

web.mov

mkhutornyi · 2026-07-07T15:29:37Z

Based on thread, frontend patch is fine for now.

neil-marcellini

Looks great, thank you.

neil-marcellini · 2026-07-07T18:47:34Z

+            <OnyxListItemProvider>
+                <LocaleContextProvider>
+                    <SearchAutocompleteList
+                        autocompleteQueryValue="te"


NAB: Why is this the user's query? Shouldn't it be something more like Al for Alice?

OSBotify · 2026-07-07T19:03:27Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-07-07T19:17:54Z

🚧 neil-marcellini has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-07-07T19:22:19Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #95454.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-b703dfd58f0-c9ce36c-4ad48d017eb740b24a2e055becb79e41f5cf4593/index.html	❌ FAILED ❌
	The QR code can't be generated, because the iOS build failed

Web 🕸️
https://95454.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-07-09T11:06:47Z

🚀 Deployed to staging by https://github.com/neil-marcellini in version: 9.4.32-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MelvinBot · 2026-07-09T11:08:36Z

🤖 Help site review: no changes required

I reviewed the changes in this PR and no updates to the help site files under App/docs/articles are needed.

Why: This PR is an internal bug fix to the ordering logic of the Search autocomplete list (SearchAutocompleteList.tsx). It changes how a known 1:1 DM is keyed so it stays in the Recent chats section (instead of jumping to Search results) after its report loads from the server on a fresh sign‑in. There are no new or renamed features, tabs, settings, labels, or buttons — the user-facing feature behaves as already expected; it just fixes a transient flicker/reorder.

I also searched App/docs/articles and found no article that documents the Search router's "Recent chats" vs "Search results" section ordering, so there is nothing to update.

No draft docs PR was created since no documentation changes are warranted.

@apeyada, please confirm you agree no help site update is needed. If you believe a docs change is warranted, let me know what behavior should be documented and I'll draft it.

OSBotify · 2026-07-10T13:43:50Z

🚀 Deployed to production by https://github.com/grgia in version: 9.4.32-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android

apeyada and others added 2 commits July 5, 2026 17:22

fix known DMs missing in recent chats on fresh sign-in

f39d62f

Merge branch 'Expensify:main' into fix-94800

64930a7

melvin-bot Bot assigned apeyada Jul 7, 2026

add unit test

432e6c2

apeyada marked this pull request as ready for review July 7, 2026 07:29

apeyada requested review from a team as code owners July 7, 2026 07:29

melvin-bot Bot requested review from mkhutornyi and trjExpensify and removed request for a team July 7, 2026 07:29

melvin-bot Bot removed the request for review from a team July 7, 2026 07:29

chatgpt-codex-connector Bot reviewed Jul 7, 2026

View reviewed changes

Comment thread src/components/Search/SearchAutocompleteList.tsx Outdated

trjExpensify reviewed Jul 7, 2026

View reviewed changes

address codex review

3e0ecb5

mkhutornyi approved these changes Jul 7, 2026

View reviewed changes

melvin-bot Bot requested a review from neil-marcellini July 7, 2026 15:30

neil-marcellini approved these changes Jul 7, 2026

View reviewed changes

neil-marcellini merged commit b703dfd into Expensify:main Jul 7, 2026
36 checks passed

OSBotify mentioned this pull request Jul 9, 2026

Deploy Checklist: New Expensify 2026-07-09 #95677

Closed

94 tasks

aswin-s mentioned this pull request Jul 9, 2026

[$250] Search - list does not split into "Recent chats" and "Search results" sections. #95710

Open

7 tasks

melvin-bot Bot mentioned this pull request Jul 10, 2026

[Due for payment 2026-07-17] [$250] Recent chats on fresh sign-in: known DMs missing while old/never-contacted chats appear #94800

Closed

Uh oh!

Conversation

apeyada commented Jul 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Precondition

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

apeyada commented Jul 7, 2026

Uh oh!

chatgpt-codex-connector Bot commented Jul 7, 2026

Uh oh!

codecov Bot commented Jul 7, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot Bot commented Jul 7, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

trjExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

mkhutornyi commented Jul 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

mkhutornyi commented Jul 7, 2026

Uh oh!

neil-marcellini left a comment

Choose a reason for hiding this comment

Uh oh!

neil-marcellini Jul 7, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Jul 7, 2026

Uh oh!

github-actions Bot commented Jul 7, 2026

Uh oh!

github-actions Bot commented Jul 7, 2026

Uh oh!

OSBotify commented Jul 9, 2026

Uh oh!

MelvinBot commented Jul 9, 2026

Uh oh!

OSBotify commented Jul 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

apeyada commented Jul 7, 2026 •

edited

Loading

codecov Bot commented Jul 7, 2026 •

edited by github-actions Bot

Loading

mkhutornyi commented Jul 7, 2026 •

edited

Loading