Skip to content

[No QA] Docs updates for E/A#95316 Note Device management list sort order#95411

Merged
arosiclair merged 1 commit into
mainfrom
claude-docsDeviceManagementSortOrder
Jul 9, 2026
Merged

[No QA] Docs updates for E/A#95316 Note Device management list sort order#95411
arosiclair merged 1 commit into
mainfrom
claude-docsDeviceManagementSortOrder

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Explanation of Change

Follow-up help site update for #95316, which sorts the Device management list so the most recently used or added device appears first.

The article Manage-Logged-in-Devices.md described the device list but did not mention its ordering. This adds one sentence noting that the list is ordered by most recent activity, matching the new behavior. No other help site articles reference the device list order.

Fixed Issues

$ #95307

Tests

// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.

QA

// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.


@cretadn22, please review the files changed and confirm they reflect the current behavior. Then mark this PR Ready for review.

Co-authored-by: cretadn22 <cretadn22@users.noreply.github.com>
@MelvinBot
MelvinBot requested a review from a team July 6, 2026 15:52
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Jul 6, 2026
@github-actions github-actions Bot changed the title Docs updates for E/A#95316 Note Device management list sort order [No QA] Docs updates for E/A#95316 Note Device management list sort order Jul 6, 2026
@OSBotify

OSBotify commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

A preview of your ExpensifyHelp changes have been deployed to https://8ec935ec.helpdot.pages.dev ⚡️

Updated articles:

@cretadn22

Copy link
Copy Markdown
Contributor

@MelvinBot Ready for review

@MelvinBot
MelvinBot marked this pull request as ready for review July 8, 2026 13:40
@melvin-bot

melvin-bot Bot commented Jul 8, 2026

Copy link
Copy Markdown

Concierge reviewer checklist:

  • I have verified the accuracy of the article
    • The article is within a hub that makes sense, and the navigation is correct
    • All processes, screenshots, and examples align with current product behavior.
    • All links within the doc have been verified for correct destination and functionality.
  • I have verified the readability of the article
    • The article's language is clear, concise, and free of jargon.
    • The grammar, spelling, and punctuation are correct.
    • The article contains at least one image, or that an image is not necessary
  • I have verified the formatting of the article
    • The article has consistent formatting (headings, bullet points, etc.) with other HelpDot articles and that aligns with the HelpDot formatting standards.
    • The article has proper text spacing and breaks for readability.
  • I have verified the article has the appropriate tone and style
    • The article's tone is professional, friendly, and suitable for the target audience.
    • The article's tone, terminology, and voice are consistent throughout.
  • I have verified the overall quality of the article
    • The article is not missing any information, nor does it contain redundant information.
    • The article fully addresses user needs.
  • I have verified that all requested improvements have been addressed

For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member?

cc @lydiabarclay

@melvin-bot
melvin-bot Bot requested review from cretadn22 and lydiabarclay July 8, 2026 13:40
@MelvinBot

Copy link
Copy Markdown
Contributor Author

🤖 Done — this PR is now marked Ready for review.

One note: the Tests and QA sections in the PR body still contain the // TODO placeholders. Since this is a docs-only, [No QA] change that only adds one sentence to the help article, that's likely fine, but please fill in (or confirm) those sections if a reviewer requires it.

@melvin-bot
melvin-bot Bot removed the request for review from a team July 8, 2026 13:40
@melvin-bot

melvin-bot Bot commented Jul 8, 2026

Copy link
Copy Markdown

@cretadn22 @lydiabarclay One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@cretadn22

cretadn22 commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Android: mWeb Chrome
iOS: HybridApp
iOS: mWeb Safari
MacOS: Chrome / Safari

@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR makes a minimal, well-scoped follow-up documentation change to Manage-Logged-in-Devices.md, adding a single explanatory sentence noting that the Device management list is ordered by most recent activity. This aligns the article with the new sort behavior introduced in #95316. The change is surgical and does not alter structure, headings, or metadata.

Scores Summary

  • Readability: 9/10 - The added sentence is clear, concise, and scannable. It plainly states the ordering behavior and the user-facing outcome (most recent device appears at the top).
  • AI Readiness: 9/10 - The sentence reinforces the existing task-based section and uses realistic phrasing ("ordered by most recent activity"). It sits under a compliant "How to view and revoke logged-in devices in Device management" heading and introduces no new headings or hierarchy issues.
  • Style Compliance: 9/10 - Uses the exact UI feature name ("Device management") consistent with the rest of the article. No prohibited or vague navigation language. No terminology or casing violations introduced by the diff.

Key Findings

  • The change is correctly limited to a single explanatory sentence, avoiding scope creep, consistent with the one-workflow-per-article principle.
  • Placement is logical: it follows the existing paragraph describing what each listed device represents, keeping related context grouped without interrupting the numbered steps.
  • No new headings, metadata, or cross-links were added, so no structural governance rules are triggered.
  • Minor: the sentence is a standalone paragraph rather than folded into the preceding paragraph about the device list. Either is acceptable; grouping could marginally tighten flow but is not required.

Recommendations

  • No changes required. The addition is compliant with the naming conventions, authoring guidelines, and template.
  • Optional: consider merging the new sentence with the preceding paragraph ("Each listed device represents an active login session...") since both describe list contents and behavior.

Files Reviewed

  • docs/articles/new-expensify/settings/Manage-Logged-in-Devices.md - Compliant. One sentence added; clear, accurate, and consistent with existing UI terminology.

Note: This is a top-level summary review of the proposed diff only.

@melvin-bot
melvin-bot Bot requested a review from arosiclair July 9, 2026 11:58
@arosiclair
arosiclair merged commit a2304e2 into main Jul 9, 2026
22 checks passed
@arosiclair
arosiclair deleted the claude-docsDeviceManagementSortOrder branch July 9, 2026 13:19
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/arosiclair in version: 9.4.33-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 cancelled 🔪

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/lakchote in version: 9.4.33-8 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants