Skip to content

Fix: restore Wallet background for missing personal details RHP after reload #95363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chuckdries merged 1 commit into from
Jul 7, 2026
Merged

Fix: restore Wallet background for missing personal details RHP after reload #95363

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/libs/Navigation/linkingConfig/RELATIONS/SETTINGS_TO_RHP.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,8 @@ const SETTINGS_TO_RHP: Partial<Record<keyof SettingsSplitNavigatorParamList, str
SCREENS.SETTINGS.WALLET.PERSONAL_CARD_UPGRADE,
SCREENS.SETTINGS.WALLET.CARD_CHANGE_PIN,
SCREENS.SETTINGS.WALLET.CARD_CHANGE_PIN_ATM,
SCREENS.MISSING_PERSONAL_DETAILS,
SCREENS.MISSING_PERSONAL_DETAILS_CONFIRM_MAGIC_CODE,
Comment on lines +71 to +72

@chatgpt-codex-connector chatgpt-codex-connector Bot Jul 6, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep home-launched details flows on Home after reload

When the missing-personal-details RHP is opened from the Home time-sensitive card or issue card (AddVirtualCardPersonalDetails.tsx:31, IssueCardMessage.tsx:63), the URL still has no backTo parameter, so after a browser reload getMatchingFullScreenRoute() will now hit this new RHP_TO_SETTINGS entry and rebuild Settings > Wallet behind the RHP instead of preserving Home. This fixes the Wallet entry point but regresses the existing Home-launched flow; the mapping needs a way to distinguish Wallet launches from Home/default launches rather than assigning this screen globally to Wallet.

Useful? React with 👍 / 👎.

@DylanDylann DylanDylann Jul 7, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Expected

],
[SCREENS.SETTINGS.AGENTS.ROOT]: [
SCREENS.SETTINGS.AGENTS.ADD,
Expand Down
Loading