Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
d8f4234
Migrate report field list values RHP to compact Table styles
Krishna2323 Jul 3, 2026
ae50639
Migrate workspace tag list view RHP to compact Table styles
Krishna2323 Jul 3, 2026
5bfcd82
Migrate room members RHP to compact Table styles
Krishna2323 Jul 3, 2026
8586646
Align ReportParticipantsTable search bar with compact RHP styles
Krishna2323 Jul 3, 2026
72cbc2b
Address RHP table migration review gaps
Krishna2323 Jul 3, 2026
31d2167
Remove dead code after RHP table migrations
Krishna2323 Jul 3, 2026
d5a2467
Fix mobile selection mode and stable list value keys
Krishna2323 Jul 4, 2026
9cb2cb9
Fix room members table infinite render loop
Krishna2323 Jul 4, 2026
193754e
Align RHP table page spacing with tags settings
Krishna2323 Jul 4, 2026
1831eea
Align group members page button-to-table spacing
Krishna2323 Jul 4, 2026
d69bf3f
Use shared Table components for room members search and empty state
Krishna2323 Jul 4, 2026
e309b0b
Merge branch 'main' into krishna2323-update-rhp-table-styles-94847
Krishna2323 Jul 6, 2026
f6586b4
Call onSearchStringChange from updateSearchString instead of useEffect
Krishna2323 Jul 6, 2026
9c640df
fix oxfmt check.
Krishna2323 Jul 6, 2026
11d0385
Merge remote-tracking branch 'upstream/main' into krishna2323-update-…
Krishna2323 Jul 6, 2026
719780e
Merge branch 'main' into krishna2323-update-rhp-table-styles-94847
Krishna2323 Jul 6, 2026
08acc1c
Remove accidentally committed domain members mock seed file
Krishna2323 Jul 6, 2026
ee567f6
remove redundant file.
Krishna2323 Jul 6, 2026
3ea9305
Merge branch 'main' into krishna2323-update-rhp-table-styles-94847
Krishna2323 Jul 9, 2026
6be701c
Fix room members invite search handoff regression.
Krishna2323 Jul 9, 2026
7b5e802
Remove unused OptionsListUtils exports after table migration.
Krishna2323 Jul 9, 2026
c8f3013
Address PR review feedback for table search persistence.
Krishna2323 Jul 10, 2026
dda3823
Merge branch 'Expensify:main' into krishna2323-update-rhp-table-style…
Krishna2323 Jul 11, 2026
327f6b8
merge main and resolve conflicts.
Krishna2323 Jul 14, 2026
08db013
Remove unused isSearchStringMatchUserDetails after RHP table migration.
Krishna2323 Jul 14, 2026
5c87435
Remove redundant table search clear when room members list is empty.
Krishna2323 Jul 14, 2026
d3c5da9
Use Table.EmptyState and NoResultsState for report field list values.
Krishna2323 Jul 14, 2026
88abdda
Merge branch 'Expensify:main' into krishna2323-update-rhp-table-style…
Krishna2323 Jul 14, 2026
055e7b6
Merge branch 'Expensify:main' into krishna2323-update-rhp-table-style…
Krishna2323 Jul 14, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/CONST/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8359,6 +8359,8 @@ const CONST = {
MONEY_REQUEST_REPORT_ACTIONS_LIST_SELECT_ALL: 'MoneyRequestReportActionsList-SelectAll',
MONEY_REQUEST_REPORT_TRANSACTION_ITEM: 'MoneyRequestReportTransactionItem',
REPORT_ACTION_AVATAR: 'Report-ReportActionAvatar',
PARTICIPANTS_ROW: 'Report-ParticipantsRow',
ROOM_MEMBERS_ROW: 'Report-RoomMembersRow',
},
SIDEBAR: {
SIGN_IN_BUTTON: 'Sidebar-SignInButton',
Expand Down Expand Up @@ -8709,6 +8711,9 @@ const CONST = {
MORE_DROPDOWN: 'WorkspaceTags-MoreDropdown',
BULK_ACTIONS_DROPDOWN: 'WorkspaceTags-BulkActionsDropdown',
},
REPORT_FIELDS: {
LIST_VALUE_ROW: 'WorkspaceReportFields-ListValueRow',
},
TAXES: {
ROW: 'WorkspaceTaxes-Row',
ADD_BUTTON: 'WorkspaceTaxes-AddButton',
Expand Down
65 changes: 0 additions & 65 deletions src/components/SelectionListWithModal/CustomListHeader.tsx

This file was deleted.

This file was deleted.

128 changes: 0 additions & 128 deletions src/components/SelectionListWithModal/index.tsx

This file was deleted.

2 changes: 2 additions & 0 deletions src/components/Table/Table.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,7 @@ function Table<DataType extends TableData, ColumnKey extends string = string, Fi
selectionEnabled,
shouldEnableSelectionInNarrowPaneModal,
onRowSelectionChange,
onSearchStringChange,
...listProps
}: TableProps<DataType, ColumnKey, FilterKey>) {
const {translate} = useLocalize();
Expand Down Expand Up @@ -264,6 +265,7 @@ function Table<DataType extends TableData, ColumnKey extends string = string, Fi
selectionEnabled,
shouldEnableSelectionInNarrowPaneModal,
isMobileSelectionEnabled,
onSearchStringChange,
};

return (
Expand Down
3 changes: 3 additions & 0 deletions src/components/Table/TableContext.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,9 @@ type TableContextValue<DataType extends TableData, ColumnKey extends string = st

/** Whether to use a narrow layout (e.g. on mobile screens). */
shouldUseNarrowTableLayout: boolean;

/** Callback when the user changes the search string in the filter bar. */
onSearchStringChange?: (searchString: string) => void;
};

const defaultTableContextValue: TableContextValue<TableData, string> = {
Expand Down
8 changes: 7 additions & 1 deletion src/components/Table/TableFilterBar/TableSearchBar.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ function TableSearchBar({label}: TableSearchBarProps) {
const {
activeSearchString,
shouldUseNarrowTableLayout,
onSearchStringChange,
tableMethods: {updateSearchString},
} = useTableContext();

Expand All @@ -48,6 +49,11 @@ function TableSearchBar({label}: TableSearchBarProps) {
// eslint-disable-next-line react-hooks/exhaustive-deps
}, []);

const handleSearchStringChange = (text: string) => {
updateSearchString(text);
onSearchStringChange?.(text);
};

const containerStyles = shouldUseNarrowTableLayout && styles.flex1;

const touchableInputWrapperStyle = [styles.mnw200, !shouldUseNarrowTableLayout ? styles.h8 : styles.h11];
Expand Down Expand Up @@ -76,7 +82,7 @@ function TableSearchBar({label}: TableSearchBarProps) {
clearButtonIconSize={shouldUseNarrowTableLayout ? undefined : variables.iconSizeSmall}
onBlur={() => setInputFocused(false)}
onFocus={() => setInputFocused(true)}
onChangeText={(text) => updateSearchString(text)}
onChangeText={handleSearchStringChange}
/>
);
}
Expand Down
3 changes: 3 additions & 0 deletions src/components/Table/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -200,6 +200,9 @@ type TableProps<DataType extends TableData, ColumnKey extends string = string, F

/** Callback when an option is selected */
onRowSelectionChange?: (selectedRowKeys: string[]) => void;

/** Optional callback fired when the active search string changes. */
onSearchStringChange?: (searchString: string) => void;
}>;

export type {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ export default function ReportParticipantsTableRow({item, rowIndex, shouldUseNar
rowIndex={rowIndex}
disabled={item.disabled}
accessibilityLabel={accessibilityLabel}
sentryLabel={CONST.SENTRY_LABEL.REPORT.PARTICIPANTS_ROW}
offlineWithFeedback={{pendingAction: item.pendingAction}}
onPress={item.action}
>
Expand Down
Loading
Loading