Skip to content

[No QA] Docs: add bulk Download as PDF to the Export Expenses and Reports article#95290

Open
mollfpr wants to merge 1 commit into
mainfrom
mollfpr-export-reports-bulk-pdf-docs
Open

[No QA] Docs: add bulk Download as PDF to the Export Expenses and Reports article#95290
mollfpr wants to merge 1 commit into
mainfrom
mollfpr-export-reports-bulk-pdf-docs

Conversation

@mollfpr

@mollfpr mollfpr commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Explanation of Change

Now that bulk Download as PDF has shipped, this updates the Export Expenses and Reports help article to document it. Adds a "Download multiple reports" section under Export as PDF, updates the bulk-export FAQ (PDF is no longer one-at-a-time), and adds an FAQ explaining what happens when some reports fail to download.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/630551
PROPOSAL:

Tests

N/A

  • Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

N/A

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@mollfpr mollfpr requested a review from bfitzexpensify July 3, 2026 16:01
@mollfpr mollfpr self-assigned this Jul 3, 2026
@github-actions github-actions Bot changed the title [NoQA] Docs: add bulk Download as PDF to the Export Expenses and Reports article [No QA] [NoQA] Docs: add bulk Download as PDF to the Export Expenses and Reports article Jul 3, 2026
@OSBotify

OSBotify commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

A preview of your ExpensifyHelp changes have been deployed to https://659cec16.helpdot.pages.dev ⚡️

Updated articles:

@mollfpr mollfpr marked this pull request as ready for review July 3, 2026 16:06
@mollfpr mollfpr requested a review from stephanieelliott as a code owner July 3, 2026 16:06
@mollfpr mollfpr changed the title [No QA] [NoQA] Docs: add bulk Download as PDF to the Export Expenses and Reports article [No QA] Docs: add bulk Download as PDF to the Export Expenses and Reports article Jul 3, 2026
2. Check the box next to each report you want to download, or use the top checkbox to select all.
3. Click **Selected**.
4. Select **Download as PDF**.
5. A status window appears while your files are prepared. When they're ready, the download starts automatically. If it doesn't, click **Download file**. You can also click **Send me the file when it's ready** to have **Concierge** send the files to you in a chat message instead.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Step formatting: Per HELP_AUTHORING_GUIDELINES.md Section 5, steps must be action-oriented actions the user takes. Step 5 describes system behavior (status window, automatic download) rather than a user action, and bundles multiple ideas into one step. Move this outcome/explanation out of the numbered list into a following sentence (as the CSV sections do at lines 34/47), e.g. "After you select Download as PDF, a status window appears while your files are prepared...".

- Report notes
## Download multiple reports

1. Click the navigation tabs (on the left on web, on the bottom on mobile), then select **Spend** > **Reports**.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Navigation phrasing consistency: Per HELPSITE_NAMING_CONVENTIONS.md (Deterministic Writing Rule + unified-navigation form), keep this phrasing consistent with the rest of the article. Other sections in this file use "In the navigation tabs (on the left on web, and at the bottom on mobile)" — this line uses "Click the navigation tabs (on the left on web, on the bottom on mobile)". Align the wording to avoid stylistic variation.

@github-actions

github-actions Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment
This PR updates the Export as PDF section of the Export Expenses and Reports article to document the new bulk Download as PDF capability. It adds two task-based subsections (single vs. multiple report download), updates the bulk-export FAQ, and adds a new FAQ for partial-failure scenarios. The changes are focused, correctly scoped to a single workflow, and notably fix a prior naming-convention violation.

Scores Summary

  • Readability: 7/10 - Clear, scannable, and well-sequenced overall. The one weak point is step 5 of Download multiple reports, which packs the status window, auto-download, manual fallback, and Concierge option into a single numbered step.
  • AI Readiness: 8/10 - New subsections are task-based (Download a single report, Download multiple reports) and searchable; new FAQ entries are question-based and useful for retrieval. Full feature names used consistently.
  • Style Compliance: 9/10 - Strong adherence. Correctly adopts the required three dots format Select the three dots (⋮), uses the unified navigation sentence (on the left on web, on the bottom on mobile), and bolds button/product names in sentence case.

Key Findings

  • Positive: Replaces the previous non-compliant Click More in the top-right corner with the governed three dots rule per HELPSITE_NAMING_CONVENTIONS.md.
  • Positive: Navigation phrasing follows the unified web/mobile pattern exactly, and Spend, Reports, Selected, Download as PDF are correctly bolded in sentence case.
  • Positive: New FAQ entries are task/question-based and directly address real user intent (bulk export, partial failures).
  • Improvement: Step 5 under Download multiple reports combines multiple outcomes/conditions into one step, which conflicts with the one-action-per-step spirit of the Step Formatting Standard.

Recommendations

  • Split step 5 so each numbered step is a single action; move the fallback and Concierge behavior into a brief explanatory sentence after the list.
  • No further changes required for style or metadata within the scope of this diff.

Files Reviewed

  • docs/articles/new-expensify/reports-and-expenses/Search-and-Download-Expenses.md - Approved with a minor readability suggestion on step formatting.

Note: This review covers only the proposed changes in the diff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants