[No QA] Extend Oxfmt formatting to YAML files by roryabraham · Pull Request #95254 · Expensify/App

roryabraham · 2026-07-03T04:43:57Z

Explanation of Change

Extends Oxfmt formatting to YAML files (.yml / .yaml) in addition to JS/TS. YAML files use a 2-space tabWidth override in .oxfmtrc.json while JS/TS keep the existing 4-space style, matching the approach in GitHub-Actions #79.

Changes:

Remove *.yml and *.yaml from ignorePatterns in .oxfmtrc.json
Add an overrides entry setting tabWidth: 2 for YAML files
Add **.yml, **.yaml, and .oxfmtrc.json to the Oxfmt CI workflow path filter
Include yml/yaml in the fmt-watch npm script

Ran npm run fmt — no YAML files needed reformatting (they were already 2-space indented).

Fixed Issues

$

PROPOSAL:

Tests

Run npm run fmt from the App repo root and confirm it completes without errors.
Run npx oxfmt --check . and confirm it passes.
Edit a .github/workflows/*.yml file with inconsistent indentation, run npm run fmt, and confirm Oxfmt normalizes it to 2-space indent.

Verify that no errors appear in the JS console

Offline tests

N/A — tooling-only change.

QA Steps

[No QA]

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

N/A — tooling-only change.

Android: mWeb Chrome

N/A — tooling-only change.

iOS: Native

N/A — tooling-only change.

iOS: mWeb Safari

N/A — tooling-only change.

MacOS: Chrome / Safari

N/A — tooling-only change.

Remove YAML from ignorePatterns, add a tabWidth: 2 override for *.yml/*.yaml, and update the Oxfmt CI path filter and fmt-watch script so workflow files are covered going forward. Co-authored-by: Cursor <cursoragent@cursor.com>

melvin-bot · 2026-07-03T04:44:02Z

npm has a package.json file and a package-lock.json file. It seems you updated one without the other, which is usually a sign of a mistake. If you are updating a package make sure that you update the version in package.json then run npm install

codecov · 2026-07-03T04:48:24Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
see 16 files with indirect coverage changes

Fixes spellcheck failure on package.json fmt scripts. Co-authored-by: Cursor <cursoragent@cursor.com>

OSBotify · 2026-07-03T05:00:55Z

A preview of your ExpensifyHelp changes have been deployed to https://b2681ed4.helpdot.pages.dev ⚡️

melvin-bot · 2026-07-03T05:03:47Z

@inimaga Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

marcochavezf · 2026-07-03T06:00:18Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

github-actions · 2026-07-03T06:02:22Z

🚧 marcochavezf has triggered a test Expensify/App build. You can view the workflow run here.

OSBotify · 2026-07-03T06:05:50Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-07-03T06:14:43Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #95254.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-aabaa2ebef8-d7a1826-d8de7d7db8e72efbb580d42396a1754cf08eb9eb/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-aabaa2e-d7a1826-b930433e1de3fe3b153981117916a5cb69ee256e/index.html

Web 🕸️
https://95254.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-07-03T16:46:26Z

🚀 Deployed to staging by https://github.com/marcochavezf in version: 9.4.27-1 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-07-06T15:34:18Z

🚀 Deployed to production by https://github.com/grgia in version: 9.4.27-2 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android

Extend Oxfmt to format YAML with 2-space indent

8d915d1

Remove YAML from ignorePatterns, add a tabWidth: 2 override for *.yml/*.yaml, and update the Oxfmt CI path filter and fmt-watch script so workflow files are covered going forward. Co-authored-by: Cursor <cursoragent@cursor.com>

melvin-bot Bot assigned roryabraham Jul 3, 2026

roryabraham and others added 2 commits July 2, 2026 21:48

Add oxfmt to cspell dictionary

7430b5b

Fixes spellcheck failure on package.json fmt scripts. Co-authored-by: Cursor <cursoragent@cursor.com>

Add oxfmt to the spellcheck list

7e9fff6

roryabraham requested a review from marcochavezf July 3, 2026 04:52

roryabraham changed the title ~~Extend Oxfmt formatting to YAML files~~ [No QA] Extend Oxfmt formatting to YAML files Jul 3, 2026

Remove yaml from prettierignore and run oxfmt

2fb2e44

roryabraham marked this pull request as ready for review July 3, 2026 05:03

roryabraham requested a review from a team as a code owner July 3, 2026 05:03

melvin-bot Bot requested a review from inimaga July 3, 2026 05:03

melvin-bot Bot removed the request for review from a team July 3, 2026 05:03

roryabraham mentioned this pull request Jul 3, 2026

[Due for payment 2026-07-13] Replace Prettier with Oxfmt and setup a pre-commit hook to run formatting #95240

Closed

marcochavezf approved these changes Jul 3, 2026

View reviewed changes

marcochavezf merged commit aabaa2e into main Jul 3, 2026
51 checks passed

marcochavezf deleted the rory-oxfmt-yaml branch July 3, 2026 06:01

OSBotify mentioned this pull request Jul 3, 2026

Deploy Checklist: New Expensify 2026-07-03 #95291

Closed

98 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[No QA] Extend Oxfmt formatting to YAML files#95254

[No QA] Extend Oxfmt formatting to YAML files#95254
marcochavezf merged 4 commits into
mainfrom
rory-oxfmt-yaml

roryabraham commented Jul 3, 2026

Uh oh!

melvin-bot Bot commented Jul 3, 2026

Uh oh!

codecov Bot commented Jul 3, 2026 •

edited by github-actions Bot

Loading

Uh oh!

OSBotify commented Jul 3, 2026

Uh oh!

melvin-bot Bot commented Jul 3, 2026

Uh oh!

marcochavezf commented Jul 3, 2026

Uh oh!

Uh oh!

github-actions Bot commented Jul 3, 2026

Uh oh!

OSBotify commented Jul 3, 2026

Uh oh!

github-actions Bot commented Jul 3, 2026

Uh oh!

OSBotify commented Jul 3, 2026

Uh oh!

OSBotify commented Jul 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

roryabraham commented Jul 3, 2026

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Jul 3, 2026

Uh oh!

codecov Bot commented Jul 3, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

OSBotify commented Jul 3, 2026

Uh oh!

melvin-bot Bot commented Jul 3, 2026

Uh oh!

marcochavezf commented Jul 3, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

github-actions Bot commented Jul 3, 2026

Uh oh!

OSBotify commented Jul 3, 2026

Uh oh!

github-actions Bot commented Jul 3, 2026

Uh oh!

OSBotify commented Jul 3, 2026

Uh oh!

OSBotify commented Jul 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov Bot commented Jul 3, 2026 •

edited by github-actions Bot

Loading