[CP Staging] Fix Spend-Not able to delete expenses in bulk in Spend - #95220
Conversation
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
|
@marcochavezf Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppSimulator.Screen.Recording.-.iPhone.15.Pro.-.2026-07-02.at.21.59.39.moviOS: mWeb SafariMacOS: Chrome / Safari |
Pujan92
left a comment
There was a problem hiding this comment.
LGTM! waitForUpcomingTransition for ios will defer the callback.
|
🚧 cristipaval has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
[CP Staging] Fix Spend-Not able to delete expenses in bulk in Spend (cherry picked from commit 58d41bb) (cherry-picked to staging by cristipaval)
…613629802-1 🍒 Cherry pick PR #95220 to staging 🍒
|
🚀 Cherry-picked to staging by https://github.com/cristipaval in version: 9.4.27-1 🚀
|
|
🤖 Help site review — no docs changes required. I reviewed the changes in this PR against Expensify's help site articles under This is an internal bug fix: it changes how the bulk-delete confirmation modal is presented on the Spend page — replacing Because there's no change to documented product behavior, no help site articles need updating, so I did not create a draft help site PR. @hungvu193, if you believe a specific article should still be updated, let me know which one and I'll take another pass. |
|
🚀 Deployed to production by https://github.com/grgia in version: 9.4.27-2 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Fix the conflict animation between the native iOS modal in Spend page.
Fixed Issues
$ #95114
PROPOSAL: N/A
Tests
Same as QA
Offline tests
N/A
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)Avatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
Screen.Recording.2026-07-02.at.23.15.50.mov
iOS: mWeb Safari
Screen.Recording.2026-07-02.at.23.22.04.mov
MacOS: Chrome / Safari
Screen.Recording.2026-07-02.at.23.21.30.mov