[Payment due @DylanDylann] Exclude all-pending card reports from the Submit to-do by ishpaul777 · Pull Request #95204 · Expensify/App

ishpaul777 · 2026-07-02T14:16:31Z

Explanation of Change

Workspace expense reports whose only expense is a pending (unposted) Expensify Card transaction were being counted in the "Submit" to-do and shown a Submit button, even though such a report can't be submitted until the transaction posts (its own next-steps text already says so).

The client has several independent predicates that decide whether a report is submittable, and each needed the same pending-card guard:

isSubmitAction (src/libs/ReportPrimaryActionUtils.ts) - Home/For You tile, Spend count, and the report header primary button.
canSubmit (src/libs/ReportPreviewActionUtils.ts) - the Submit button on the report preview card in chat.
isSubmitAction (src/libs/ReportSecondaryActionUtils.ts) - the Submit option in the report More menu.
canSubmitReport (src/libs/actions/IOU/ReportWorkflow.ts) - the green Submit badge/pill shown in the LHN.
getReasonAndReportActionThatRequiresAttention (src/libs/ReportUtils.ts) - the Inbox "To-dos" tab membership, its count, and the green dot (GBR).

All of them now gate pending on card transactions specifically (isExpensifyCardTransaction(transaction) && isPending(transaction), reusing the shared hasOnlyPendingCardTransactions helper where it fits), so pending cash/manual expenses stay submittable and the behavior matches the other Submit entry points.

This is the same family of bug as #637331 (all-held reports), but for pending card transactions. The server-side parallel is handled in a companion Auth PR so the prefetched Search snapshot agrees with the client.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/653982
PROPOSAL:

Tests

Set up a Collect/Control workspace where you are the submitter, with an Expensify Card.
Create a workspace expense report whose only expense is a pending (unposted) card transaction (still pending, not yet posted).
Open NewDot Home (For You): verify the report is not counted in the "Submit" tile.
Open Inbox and the Search type-menu: verify the "Submit" badge does not count the report.
Open the Spend tab: verify the report is not included in the Submit count.
Open the report itself: verify no Submit button is offered and next-steps says the transaction is still pending.
Add a second, normal (posted) expense to the same report and verify the report is now submittable (Submit prompt/button reappear), confirming only all-pending reports are excluded.

Verify that no errors appear in the JS console

Offline tests

Same as Tests. The to-do counts are derived locally from Onyx data (ONYXKEYS.DERIVED.TODOS), so the pending report should be excluded from the Submit to-do while offline as well.

QA Steps

Same as Tests.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Screen.Recording.2026-07-03.at.1.05.33.AM.mov

melvin-bot · 2026-07-02T14:16:37Z

@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 470f99d5f2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

…eports

…n test

DylanDylann · 2026-07-03T09:05:53Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2026-07-03.at.16.33.45.mov

Android: mWeb Chrome

stuck on mocking Onyx on mWeb

iOS: HybridApp

Screen.Recording.2026-07-03.at.16.21.28.mov

iOS: mWeb Safari

stuck on mocking Onyx on mWeb

MacOS: Chrome / Safari

Screen.Recording.2026-07-03.at.16.11.41.mov

melvin-bot · 2026-07-03T09:35:22Z

🎯 @DylanDylann, thanks for reviewing and testing this PR! 🎉

A payment issue will be created for your review once this PR is deployed to production.
E/E issue linked to the PR - https://www.github.com/Expensify/Expensify/issues/653982.

If payment is not needed (e.g., regression PR review fix etc), react with 👎 to this comment to prevent the payment issue from being created.

mountiny · 2026-07-05T16:37:58Z

I think this will need to be internalQA as Applause cannot create pending ecard transactions

mountiny · 2026-07-05T16:38:12Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: de71797e13

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

mountiny

Looks solid, thank you!

…ort changes A pending card expense going to posted only queued the expense report for recompute, leaving the parent chat's requiresAttention stale so the report could miss the Inbox to-do/GBR once it became submittable.

…-exclude-pending

JmillsExpensify

No product review required.

mountiny

Thank you

github-actions · 2026-07-07T18:29:13Z

🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here.

OSBotify · 2026-07-07T18:31:03Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-07-07T18:34:46Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #95204.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-33c913484bc-cc1845f-5954e4dffc32bceb03c58e6bf8871415192f84e0/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-33c9134-cc1845f-ee2a69dee3f52bc0ab9379a7091deff8d58e054c/index.html

Web 🕸️
https://95204.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-07-09T11:05:59Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.4.32-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MelvinBot · 2026-07-09T11:09:27Z

Help site review — changes required ✅

This PR changes user-facing behavior that is documented on the help site, so a docs update is needed.

What changed: All-pending Expensify Card reports are now excluded from the Submit to-do and no longer show a Submit button until a transaction posts.

Doc that was outdated: Create and Submit Reports — the section "Why can't I submit a report with pending Expensify Card transactions?" still said the Submit button appears and errors with Unable to submit report on click. After this PR, the button no longer appears and the report isn't counted in the Submit to-do.

Draft help site PR: #95687 — updates that section to reflect the new behavior (HelpDot label applied, assigned to ishpaul777).

Content change

Before:

If all transactions on your report are pending Expensify Card transactions, you'll see the Submit button but clicking it will display an Unable to submit report error. Pending transactions may take a few days to post. After at least one transaction has posted, you can submit the report.

After:

If all transactions on your report are pending Expensify Card transactions, the report can't be submitted yet. The Submit button won't appear, and the report isn't counted in your Submit to-do. Pending transactions may take a few days to post. After at least one transaction has posted, the Submit button appears again and you can submit the report.

@ishpaul777, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR Ready for review

mountiny · 2026-07-09T19:03:33Z

I will QA this tomorrow when I make some ecard transaction

OSBotify · 2026-07-10T13:43:02Z

🚀 Deployed to production by https://github.com/grgia in version: 9.4.32-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android

melvin-bot · 2026-07-10T13:44:54Z

🤖 Payment issue created: #95815

Exclude all-pending card reports from the Submit to-do

470f99d

ishpaul777 requested review from a team as code owners July 2, 2026 14:16

melvin-bot Bot assigned ishpaul777 Jul 2, 2026

melvin-bot Bot requested review from DylanDylann and JmillsExpensify and removed request for a team July 2, 2026 14:16

melvin-bot Bot removed the request for review from a team July 2, 2026 14:16

chatgpt-codex-connector Bot reviewed Jul 2, 2026

View reviewed changes

Comment thread src/libs/ReportPrimaryActionUtils.ts Outdated

ishpaul777 added 6 commits July 3, 2026 01:10

Gate the Submit to-do on card-specific pending transactions

8ed9c5b

Hide the report preview Submit button for all-pending card reports

381f43a

Hide the Submit option in the report More menu for all-pending card r…

ab7cb49

…eports

Drop the LHN Submit badge for all-pending card reports

889bcd0

Exclude all-pending card reports from the Inbox to-do and green dot

c8bd012

Fix CI: reword unposted comment and avoid new unsafe type assertion i…

de71797

…n test

DylanDylann approved these changes Jul 3, 2026

View reviewed changes

melvin-bot Bot changed the title ~~Exclude all-pending card reports from the Submit to-do~~ [Payment due @DylanDylann] Exclude all-pending card reports from the Submit to-do Jul 3, 2026

ishpaul777 requested a review from mountiny July 3, 2026 19:08

mountiny added the InternalQA This pull request required internal QA label Jul 5, 2026

chatgpt-codex-connector Bot reviewed Jul 5, 2026

View reviewed changes

Comment thread src/libs/ReportUtils.ts

mountiny previously approved these changes Jul 5, 2026

View reviewed changes

ishpaul777 dismissed mountiny’s stale review via 7321710 July 6, 2026 12:40

ishpaul777 added 2 commits July 6, 2026 18:41

Merge remote-tracking branch 'upstream/main' into ishpaul/submit-todo…

4be2be7

…-exclude-pending

Apply Oxfmt import ordering to reportAttributes test

db0c495

ishpaul777 requested a review from mountiny July 6, 2026 13:14

mountiny reviewed Jul 6, 2026

View reviewed changes

Comment thread tests/unit/reportAttributesTest.ts

JmillsExpensify reviewed Jul 7, 2026

View reviewed changes

mountiny approved these changes Jul 7, 2026

View reviewed changes

mountiny merged commit 33c9134 into Expensify:main Jul 7, 2026
37 checks passed

OSBotify mentioned this pull request Jul 9, 2026

Deploy Checklist: New Expensify 2026-07-09 #95677

Closed

94 tasks

MelvinBot mentioned this pull request Jul 9, 2026

[No QA] Docs updates for E/A#95204 exclude pending card reports from Submit #95687

Merged

melvin-bot Bot mentioned this pull request Jul 10, 2026

[Due for payment 2026-07-17] Payment issue for E/App PR#95204 #95815

Closed

Uh oh!

Conversation

ishpaul777 commented Jul 2, 2026 • edited by luacmartins Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Jul 2, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

DylanDylann commented Jul 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Jul 3, 2026

Uh oh!

mountiny commented Jul 5, 2026

Uh oh!

mountiny commented Jul 5, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

JmillsExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Jul 7, 2026

Uh oh!

OSBotify commented Jul 7, 2026

Uh oh!

github-actions Bot commented Jul 7, 2026

Uh oh!

OSBotify commented Jul 9, 2026

Uh oh!

MelvinBot commented Jul 9, 2026

Help site review — changes required ✅

Uh oh!

mountiny commented Jul 9, 2026

Uh oh!

OSBotify commented Jul 10, 2026

Uh oh!

melvin-bot Bot commented Jul 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

ishpaul777 commented Jul 2, 2026 •

edited by luacmartins

Loading

DylanDylann commented Jul 3, 2026 •

edited

Loading