Use stored mappings for columns in CSV card import#95183
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
@thesahindia Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fb3ac4a815
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
Having some issue. Posted here to get some help. |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-07-08.at.7.23.14.AM.movAndroid: mWeb ChromeScreen.Recording.2026-07-08.at.6.45.26.AM.moviOS: HybridAppScreen.Recording.2026-07-08.at.1.54.35.AM.moviOS: mWeb SafariScreen.Recording.2026-07-08.at.2.00.04.AM.movMacOS: Chrome / SafariScreen.Recording.2026-07-07.at.10.08.51.PM.mov |
|
@carlosmiceli Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 Gonals has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/Gonals in version: 9.4.33-0 🚀
|
|
🤖 Help site review — no changes required This PR ( That behavior is already documented in the relevant help article,
This PR is an internal fix that makes the app match what the docs already describe — it adds no new UI, feature name, tab, or setting label. So there's nothing to add or correct on the help site, and I did not open a docs PR. @Gonals, please confirm you agree the existing article already reflects this behavior. If you'd like any wording strengthened (e.g. making the auto-fill note more explicit), let me know and I'll open a draft docs PR. |
|
🚀 Deployed to production by https://github.com/lakchote in version: 9.4.33-8 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Fixed Issues
$ #95010
PROPOSAL:
Tests
In a workspace with company cards enabled go to Company Cards > Add Cards > Import from File
Upload a file where not all columns get mapped by default, like this one:
fakeyfakes.csv
Manually map the missing attributes, complete the process and wait until the cards appear.
For that same feed, go to settings > Import from Spreadsheet to add more transactions
Upload the same file. Confirm the columns are now premapped
Offline tests
None
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)Avatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari