Skip to content

Fix: separate More button from next step message in narrow report header - #95110

Closed
MelvinBot wants to merge 1 commit into
mainfrom
claude-moreButtonOverlapNextStep
Closed

Fix: separate More button from next step message in narrow report header#95110
MelvinBot wants to merge 1 commit into
mainfrom
claude-moreButtonOverlapNextStep

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Explanation of Change

On an empty expense report opened in narrow layout (e.g. Android app, portrait), the "More" button and the next‑step message ("Waiting for you to add expenses.") were rendered with no vertical separation, so they collided and the button became hard to tap.

This is a regression from #94392, which wrapped MoneyReportHeaderActions (the More button) and MoneyReportHeaderMoreContent (the next‑step message) into a single flexColumn container in the narrow‑layout branch of MoneyReportHeader. That container has no spacing between its children, so the two stacked blocks sit flush against each other.

The fix adds styles.gap2 to that flexColumn wrapper so the actions row and the next‑step message always have clear vertical spacing between them.

Note on the approved proposal: the proposal's suggested edit (removing shouldShowNextStep && styles.pt0 on MoneyReportHeaderMoreContent) would be a no‑op, since styles.pt0 resolves to paddingTop: 0. This PR instead implements the proposal's other suggested option — adding spacing on the flexColumn wrapper — which is what actually restores the separation.

Fixed Issues

$ #95093
PROPOSAL: #95093 (comment)

Tests

  1. Use a group‑workspace (group policy) account on a narrow layout (Android app or a narrow browser window).
  2. Go to the workspace chat and create a new (empty) expense report, then open it.
  3. Verify the "More" button appears above the next‑step message ("Waiting for you to add expenses.") with clear spacing between them, and that the More button is easily tappable (no overlap).
  4. Verify wide/landscape layouts and non‑empty reports (with a primary action and/or a status bar) still look correct with no extra/incorrect spacing.
  • Verify that no errors appear in the JS console

Offline tests

Same as tests.

QA Steps

  1. On a narrow device (Android app), open a workspace chat on a group workspace.
  2. Create an empty expense report and open it.
  3. Verify the "More" button sits above the next‑step message with clear spacing and is easily tappable (does not overlap the message).
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I verified that if a modal is broken by my changes, it can be dismissed
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

🤖 Generated by MelvinBot. The Tests/QA steps and checklist above must be completed/confirmed by the human co-author before marking this PR ready for review.

Co-authored-by: Hans Vu <hungvu193@users.noreply.github.com>
@MelvinBot

Copy link
Copy Markdown
Contributor Author

Neither failing check is a real problem with this PR's code — no fix needs to be pushed.

1. test (job 5)flaky infra failure, unrelated to this PR. Every test in the shard printed PASS (including tests/ui/MoneyReportContentCreatedTest.tsx, which covers the touched area), then the runner died with ##[error]Process completed with exit code 143. Exit 143 = SIGTERM — the CI runner killed the process (OOM/timeout), not a test assertion. This PR's only change is a one-line style-prop addition (MoneyReportHeader.tsx — adding styles.gap2 to a View), which cannot cause a SIGTERM. Just re-run the failed job (Re-run failed jobs on the test run).

2. PR Author Checklist / checklist → expected, not a code issue. It fails because the author checklist boxes aren't ticked. As the human co-author, you'll need to complete the Tests/QA sections and check the boxes before marking the PR ready — I can't do that on your behalf.

I couldn't trigger the re-run myself (that action isn't permitted in this environment), so please click Re-run failed jobs on the test run above. Everything else on the PR is green.

Evidence
  • Failed run: https://github.com/Expensify/App/actions/runs/28565099029/job/84690625067
  • Tail of the log: all shards PASS, ending in ##[error]Process completed with exit code 143 — a runner-level kill, no FAIL/assertion output anywhere in the shard.
  • Changed files: only src/components/MoneyReportHeader.tsx (one line: styles.flexColumnstyles.flexColumn, styles.gap2).

@hungvu193

Copy link
Copy Markdown
Contributor

@MelvinBot Close this one, I'll do it myself.

@MelvinBot

Copy link
Copy Markdown
Contributor Author

Closed as requested — all yours, hungvu193. 👍

@MelvinBot MelvinBot closed this Jul 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants