Fix: separate More button from next step message in narrow report header - #95110
Fix: separate More button from next step message in narrow report header#95110MelvinBot wants to merge 1 commit into
Conversation
Co-authored-by: Hans Vu <hungvu193@users.noreply.github.com>
|
Neither failing check is a real problem with this PR's code — no fix needs to be pushed. 1. 2. I couldn't trigger the re-run myself (that action isn't permitted in this environment), so please click Re-run failed jobs on the test run above. Everything else on the PR is green. Evidence
|
|
@MelvinBot Close this one, I'll do it myself. |
|
Closed as requested — all yours, |
Explanation of Change
On an empty expense report opened in narrow layout (e.g. Android app, portrait), the "More" button and the next‑step message ("Waiting for you to add expenses.") were rendered with no vertical separation, so they collided and the button became hard to tap.
This is a regression from #94392, which wrapped
MoneyReportHeaderActions(the More button) andMoneyReportHeaderMoreContent(the next‑step message) into a singleflexColumncontainer in the narrow‑layout branch ofMoneyReportHeader. That container has no spacing between its children, so the two stacked blocks sit flush against each other.The fix adds
styles.gap2to thatflexColumnwrapper so the actions row and the next‑step message always have clear vertical spacing between them.Fixed Issues
$ #95093
PROPOSAL: #95093 (comment)
Tests
Offline tests
Same as tests.
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionDesignlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
🤖 Generated by MelvinBot. The
Tests/QAsteps and checklist above must be completed/confirmed by the human co-author before marking this PR ready for review.