Skip to content

[No QA] [Hold for feature] Docs updates for E/A#94207 document Permitted currencies in Card Spend Rules#95087

Merged
stephanieelliott merged 1 commit into
mainfrom
claude-spendRuleCurrencyDocs
Jul 7, 2026
Merged

[No QA] [Hold for feature] Docs updates for E/A#94207 document Permitted currencies in Card Spend Rules#95087
stephanieelliott merged 1 commit into
mainfrom
claude-spendRuleCurrencyDocs

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Explanation of Change

Companion help-site update for #94207, which fixes the deploy blockers for the currency restriction in Expensify Card Spend Rules.

The Expensify Card Spend Rules article documented only the Merchant, Spend category, and Max amount configuration options. The live spend-rule UI also includes a Permitted currencies field ("Choose to allow all or specific currencies"), which was undocumented.

Changes

  • Added Permitted currencies to the "How to create Expensify Card Spend rules" configuration list.
  • Mentioned permitted currencies in the intro and in the "How to edit or delete" steps.
  • Added permitted currencies / currency restrictions to the article keywords for retrieval.

UI labels verified against the current App source (workspace.rules.spendRules.permittedCurrencies → "Permitted currencies").


@JS00001, please review the files changed and confirm they reflect the current behavior. Then mark this PR Ready for review.

Co-authored-by: Jack Senyitko <JS00001@users.noreply.github.com>
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Jul 1, 2026
@github-actions github-actions Bot changed the title Docs updates for E/A#94207 document Permitted currencies in Card Spend Rules [No QA] Docs updates for E/A#94207 document Permitted currencies in Card Spend Rules Jul 1, 2026
@OSBotify

OSBotify commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

A preview of your ExpensifyHelp changes have been deployed to https://00d946a0.helpdot.pages.dev ⚡️

Updated articles:

@JS00001 JS00001 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets merge this tomorrow, once this gets to prod

@JS00001
JS00001 marked this pull request as ready for review July 6, 2026 12:56
@JS00001
JS00001 requested a review from stephanieelliott as a code owner July 6, 2026 12:56
@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR is a small, focused companion update to the Expensify Card Spend Rules article, documenting the previously-undocumented Permitted currencies configuration option (4 additions, 3 deletions). The changes add the field to the intro, the create-rule configuration list, the edit steps, and the article keywords. The proposed changes are accurate, consistent with the surrounding content, and match the verified UI label.

Scores Summary

  • Readability: 9/10 - The added sentences and list item read clearly and follow the existing pattern; the new bullet mirrors sibling options cleanly.
  • AI Readiness: 9/10 - New keywords (permitted currencies, currency restrictions) reflect real search intent; internalScope remains accurate and no headings/hierarchy were disturbed.
  • Style Compliance: 10/10 - Permitted currencies is bolded in sentence case and matches the verified UI label (workspace.rules.spendRules.permittedCurrencies), consistent with the Merchant / Spend category / Max amount bullets.

Key Findings

  • The new Permitted currencies bullet is correctly formatted and placed logically after Max amount, matching the live UI order.
  • Keyword additions improve semantic retrieval without introducing internal or vague language.
  • Positive: the PR keeps scope tight to a single change and verifies the label against App source.
  • Minor (optional): the description frontmatter still lists only merchants, categories, and amounts; adding currencies there would keep metadata fully aligned. Not blocking, as it remains accurate.

Recommendations

  • Optional: extend the description frontmatter to mention currency restrictions for parity with the intro and keywords.
  • No blocking issues; the changes are ready as-is.

Files Reviewed

  • docs/articles/new-expensify/expensify-card/Expensify-Card-Spend-Rules.md - Approved. Accurate, well-formatted, and style-compliant additions.

Note: This is a summary review of the proposed diff only.

@stephanieelliott stephanieelliott changed the title [No QA] Docs updates for E/A#94207 document Permitted currencies in Card Spend Rules [No QA] [Hold for feature] Docs updates for E/A#94207 document Permitted currencies in Card Spend Rules Jul 6, 2026
@stephanieelliott
stephanieelliott merged commit 75e12ae into main Jul 7, 2026
21 checks passed
@stephanieelliott
stephanieelliott deleted the claude-spendRuleCurrencyDocs branch July 7, 2026 21:24
@OSBotify

OSBotify commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.4.32-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/grgia in version: 9.4.32-3 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants