Add remaining limit column to Expensify Card table#95041
Conversation
|
@linhvovan29546 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
|
🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
|
🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
|
@MelvinBot sync with main |
b674dd3 to
37e8afd
Compare
|
Synced with main via rebase (no conflicts). Reformatted per the new Oxfmt tooling and re-verified lint/typecheck/React Compiler compliance. |
|
🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
|
@Expensify/design @joekaufmanexpensify here it is updates with the Remaining Limit
On narrow the Remaining limit would be with the Cut we can change that as well |
|
Yeah, it looks a bit jumbled to me. I'd probably vote to remove it on mobile. |
|
Yeah I agree with Joe, let's remove it on mobile. Desktop is looking pretty good, but it seems like the Last 4 column is huge and the name column is too small. Is there any way we can even out those columns a bit and give more space to the name column? @mountiny unrelated: The letter avatars in your screenshots look tiny - where did those come from? Just want to know if we need to do some follow up on those. |
|
Agree with all of those comments. We should be able to just hard code a width for the last 4 column, let's just do something similar to the Type or Limit width. |
|
@dannymcclain Georgia just submitted a fix for the tiny avatar letters and they are on staging. So a fresh pull of main should fix things. |
|
Actually maybe this is just our eyes playing tricks on us - limit is right aligned, last four is left aligned... so there is a big gap in between even if the columns are technically the same size, hence the perceived "wide column" effect? |
|
@dannymcclain I think this PR #95639 |
37e8afd to
17d2123
Compare
|
Updated per feedback: the Remaining limit is now hidden on narrow/mobile layout (same pattern as Type / Limit Type / Last 4), since it looked jumbled with larger limits there. Desktop is unchanged. Also re-synced with main again (rebase, no conflicts) and re-verified lint/typecheck/format/React Compiler compliance. |
|
🚧 shawnborton has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
Yeah, it really bothers me that the name column is so heavily truncated when there's gobs of space available. |
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
The column only ever renders four digits, so letting it take an equal 1fr share of the grid wasted horizontal space now that Status and Remaining limit also compete for it. Co-authored-by: Cursor <cursoragent@cursor.com>
17d2123 to
59daba0
Compare
|
@shawnborton good call — done in 59daba0. The I sized it at Also rebased on latest |




Explanation of Change
Adds a "Remaining limit" column to the Expensify Card table (next to the existing "Limit" column) so admins can see how much of each cardholder's limit is left without opening every card individually. The per-card remaining limit (
availableSpend) already exists in Onyx and is returned byOpenPolicyExpensifyCardsPage— this is a frontend-only change to surface it in the table (wide layout: new column; narrow layout: shown stacked next to the limit).Fixed Issues
$ #95036
PROPOSAL:
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)Avatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Not yet tested — needs manual QA.
Android: mWeb Chrome
Not yet tested — needs manual QA.
iOS: Native
Not yet tested — needs manual QA.
iOS: mWeb Safari
Not yet tested — needs manual QA.
MacOS: Chrome / Safari
Not yet tested — needs manual QA.