[CP Staging] Fix bank account label not showing in search bar after reopen by allgandalf · Pull Request #94987 · Expensify/App

allgandalf · 2026-06-30T14:52:43Z

Explanation of Change

on staging, after typing bank-account:"Bank xx1111" and pressing Enter, reopening the search bar shows the raw bank-account ID (bank-account:9789681) instead of the label.

root cause: src/components/Search/SearchRouter/SearchRouter.tsx seeds the input on open by calling buildUserReadableQueryString and buildSubstitutionsMap without passing bankAccountList. inside SearchQueryUtils.getDisplayValue, the BANK_ACCOUNT branch looks up bankAccountList?.[filterValue] and falls back to the raw ID when bankAccountList is undefined. add useOnyx(ONYXKEYS.BANK_ACCOUNT_LIST) and pass it to both calls so the resolver finds the account and renders Bank xx<last4>.

every other buildUserReadableQueryString caller (SearchAutocompleteList, useSavedSearchTitles, SearchSavePage, etc) already passes bankAccountList. this site was missed.

Fixed Issues

$ #94967
PROPOSAL: N/A (deploy blocker, no proposal required)

Tests

Open NewDot.
Make sure your workspace has a business bank account.
Open search.
Type bank-account:.
Select bank-account:"Bank xx<last4>" from the autocomplete suggestion.
Press Enter.
Open the search bar again.
Verify the search query stays as bank-account:"Bank xx<last4>" and does NOT change to the raw ID.

Verify that no errors appear in the JS console

Offline tests

Same as Tests. The fix uses an existing Onyx subscription that already runs offline.

QA Steps

Same as Tests.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

…g and buildSubstitutionsMap so reopen renders bank label not raw ID

melvin-bot · 2026-06-30T14:52:50Z

@Eskalifer1 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Eskalifer1 · 2026-06-30T15:13:10Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

2026-06-30.18.23.42.mov

Eskalifer1

It seems like this is more of an edge case than a regression caused by the original PR (I'd even say it's hard to classify it as a regression specific to that PR).

This happened because a separate PR updated the SearchRouter logic by introducing an initial state for search. That PR was merged two days after the original PR with the bank account filter had already been approved. As part of that change, a new function call was added where bankAccountList wasn't passed, which introduced this issue.

Approved!

[CP Staging] Fix bank account label not showing in search bar after reopen (cherry picked from commit 32a22f9) (cherry-picked to staging by Beamanator)

OSBotify · 2026-06-30T15:44:19Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-06-30T15:58:51Z

🚧 JS00001 has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-06-30T16:07:06Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #94987.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-32a22f9b823-795008f-1cbcdb5e67eb82aa175f5612f2ba61d2ca799c33/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-32a22f9-795008f-aa39cb7078ae5885b313ea4583dd685a9d267bee/index.html

Web 🕸️
https://94987.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-06-30T16:15:38Z

🚀 Cherry-picked to staging by https://github.com/Beamanator in version: 9.4.25-1 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-07-01T19:46:39Z

🚀 Deployed to production by https://github.com/cristipaval in version: 9.4.25-2 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android

OSBotify · 2026-07-01T20:14:28Z

🚀 Cherry-picked to staging by https://github.com/Beamanator in version: 9.4.26-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MelvinBot · 2026-07-01T20:17:27Z

🤖 Help site review: no changes required.

This PR is a targeted bug fix, not a behavior or feature change. It adds a missing useOnyx(ONYXKEYS.BANK_ACCOUNT_LIST) subscription and passes bankAccountList into buildUserReadableQueryString / buildSubstitutionsMap in SearchRouter.tsx so the search bar renders the friendly bank-account:"Bank xx<last4>" label instead of the raw account ID when reopened.

It restores the already-intended display behavior — it doesn't introduce, remove, or alter any documented feature, operator, or UI copy.

Why no docs update

The only related help article, Use Search Operators to Filter and Analyze, documents the search operators and autocomplete behavior generally. Nothing in it describes the specific label-rendering that this PR fixes, and the fix doesn't change the documented operator set or syntax.
No user-facing copy, feature name, tab, setting, or button was added or renamed, so there is nothing in App/docs/articles to update.

Since no help site changes are required, I did not create a draft PR. If you believe a documentation change is warranted, reply with the specific behavior you'd like documented and I'll draft it.

@allgandalf, please confirm you agree no help site changes are needed here.

OSBotify · 2026-07-06T15:32:33Z

🚀 Deployed to production by https://github.com/grgia in version: 9.4.27-2 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android

Pass bankAccountList through SearchRouter buildUserReadableQueryStrin…

b097fbd

…g and buildSubstitutionsMap so reopen renders bank label not raw ID

allgandalf requested review from a team as code owners June 30, 2026 14:52

melvin-bot Bot assigned allgandalf Jun 30, 2026

melvin-bot Bot requested review from Eskalifer1 and JmillsExpensify and removed request for a team June 30, 2026 14:52

allgandalf mentioned this pull request Jun 30, 2026

[Due for payment 2026-07-08] Search - Bank account changes to ID in search field #94967

Closed

7 tasks

JS00001 approved these changes Jun 30, 2026

View reviewed changes

allgandalf changed the title ~~Fix bank account label not showing in search bar after reopen (DeployBlockerCash #94967)~~ [CP Staging] Fix bank account label not showing in search bar after reopen Jun 30, 2026

allgandalf added the CP Staging marks PRs that have been CP'd to staging label Jun 30, 2026

Eskalifer1 approved these changes Jun 30, 2026

View reviewed changes

melvin-bot Bot requested a review from JS00001 June 30, 2026 15:27

JS00001 merged commit 32a22f9 into Expensify:main Jun 30, 2026
36 of 37 checks passed

OSBotify mentioned this pull request Jun 30, 2026

Deploy Checklist: New Expensify 2026-06-30 #94951

Closed

60 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[CP Staging] Fix bank account label not showing in search bar after reopen - #94987

[CP Staging] Fix bank account label not showing in search bar after reopen#94987
JS00001 merged 1 commit into
Expensify:mainfrom
allgandalf:fix-search-router-bank-label

allgandalf commented Jun 30, 2026

Uh oh!

melvin-bot Bot commented Jun 30, 2026

Uh oh!

Eskalifer1 commented Jun 30, 2026 •

edited

Loading

Uh oh!

Eskalifer1 left a comment

Uh oh!

Uh oh!

OSBotify commented Jun 30, 2026

Uh oh!

github-actions Bot commented Jun 30, 2026

Uh oh!

github-actions Bot commented Jun 30, 2026

Uh oh!

OSBotify commented Jun 30, 2026

Uh oh!

OSBotify commented Jul 1, 2026

Uh oh!

OSBotify commented Jul 1, 2026

Uh oh!

MelvinBot commented Jul 1, 2026

Uh oh!

OSBotify commented Jul 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

allgandalf commented Jun 30, 2026

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Jun 30, 2026

Uh oh!

Eskalifer1 commented Jun 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Eskalifer1 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Jun 30, 2026

Uh oh!

github-actions Bot commented Jun 30, 2026

Uh oh!

github-actions Bot commented Jun 30, 2026

Uh oh!

OSBotify commented Jun 30, 2026

Uh oh!

OSBotify commented Jul 1, 2026

Uh oh!

OSBotify commented Jul 1, 2026

Uh oh!

MelvinBot commented Jul 1, 2026

Uh oh!

OSBotify commented Jul 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Eskalifer1 commented Jun 30, 2026 •

edited

Loading