[No QA] Fire searchForTodos request after OpenApp/ReconnectApp by s77rt · Pull Request #94858 · Expensify/App

s77rt · 2026-06-29T14:41:15Z

Explanation of Change

Call searchForTodos api after OpenApp/ReconnectApp
This is needed to compensate for the data that is no longer returned by OpenApp/ReconnectApp

Removed todo search calls in useYourSpendData
This is no longer needed since the searchForTodos would be enough

Fixed race condition that caused full reconnectApp
This onyx callback for nvp_reconnectAppIfFullReconnectBefore may resolve first and if so we will still have lastFullReconnectTime being empty, this would cause a full reconnect even though the real lastFullReconnectTime value is not behind. I have fixed this by reading the value fresh in a nested onyx connector (making them in series instead of parallel)

Fixed Issues

$ #94674
PROPOSAL:

Tests

Logout
Login
Verify after OpenApp request there is a SearchForTodos request
Refresh page
Verify after ReconnectApp request there is a SearchForTodos request
Go to Troubleshoot and click on "Clear cache and restart"
Verify after OpenApp request there is a SearchForTodos request

Screen.Recording.2026-07-01.at.11.26.26.PM.mov

Verify that no errors appear in the JS console

Offline tests

Same as Tests

QA Steps

n/a

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

…es true

melvin-bot · 2026-06-29T16:56:20Z

@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d25baa8012

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

This reverts commit 1d3b573.

This reverts commit 5843c8a.

s77rt · 2026-06-29T19:57:53Z

TS failure seems on main, not sure about the failing tests. Eitherway this is good for review and I will merge main later

adhorodyski · 2026-07-06T10:10:36Z

+    callback: (serverReconnectCutoffOnyxValue) => {
+        serverReconnectCutoff = serverReconnectCutoffOnyxValue ?? '';
+        if (serverReconnectCutoff) {
+            const connection = Onyx.connectWithoutView({


as much as this is rather a move, can you make sure we keep SEQUENTIAL_QUEUE.md up to date and it does not break what's already in there?

This does not change how the sequential queue works, this only defers making an onyx connection to be after the first connection is resolved so we are guaranteed fresh up-to-date data.

Without the fix, as sonn as this connection resolves we will call doFullReconnectIfNecessary and we may pass a stale lastFullReconnectTime

s77rt · 2026-07-06T21:07:01Z

@shubham1206agra The BE PR hit staging, you should be able to review/test

shubham1206agra · 2026-07-07T17:31:14Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Screen.Recording.2026-07-07.at.10.59.35.PM.mov

mountiny · 2026-07-07T18:24:11Z

Putting it on HOLD as we should only merge this once the web PR hits prod

luacmartins · 2026-07-08T21:48:43Z

Web-E PR is on prod. @s77rt can you resolve conflicts please?

s77rt · 2026-07-09T02:53:18Z

Resolved conflicts

s77rt · 2026-07-09T03:07:54Z

Failing tests are on main. Being fixed in #95654

mountiny · 2026-07-09T11:37:51Z

@s77rt can you sync again please

s77rt · 2026-07-09T12:10:10Z

Merged main

github-actions · 2026-07-09T21:12:34Z

🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-07-09T21:26:06Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #94858.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-eb8054c3b84-3474d75-371e077758e988cb7eb92b54e959528b4559b062/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-eb8054c-3474d75-da359743d35c26d027c88c58f3275806767fbd30/index.html

Web 🕸️
https://94858.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-07-10T16:18:08Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.4.33-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	cancelled 🔪

MelvinBot · 2026-07-10T16:20:40Z

🤖 I reviewed the changes in this PR against Expensify's help site articles under docs/articles.

No help site changes are required. These changes are internal data-loading plumbing with no user-facing impact:

src/libs/API/types.ts — registers the new SearchForTodos read command
src/libs/actions/App.ts — fires SearchForTodos after OpenApp/ReconnectApp to compensate for data no longer returned by those calls
src/libs/subscribeToFullReconnect.ts — fixes a race condition that caused an unnecessary full reconnect
src/pages/home/YourSpendSection/useYourSpendData.ts — removes now-redundant todo search calls

Nothing here changes any feature name, tab, setting, button label, pricing, workflow, or otherwise user-visible behavior (the PR is also marked [No QA]). Since the help site documents user-facing product behavior, there's nothing to update.

No draft PR was created because no documentation update is warranted. If you believe a specific article should reflect something here, let me know which one and I'll take another look.

OSBotify · 2026-07-14T11:16:16Z

🚀 Deployed to production by https://github.com/lakchote in version: 9.4.33-8 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android

s77rt added 4 commits June 29, 2026 13:30

add getVisibleTodoSearches

2a53dd2

use getVisibleTodoSearches in useYourSpendData

4eb73d9

Merge branch 'main' into search-after-openapp

7c99d7d

add loadPostDataForOpenOrReconnect

18c1960

melvin-bot Bot assigned s77rt Jun 29, 2026

s77rt added 4 commits June 29, 2026 16:46

Merge branch 'main' into search-after-openapp

89376d4

fire post data requests after OpenApp/ReconnectApp

ef2aed4

fire loadPostDataForOpenOrReconnect requests after hasLoadedApp becom…

4b18b37

…es true

Merge branch 'main' into search-after-openapp

d25baa8

s77rt marked this pull request as ready for review June 29, 2026 16:56

s77rt requested review from a team as code owners June 29, 2026 16:56

melvin-bot Bot requested review from flaviadefaria and shubham1206agra and removed request for a team June 29, 2026 16:56

s77rt changed the title ~~Fire searchs requests after OpenApp/ReconnectApp~~ [No QA] Fire searchs requests after OpenApp/ReconnectApp Jun 29, 2026

s77rt mentioned this pull request Jun 29, 2026

[Due for payment 2026-07-21] Action badges missing until Home page / search is opened (OpenApp no longer returns the underlying report actions) #94674

Open

s77rt changed the title ~~[No QA] Fire searchs requests after OpenApp/ReconnectApp~~ [No QA] Fire search requests after OpenApp/ReconnectApp Jun 29, 2026

s77rt requested a review from luacmartins June 29, 2026 16:57

chatgpt-codex-connector Bot reviewed Jun 29, 2026

View reviewed changes

Comment thread src/libs/actions/App.ts Outdated

github-actions Bot reviewed Jun 29, 2026

View reviewed changes

Comment thread src/libs/actions/App.ts Outdated

s77rt added 6 commits June 29, 2026 18:44

add getTodoSearches

5843c8a

fire all 4 Todos search requests

1d3b573

Revert "fire all 4 Todos search requests"

786501b

This reverts commit 1d3b573.

Revert "add getTodoSearches"

13b151b

This reverts commit 5843c8a.

use another onyx connector before firing searh

2792c8f

Merge branch 'main' into search-after-openapp

f26074d

adhorodyski reviewed Jul 6, 2026

View reviewed changes

s77rt added 3 commits July 6, 2026 12:19

clean up - use early return

18f3ca1

Merge branch 'main' into search-after-openapp

f32a784

break import cycle - fix tests

a765831

s77rt changed the title ~~[Hold Web-E#54169] [No QA] Fire searchForTodos request after OpenApp/ReconnectApp~~ [No QA] Fire searchForTodos request after OpenApp/ReconnectApp Jul 6, 2026

shubham1206agra approved these changes Jul 7, 2026

View reviewed changes

mountiny changed the title ~~[No QA] Fire searchForTodos request after OpenApp/ReconnectApp~~ [HOLD] [No QA] Fire searchForTodos request after OpenApp/ReconnectApp Jul 7, 2026

mountiny reviewed Jul 7, 2026

View reviewed changes

Comment thread src/libs/subscribeToFullReconnect.ts

merge main

784367c

s77rt added 2 commits July 9, 2026 03:58

explain why chained connection is needed

20ec499

Merge branch 'main' into search-after-openapp

dee7422

Merge branch 'main' into search-after-openapp

6c79d35

s77rt changed the title ~~[HOLD] [No QA] Fire searchForTodos request after OpenApp/ReconnectApp~~ [No QA] Fire searchForTodos request after OpenApp/ReconnectApp Jul 9, 2026

luacmartins approved these changes Jul 9, 2026

View reviewed changes

mountiny approved these changes Jul 9, 2026

View reviewed changes

mountiny merged commit eb8054c into Expensify:main Jul 9, 2026
36 checks passed

OSBotify mentioned this pull request Jul 10, 2026

Deploy Checklist: New Expensify 2026-07-10 #95814

Closed

86 tasks

Uh oh!

Conversation

s77rt commented Jun 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Jun 29, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

s77rt commented Jun 29, 2026

Uh oh!

adhorodyski Jul 6, 2026

Choose a reason for hiding this comment

Uh oh!

s77rt Jul 6, 2026

Choose a reason for hiding this comment

Uh oh!

s77rt commented Jul 6, 2026

Uh oh!

shubham1206agra commented Jul 7, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

mountiny commented Jul 7, 2026

Uh oh!

luacmartins commented Jul 8, 2026

Uh oh!

s77rt commented Jul 9, 2026

Uh oh!

s77rt commented Jul 9, 2026

Uh oh!

mountiny commented Jul 9, 2026

Uh oh!

s77rt commented Jul 9, 2026

Uh oh!

Uh oh!

github-actions Bot commented Jul 9, 2026

Uh oh!

github-actions Bot commented Jul 9, 2026

Uh oh!

OSBotify commented Jul 10, 2026

Uh oh!

MelvinBot commented Jul 10, 2026

Uh oh!

OSBotify commented Jul 14, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

s77rt commented Jun 29, 2026 •

edited

Loading