Fix workspace LHN order: Receipt Partners before HR#94798
Conversation
Co-authored-by: huult <huult@users.noreply.github.com>
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
@MelvinBot Please mark it ready and we can remove the comments within the Tests and QA Steps section since the use case is related to the offline scenario. Also, please check all the PR Author checklist items. |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-06-29.at.10.19.03.mp4Android: mWeb ChromeScreen.Recording.2026-06-29.at.10.19.55.mp4iOS: HybridAppScreen.Recording.2026-06-29.at.10.22.47.mp4iOS: mWeb SafariScreen.Recording.2026-06-29.at.10.23.34.mp4MacOS: Chrome / SafariScreen.Recording.2026-06-29.at.10.11.51.mov |
|
We did not find an internal engineer to review this PR, trying to assign a random engineer to #94576 as well as to this PR... Please reach out for help on Slack if no one gets assigned! |
|
@madmax330 all yours 🙏 |
|
🚧 madmax330 has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/madmax330 in version: 9.4.26-0 🚀
|
|
🤖 I reviewed the changes in this PR against Expensify's help site files under No help site changes are required. This PR only swaps the display order of two existing workspace menu items — Receipt partners and HR — in the workspace left-hand menu so it matches the ordering shown on the More Features page (Accounting → Receipt partners → HR). No feature names, setting labels, tab names, buttons, navigation paths, or behaviors change. The help articles that reference these features (e.g. |
|
🚀 Deployed to production by https://github.com/grgia in version: 9.4.27-2 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
In the workspace LHN, the Receipt Partners and HR menu items appeared in the opposite relative order from the More Features page:
The LHN list is built by sequential
workspaceMenuItems.push(...)calls, so array/insertion order is the render order. The HR block was pushed before the Receipt Partners block, producing the mismatch.This change swaps the two
pushblocks inWorkspaceInitialPage.tsxso Receipt Partners is pushed before HR, making the LHN order (Accounting → Receipt Partners → HR) match the More Features Integrate section. Each block keeps its own feature gate (ARE_RECEIPT_PARTNERS_ENABLED/IS_HR_ENABLED), icon, brick-road indicator, route, sentry label, and highlight logic unchanged — only their relative position changes.Fixed Issues
$ #94576
PROPOSAL: #94576 (comment)
Tests
Offline tests
Same as tests.
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)Avatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari