Remove allReportActions usage from deleteAppReport by bernhardoj · Pull Request #94769 · Expensify/App

bernhardoj · 2026-06-27T09:49:47Z

Explanation of Change

Fixed Issues

$ #73651
PROPOSAL:

Tests

Same as QA Steps

Verify that no errors appear in the JS console

Offline tests

Same as QA Steps

QA Steps

A.

Create multiple expenses in a workspace chat (if you don't have)
Open the report
Turn off the internet connection
Delete the report
Verify the report preview is pending delete
Go to self DM
Verify the deleted expense moved to self DM

B.

Create multiple expenses in a workspace chat (if you don't have)
Open the report to load all actions and then go back
Turn off the internet connection
Right-click the report preview and delete the report
Verify the report preview is pending delete
Go to self DM
Verify the deleted expense moved to self DM

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

b.mp4

melvin-bot · 2026-06-27T09:49:53Z

@eVoloshchak Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2026-06-27T09:49:59Z

@luacmartins Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: eccb46ed68

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-06-27T09:54:06Z

            deleteAppReport({
                report: childReport,
+                reportActions: childReportActions,
+                parentReportAction,


Pass the child report's preview action

When deleting a report preview from this menu, report is the parent chat and childReport is the expense report being deleted. Looking up useParentReportAction(report) therefore returns the parent action of the chat (usually undefined) instead of the preview action referenced by childReport.parentReportActionID; deleteAppReport then only sets pendingAction and cannot add message.deleted, which its own logic notes is required because isDeletedAction ignores pendingAction. This leaves the stale preview/action badge when right-click deleting a report preview offline.

Useful? React with 👍 / 👎.

codecov · 2026-06-27T11:47:06Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/libs/actions/Report/index.ts	`70.68% <100.00%> (-0.09%)`	⬇️
...ort/ContextMenu/PopoverReportActionContextMenu.tsx	`44.29% <100.00%> (+0.49%)`	⬆️
src/hooks/useExpenseActions.ts	`0.00% <0.00%> (ø)`
src/hooks/useSearchBulkActions.ts	`53.65% <25.00%> (-0.47%)`	⬇️
... and 7 files with indirect coverage changes

JmillsExpensify

No product review required imo.

eVoloshchak · 2026-06-29T07:27:46Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

screen-20260629-101602-1782720946786.mp4

Android: mWeb Chrome

Screen.Recording.2026-06-29.at.10.28.32.mov

iOS: HybridApp

Screen.Recording.2026-06-29.at.10.08.50.mov

iOS: mWeb Safari

Screen.Recording.2026-06-29.at.10.11.39.mov

MacOS: Chrome / Safari

Screen.Recording.2026-06-29.at.09.43.12.mov

eVoloshchak

LGTM!

luacmartins

LGTM

github-actions · 2026-06-29T15:00:05Z

🚧 luacmartins has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-06-29T15:18:29Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #94769.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-783e0dea612-0f1cc02-33452aa9981e722cc91afcaefeadb33f5bc5dcaa/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-783e0de-0f1cc02-201ae6726a83e6a175740d7451beb673f003976a/index.html

Web 🕸️
❌ FAILED ❌
The QR code can't be generated, because the Web build failed

👀 View the workflow run that generated this build 👀

OSBotify · 2026-06-30T12:07:16Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 9.4.25-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-07-01T19:46:03Z

🚀 Deployed to production by https://github.com/cristipaval in version: 9.4.25-2 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android

bernhardoj added 3 commits June 27, 2026 17:20

remove allReportActions usage from deleteAppReport

83cc5e3

remove log

cf42003

pass the child report actions

eccb46e

bernhardoj requested review from a team as code owners June 27, 2026 09:49

melvin-bot Bot assigned bernhardoj Jun 27, 2026

melvin-bot Bot requested review from JmillsExpensify and eVoloshchak and removed request for a team June 27, 2026 09:49

melvin-bot Bot requested review from a team and luacmartins and removed request for a team June 27, 2026 09:49

chatgpt-codex-connector Bot reviewed Jun 27, 2026

View reviewed changes

bernhardoj added 3 commits June 27, 2026 19:37

pass the child report's preview action

89450bf

lint

b34e549

fix test

e77146f

bernhardoj added 3 commits June 27, 2026 21:12

lint

ce41807

Merge branch 'main' into 73651-refactor-report-actions-to-use-useonyx-6

f41be4b

fix lint

3f7817f

JmillsExpensify reviewed Jun 28, 2026

View reviewed changes

eVoloshchak approved these changes Jun 29, 2026

View reviewed changes

luacmartins approved these changes Jun 29, 2026

View reviewed changes

luacmartins merged commit 783e0de into Expensify:main Jun 29, 2026
34 of 35 checks passed

OSBotify mentioned this pull request Jun 30, 2026

Deploy Checklist: New Expensify 2026-06-30 #94951

Closed

60 tasks

melvin-bot Bot mentioned this pull request Jul 1, 2026

Remove Onyx.connect() for the key: ONYXKEYS.COLLECTION.REPORT_ACTIONS in src/libs/actions/Report.ts #73651

Open

Uh oh!

Conversation

bernhardoj commented Jun 27, 2026

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Jun 27, 2026

Uh oh!

melvin-bot Bot commented Jun 27, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Jun 27, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

codecov Bot commented Jun 27, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

JmillsExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

eVoloshchak commented Jun 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

eVoloshchak left a comment

Choose a reason for hiding this comment

Uh oh!

luacmartins left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Jun 29, 2026

Uh oh!

github-actions Bot commented Jun 29, 2026

Uh oh!

OSBotify commented Jun 30, 2026

Uh oh!

OSBotify commented Jul 1, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

codecov Bot commented Jun 27, 2026 •

edited by github-actions Bot

Loading

eVoloshchak commented Jun 29, 2026 •

edited

Loading