Docs updates for E/A#94124 add Posted and Original amount report columns#94500
Draft
MelvinBot wants to merge 1 commit into
Draft
Docs updates for E/A#94124 add Posted and Original amount report columns#94500MelvinBot wants to merge 1 commit into
MelvinBot wants to merge 1 commit into
Conversation
…list Co-authored-by: ahmedGaber93 <ahmedGaber93@users.noreply.github.com>
43 tasks
| - Workspace violations (if applicable) | ||
|
|
||
| Additional columns such as **Attendees** and **Per attendee** can be enabled via the **Columns** picker when attendee tracking is available. | ||
| Additional columns such as **Posted**, **Attendees**, **Per attendee**, and **Original amount** can be enabled via the **Columns** picker. **Attendees** and **Per attendee** appear when attendee tracking is available, **Posted** shows when the expense has a posting date, and **Original amount** shows when the expense was converted from another currency. |
Contributor
There was a problem hiding this comment.
@twisterdotcom, coming from #93522, I don’t believe we need those columns here. Could you please confirm?
Contributor
There was a problem hiding this comment.
I don’t believe we need those columns here
Why not @ahmedGaber93? The point of adding them is that they show everywhere.
Contributor
There was a problem hiding this comment.
Why not?
@twisterdotcom I think Attendees and Per attendee is just examples, not a complete list.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this change
PR Expensify/App#94124 unified the two expense column pickers and added four transaction-level columns to the single-report Columns picker (
r/:reportID/settings/columns): Posted, Attendees, Per attendee, and Original amount (Report Details went from 18 → 22 columns).The help article Managing Expenses in a Report previously listed only Attendees and Per attendee as additional columns available in that picker.
What changed
Updated the "How to view and use the expense table" section to list all four columns now available in the single-report Columns picker, with the condition under which each renders:
Column names use the exact UI labels verified against
src/languages/en.ts.Scope
@ahmedGaber93, please review the files changed and confirm they reflect the current behavior. Then mark this PR
Ready for review.