83865 migrate workspace workflows members#94482
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e5c5061b76
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Hello @blimpich, regarding #59070 (comment), I'd like to test the cc @mjasikowski |
Manual test cases based on current code changeA —
|
Please have the assigned CME setup an account for you to test. I wrote a stack overflow here for how to setup a local test account on an internal engineer's backend: https://stackoverflowteams.com/c/expensify/questions/23797/23798#23798 |
…pace-workflows-members
…pace-workflows-members
|
@mjasikowski When you’re back, could you help set this up: #94482 (comment)? I need to verify the WORKSPACE_PAY_AND_DOWNGRADE case. |
31c0f16 to
fbaca16
Compare
…pace-workflows-members
…pace-workflows-members
suneox
left a comment
There was a problem hiding this comment.
I'll update pr checklist soon
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / SafariManual test cases — #83865 [BT-143] → PR #94482Lean English version of
A —
|
…pace-workflows-members
Screen.Recording.2026-07-02.at.15.29.27.movThe issue where the page reloads and shows the crash page has been fixed. For the first issue, where the page shows a "Not Found" page, I can't reproduce it. Do we have any specific preconditions to reproduce it? |
…pace-workflows-members






















Explanation of Change
Fixed Issues
$ #83865
PROPOSAL:
Tests
Same QA step
Offline tests
QA Steps
WORKSPACE_WORKFLOWS_APPROVALS_EXPENSES_FROM
From Workflows list
From New approval confirm page
From Edit approval page
WORKSPACE_PAY_AND_DOWNGRADE
Precondition:
Navigation from workspace profile
Navigation from workspaces list
WORKSPACE_OWNER_CHANGE_SUCCESS
Precondition: Add a member to the workspace as an admin.
WORKSPACE_OWNER_CHANGE_CHECK
Precondition: Add a member to the workspace as an admin.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
WORKSPACE_WORKFLOWS_APPROVALS_EXPENSES_FROM
Screen.Recording.2026-06-25.at.10.41.08.mov
Screen.Recording.2026-06-25.at.13.57.21.mov