[Performance] Resolve `destinationReportID` before confirmation mount in global-create by JakubKorytko · Pull Request #94459 · Expensify/App

JakubKorytko · 2026-06-24T13:27:37Z

Explanation of Change

Fix single-screen global-create flows (workspace expenses, self-DM tracking) where transaction.reportID was undefined at Confirmation mount time, causing the pre-insert effect to miss its window. Extracted resolveEarlyReportID in useResetIOUType to set transaction.reportID immediately after initMoneyRequest. Also reset hasPreInsertFired in the pre-insert cleanup so it can re-fire when destinationReportID transitions from undefined to a valid value.

Sentry Evidence

Note: This bug only affects the NEW_MANUAL_EXPENSE_FLOW beta (single-screen amount + confirmation). The old multi-step flow is unaffected.

This is a regression introduced by the single-screen manual flow change (IOURequestStartPage now renders IOURequestStepConfirmation directly on the Manual tab). The old multi-step flow used AmountSubmission.ts which called setTransactionReport before navigation to confirmation:

// AmountSubmission.ts (old flow - no longer runs for manual tab)
setTransactionReport(transactionID, {reportID: transactionReportID}, true);

With the single-screen flow, this call is bypassed entirely. The embedded confirmation screen resolves default participants via useDefaultParticipants but never calls setTransactionReport for workspace participants. This causes destinationReportID to be undefined at first render, the pre-insert effect fires with no destination, and subsequent setTransactionReport triggers a cleanup that removes the pre-insert without replacement (because hasPreInsertFired stays true).

The impact contributes to the ~56% DEFAULT handler rate observed in Sentry (5.2k default vs 4k non-default in 24h).

Fixed Issues

$ #94462
PROPOSAL: N/A

Tests

Prerequisites: Enable the NEW_MANUAL_EXPENSE_FLOW beta. Use a narrow viewport (mobile device or resize browser to mobile width) - the pre-insert optimization this PR fixes only applies on narrow layout.

Open the app from any tab (Home, Spend, etc.) and tap the global FAB
Tap "Create expense", select a workspace as the recipient, fill in the amount and details, then submit
Verify [Sentry][ManualSubmitToDestinationVisible] Ending span appears in the console with a sub-two-second duration and fast_path_handler is NOT default
Verify the submit feels smooth - no jarring navigation jump after tapping Submit (the destination loads behind the modal before it dismisses)

Repeat the above but select yourself as the recipient (this creates a Track expense to your self-DM)
Verify the same smooth behavior - span ends sub-two-seconds, no navigation flash

Open an existing chat and tap the "+" button to create an expense from within that chat
Fill in the details and submit
Verify the behavior is unchanged - the expense posts to the same chat without any unexpected navigation

Offline tests

N/A

QA Steps

Same as tests

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS.mov

iOS: mWeb Safari

MacOS: Chrome / Safari

Web.mov

…y change

JakubKorytko · 2026-06-24T13:27:45Z

@codex review

chatgpt-codex-connector · 2026-06-24T13:32:06Z

Codex Review: Didn't find any major issues. 🚀

Reviewed commit: 7340be7108

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

codecov · 2026-06-24T13:34:26Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/hooks/useResetIOUType.ts	`97.36% <100.00%> (+0.30%)`	⬆️
src/libs/IOUUtils.ts	`76.75% <100.00%> (+0.73%)`	⬆️
...es/iou/request/step/IOURequestStepConfirmation.tsx	`63.55% <0.00%> (-1.63%)`	⬇️
... and 71 files with indirect coverage changes

JakubKorytko · 2026-06-25T10:19:08Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 13dbc80987

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

JakubKorytko · 2026-06-25T11:28:19Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2f7329220f

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

JakubKorytko · 2026-06-25T12:22:05Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: cc96f1cdce

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

JakubKorytko · 2026-06-25T12:47:33Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 15318823b4

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

JakubKorytko · 2026-06-25T12:59:32Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 15318823b4

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

JakubKorytko · 2026-06-25T13:15:52Z

@codex review

chatgpt-codex-connector · 2026-06-25T13:21:48Z

Codex Review: Didn't find any major issues. Breezy!

Reviewed commit: 90dd130b67

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

melvin-bot · 2026-06-25T13:22:22Z

@dmkt9 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

dmkt9 · 2026-06-26T04:39:08Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

chrome.mp4

dmkt9

LGTM

mountiny

Thanks!

github-actions · 2026-06-26T10:49:34Z

🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here.

OSBotify · 2026-06-26T10:54:27Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-06-26T10:57:11Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #94459.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-b1ea306f924-27a47d6-06048e2c665b2703fba72549cab52a8fe26622c0/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-b1ea306-27a47d6-ee4d785f142bddcbfd4fe470126bb5db5e50b773/index.html

Web 🕸️
https://94459.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-06-26T20:01:03Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.4.21-2 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

kavimuru · 2026-06-26T20:07:18Z

@JakubKorytko @mountiny

Is applause.expensifail.com domain is beta enabled?

Enable the NEW_MANUAL_EXPENSE_FLOW beta.

JakubKorytko · 2026-06-26T20:56:11Z

You can easily check that, try to create pretty much any expense via FAB (but not QAB) - if you see amount as a separate full RHP page then the answer is no. If you fill the amount on the same page as other details (category, merchant) then yes, beta is enabled.

OSBotify · 2026-06-29T12:37:49Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.4.21-9 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android

JakubKorytko added 5 commits June 24, 2026 10:26

fix: set transaction reportID early in useResetIOUType for global-create

94e4e14

fix: reset hasPreInsertFired on cleanup to allow re-fire on dependenc…

f7f394c

…y change

test: add tests for early reportID resolution in useResetIOUType

d4357f0

refactor: extract resolveEarlyReportID as testable pure function

692904c

refactor: move resolveEarlyReportID to IOUUtils

7340be7

melvin-bot Bot assigned JakubKorytko Jun 24, 2026

mountiny mentioned this pull request Jun 24, 2026

[Due for payment 2026-07-06] [WIP] [Performance] Resolve destinationReportID before confirmation mount in global-create #94462

Closed

JakubKorytko added 3 commits June 25, 2026 10:28

Merge branch 'main' into korytko/fix-single-screen-reportid-regression

56a7467

fix: self-dms, beta inbox

13dbc80

fix: stale pre-inserted flag

689d6ab

JakubKorytko changed the title ~~[WIP] [Performance] Resolve destinationReportID before confirmation mount in global-create~~ [Performance] Resolve destinationReportID before confirmation mount in global-create Jun 25, 2026

chatgpt-codex-connector Bot reviewed Jun 25, 2026

View reviewed changes

Comment thread src/pages/iou/request/step/IOURequestStepConfirmation.tsx Outdated

guard splits

2f73292

chatgpt-codex-connector Bot reviewed Jun 25, 2026

View reviewed changes

Comment thread src/hooks/useResetIOUType.ts

resolve earlyReportID earlier

cc96f1c

chatgpt-codex-connector Bot reviewed Jun 25, 2026

View reviewed changes

Comment thread src/pages/iou/request/step/IOURequestStepConfirmation.tsx Outdated

fix: reportID fallback

1531882

chatgpt-codex-connector Bot reviewed Jun 25, 2026

View reviewed changes

Comment thread src/pages/iou/request/step/IOURequestStepConfirmation.tsx Outdated

chatgpt-codex-connector Bot reviewed Jun 25, 2026

View reviewed changes

Comment thread src/pages/iou/request/step/IOURequestStepConfirmation.tsx Outdated

fix: self-dms on search

90dd130

JakubKorytko marked this pull request as ready for review June 25, 2026 13:22

JakubKorytko requested review from a team as code owners June 25, 2026 13:22

melvin-bot Bot requested review from dmkt9 and heyjennahay and removed request for a team June 25, 2026 13:22

melvin-bot Bot removed the request for review from a team June 25, 2026 13:22

dmkt9 approved these changes Jun 26, 2026

View reviewed changes

melvin-bot Bot requested a review from mountiny June 26, 2026 08:09

mountiny requested changes Jun 26, 2026

View reviewed changes

Comment thread src/libs/IOUUtils.ts

mountiny approved these changes Jun 26, 2026

View reviewed changes

Comment thread src/libs/IOUUtils.ts

mountiny merged commit b1ea306 into Expensify:main Jun 26, 2026
40 checks passed

OSBotify mentioned this pull request Jun 26, 2026

Deploy Checklist: New Expensify 2026-06-26 #94730

Closed

55 tasks

Uh oh!

Conversation

JakubKorytko commented Jun 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Sentry Evidence

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

JakubKorytko commented Jun 24, 2026

Uh oh!

chatgpt-codex-connector Bot commented Jun 24, 2026

Uh oh!

codecov Bot commented Jun 24, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

JakubKorytko commented Jun 25, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

JakubKorytko commented Jun 25, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

JakubKorytko commented Jun 25, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

JakubKorytko commented Jun 25, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

JakubKorytko commented Jun 25, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

JakubKorytko commented Jun 25, 2026

Uh oh!

chatgpt-codex-connector Bot commented Jun 25, 2026

Uh oh!

melvin-bot Bot commented Jun 25, 2026

Uh oh!

dmkt9 commented Jun 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

dmkt9 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Jun 26, 2026

Uh oh!

OSBotify commented Jun 26, 2026

Uh oh!

JakubKorytko commented Jun 24, 2026 •

edited

Loading

codecov Bot commented Jun 24, 2026 •

edited by github-actions Bot

Loading

dmkt9 commented Jun 26, 2026 •

edited

Loading