[GPS] Add custom compass to GPSMapView#94284
Conversation
|
@dukenv0307 do you want to review as this is part of GPS project and a follow-up to PRs you reviewed? |
|
Rerunning test which passes locally and should not fail by changes added on this PR |
|
Please tag me if a review is needed. |
|
I'll review it since it's my regression |
Not really your regression, we just merged two PRs at the same time where one was adding GPSMapView and the other was adding custom compass to the default MapView which was the only variant at the time and I didn't realise that it would end up like this 😅 |
|
on it now |
|
@codex review |
|
Codex Review: Didn't find any major issues. Bravo. Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
There was a problem hiding this comment.
Good catch, thanks!
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-06-24.at.7.34.01.PM.movAndroid: mWeb ChromeiOS: HybridAppScreen.Recording.2026-06-24.at.7.29.37.PM.moviOS: mWeb SafariMacOS: Chrome / Safari |
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
neil-marcellini
left a comment
There was a problem hiding this comment.
Thanks for this, and for addressing my non blocking comments from before! Looks solid.
|
🚧 neil-marcellini has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/neil-marcellini in version: 9.4.20-0 🚀
|
|
🤖 No help site changes required. I reviewed the changes in this PR and they don't warrant any updates to the help site articles under Why: This is a purely internal/cosmetic UI refactor:
There's no new feature, no change to a documented user flow, and no new setting/label/button that the help site describes. The help site documents how to create distance expenses (e.g. If the team later decides the distance/map UI should be documented in more detail, that would be a separate docs effort rather than something driven by this refactor. @GCyganek — since no documentable behavior changed, I did not create a help site PR, so there's nothing to review or mark |
|
🚀 Deployed to production by https://github.com/blimpich in version: 9.4.20-1 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Extracted the custom compass into a shared
Compasscomponent and added it toGPSMapView, replacing the native Mapbox compass. Also renameduseAnimatedTrailingDirectionCoordinatetouseAnimatedLeadingDirectionCoordinatefor clarity, fixed typo and renamedinterpolateCoordinate()function according to feedback from #91418.Fixed Issues
$ #94265
PROPOSAL: N/A
Tests
Offline tests
N/A
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)Avatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2026-06-23.at.11.00.01.mov
iOS: Native
Screen.Recording.2026-06-23.at.10.55.55.mov