Skip to content

[No QA] Treat existing release as success in deploy create-release retry loop #94213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
blimpich merged 2 commits into from
Jun 26, 2026
Merged

[No QA] Treat existing release as success in deploy create-release retry loop #94213

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d208ede
Treat existing release as success in deploy create-release retry loop
blimpich Jun 22, 2026
37f6957
Clarify create-release retry comment per review feedback
blimpich Jun 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .github/workflows/deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -916,6 +916,12 @@ jobs:
--target "${{ env.DEPLOY_ENV }}"; then
break
fi

# A transient GitHub error during create doesn't necessarily mean the release failed; it may have been created anyway, so a later "already exists" error means it's present.
if gh release view "${{ needs.prep.outputs.TAG }}" --repo "${{ github.repository }}" &> /dev/null; then
echo "Release ${{ needs.prep.outputs.TAG }} exists despite a create error (likely a transient 502), treating as success."
break
fi
if [[ $i -lt $CREATE_MAX_RETRIES ]]; then
echo "Failed to create release. Retrying in 3 seconds... ($((CREATE_MAX_RETRIES - i)) attempts left)"
sleep 3
Expand Down
Loading