perf: stabilize iouReport in MoneyRequestReportPreview by OlimpiaZurek · Pull Request #94188 · Expensify/App

OlimpiaZurek · 2026-06-22T14:51:15Z

Explanation of Change

This PR reduces unnecessary re-renders when sending a message in chats with several expense previews. Each MoneyRequestReportPreview re-subscribed to the linked IOU report, whose churning last* fields re-emit on every send, so the previews re-rendered even though nothing they show changed.

This PR passes the parent's already-stable iouReport (getStableReportSelector) down the preview's render path instead of re-deriving it, so those subscriptions no longer fire on send/

Fixed Issues

$ #93771
PROPOSAL:

Tests

Open a chat with several expense previews and send a message.
Verify the previews don't reflow and still render correctly (carousel, status, Pay/Submit/Approve,
hold menu, loading/empty/access placeholders); confirm Pay/Submit/Approve still work

Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

OlimpiaZurek · 2026-06-24T12:50:06Z

@codex

chatgpt-codex-connector · 2026-06-24T12:56:44Z

Codex Review: Didn't find any major issues. 👍

Reviewed commit: 21ce85a219

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

melvin-bot · 2026-06-24T12:58:05Z

@mananjadhav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 21ce85a219

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-06-24T13:07:21Z

+        (allViolations: OnyxCollection<TransactionViolations>) => transactionViolationsByIDsSelector(transactionIDs)(allViolations),
+        [transactionIDs],
+    );
+    const [transactionViolations] = useOnyx(ONYXKEYS.COLLECTION.TRANSACTION_VIOLATIONS, {selector: selectTransactionViolations});


Refresh violation selector when transaction IDs change

When this preview first mounts with transactions still empty, this useOnyx subscription is created with a selector closed over an empty transactionIDs list, but no dependency array is passed to useOnyx to refresh the subscription after the transactions hydrate. In that common loading path the selected violations stay empty, so compareByRBR falls back to date sorting and expenses with review-required/blocking violations are no longer moved to the front of the carousel (or into the first 10 visible previews) until the row remounts.

Useful? React with 👍 / 👎.

joekaufmanexpensify · 2026-06-24T19:13:30Z

No product review needed

OlimpiaZurek · 2026-06-25T16:24:07Z

@mananjadhav Can you review it? Thanks!

mananjadhav · 2026-06-25T16:27:42Z

I finished with the code review. Now onto testing.

mananjadhav · 2026-06-25T16:34:35Z

@OlimpiaZurek Can you please resolve conflicts?

mananjadhav · 2026-06-25T16:54:29Z

Thanks. Took the latest pull and testing now.

mananjadhav · 2026-06-26T15:13:24Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

mweb-chrome-stabilize-render.mov

iOS: HybridApp

ios-stabilize-render.mov

iOS: mWeb Safari

mweb-safari-stabilize-render.mov

MacOS: Chrome / Safari

web-stabilize-render.mov

mananjadhav

I am having some trouble with my machine memory causing issue with Android builds and the last crash you see on iOS.

But the change tests well.

mountiny · 2026-06-29T12:18:24Z

@OlimpiaZurek Can you please resolve the conflicts? thanks

# Conflicts: # src/components/ReportActionItem/MoneyRequestReportPreview/MoneyRequestReportPreviewContent.tsx

OlimpiaZurek · 2026-06-29T12:40:24Z

@OlimpiaZurek Can you please resolve the conflicts? thanks

Done!

OSBotify · 2026-06-29T13:03:37Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-06-29T14:19:56Z

🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-06-29T14:27:53Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #94188.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-961041c6b08-0f1cc02-33452aa9981e722cc91afcaefeadb33f5bc5dcaa/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-961041c-0f1cc02-201ae6726a83e6a175740d7451beb673f003976a/index.html

Web 🕸️
https://94188.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-06-30T12:06:19Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.4.25-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-07-01T19:45:06Z

🚀 Deployed to production by https://github.com/cristipaval in version: 9.4.25-2 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android

perf: stabilize iouReport in MoneyRequestReportPreview

750a9bb

melvin-bot Bot assigned OlimpiaZurek Jun 22, 2026

OlimpiaZurek changed the title ~~Perf/stabilize iou report preview~~ perf: stabilize iouReport in MoneyRequestReportPreview Jun 22, 2026

OlimpiaZurek mentioned this pull request Jun 22, 2026

[Due for payment 2026-07-21] [$250] [Performance] Investigate SendMessage metric improvements in chats with many MoneyRequestReportPreview #93771

Closed

Merge branch 'main' into perf/stabilize-iou-report-preview

21ce85a

OlimpiaZurek marked this pull request as ready for review June 24, 2026 12:57

OlimpiaZurek requested review from a team as code owners June 24, 2026 12:57

melvin-bot Bot requested review from joekaufmanexpensify and mananjadhav and removed request for a team June 24, 2026 12:58

melvin-bot Bot removed the request for review from a team June 24, 2026 12:58

chatgpt-codex-connector Bot reviewed Jun 24, 2026

View reviewed changes

fix: pass transactionIDs dep

bee4e5d

joekaufmanexpensify removed their request for review June 24, 2026 19:13

mananjadhav mentioned this pull request Jun 25, 2026

perf: narrow reportName selector and stabilize parentReport subscription #94073

Merged

52 tasks

OlimpiaZurek added 2 commits June 25, 2026 18:39

fix conflicts

a543752

revert submodule

c2e6134

mananjadhav approved these changes Jun 26, 2026

View reviewed changes

melvin-bot Bot requested review from cristipaval and mountiny June 26, 2026 19:23

cristipaval previously approved these changes Jun 27, 2026

View reviewed changes

Merge branch 'main' into perf/stabilize-iou-report-preview

4218da2

# Conflicts: # src/components/ReportActionItem/MoneyRequestReportPreview/MoneyRequestReportPreviewContent.tsx

OlimpiaZurek dismissed cristipaval’s stale review via 4218da2 June 29, 2026 12:32

undo submodule

0903ce4

mountiny approved these changes Jun 29, 2026

View reviewed changes

mountiny merged commit 961041c into Expensify:main Jun 29, 2026
33 checks passed

OSBotify mentioned this pull request Jun 30, 2026

Deploy Checklist: New Expensify 2026-06-30 #94951

Closed

60 tasks

Uh oh!

Conversation

OlimpiaZurek commented Jun 22, 2026

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

OlimpiaZurek commented Jun 24, 2026

Uh oh!

chatgpt-codex-connector Bot commented Jun 24, 2026

Uh oh!

melvin-bot Bot commented Jun 24, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Jun 24, 2026

Choose a reason for hiding this comment

Uh oh!

joekaufmanexpensify commented Jun 24, 2026

Uh oh!

OlimpiaZurek commented Jun 25, 2026

Uh oh!

mananjadhav commented Jun 25, 2026

Uh oh!

mananjadhav commented Jun 25, 2026

Uh oh!

mananjadhav commented Jun 25, 2026

Uh oh!

mananjadhav commented Jun 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

mananjadhav left a comment

Choose a reason for hiding this comment

Uh oh!

mountiny commented Jun 29, 2026

Uh oh!

OlimpiaZurek commented Jun 29, 2026

Uh oh!

Uh oh!

OSBotify commented Jun 29, 2026

Uh oh!

github-actions Bot commented Jun 29, 2026

Uh oh!

github-actions Bot commented Jun 29, 2026

Uh oh!

OSBotify commented Jun 30, 2026

Uh oh!

OSBotify commented Jul 1, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

mananjadhav commented Jun 26, 2026 •

edited

Loading