Migrate useSearchSelector.base.ts from useOptionsList to usePersonalDetailOptions (part 5) by hoangzinh · Pull Request #94179 · Expensify/App

hoangzinh · 2026-06-22T13:48:32Z

Explanation of Change

This PR continues the useSearchSelector → usePersonalDetailSearchSelector migration, covering Part 5: WorkspaceWorkflowsApprovalsExpensesFromPage.

Fixed Issues

$ #82191
PROPOSAL:

Tests

Same as QA

Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Enable Workflows for a workspace
Go to workspace settings => Workflows
Tap "Add approval workflow"
Verify that you can find a member in "Expenses from" page

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Screen.Recording.2026-06-22.at.23.03.08.mov

codecov · 2026-06-22T13:53:53Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
...ls/WorkspaceWorkflowsApprovalsExpensesFromPage.tsx	`0.00% <0.00%> (ø)`
... and 77 files with indirect coverage changes

melvin-bot · 2026-06-22T17:19:59Z

@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2026-06-22T17:20:04Z

@mountiny Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

shubham1206agra · 2026-06-22T17:23:09Z

@hoangzinh Can you leave attendees part for now? I want you to actually migrate useSearchSelector hook to use useFilteredOptions internally? That is the part you have to do

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d423ed8d77

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

joekaufmanexpensify · 2026-06-22T21:28:28Z

No product review needed

hoangzinh · 2026-06-23T10:04:16Z

@hoangzinh Can you leave attendees part for now? I want you to actually migrate useSearchSelector hook to use useFilteredOptions internally? That is the part you have to do

@shubham1206agra Oops, I thought you mentioned the other parts, similar to your Part1-Part4. Let me rework on it.

…age to usePersonalDetailSearchSelector Same migration as MoneyRequestAttendeeSelector: replaces useSearchSelector with usePersonalDetailSearchSelector and renames availableOptions.recentReports to availableOptions.recentOptions. Part of the useSearchSelector -> usePersonalDetailSearchSelector migration (issue Expensify#82191).

shubham1206agra · 2026-06-23T11:39:38Z

@hoangzinh Lemme know when you are done

hoangzinh · 2026-06-23T13:19:45Z

@shubham1206agra Migration PR for WorkspaceWorkflowsApprovalsExpensesFromPage is ready

mountiny · 2026-06-23T17:07:00Z

@shubham1206agra all yours

shubham1206agra · 2026-06-24T08:13:49Z


            // Add search results that are not already workspace members
-            const searchResults = [...availableOptions.recentReports, ...availableOptions.personalDetails].filter((option) => {
+            const searchResults = [...availableOptions.recentOptions, ...availableOptions.personalDetails].filter((option) => {


@hoangzinh Why do we need recentOptions here? Can't we work with personalDetails only here?

Agreed. We don't need recentOptions here. I updated in this commit 332f98f

shubham1206agra · 2026-06-24T08:15:45Z

            // Add search results that are not already workspace members
-            const searchResults = [...availableOptions.recentReports, ...availableOptions.personalDetails].filter((option) => {
+            const searchResults = [...availableOptions.recentOptions, ...availableOptions.personalDetails].filter((option) => {
                const isMember = policy?.employeeList?.[normalizeLogin(option.login)];


@hoangzinh Also, why do we need to check for isMember here? excludeUsers should remove them already.

You're right. We don't need isMember check here. I updated in this commit 822545d

This page selects individual people as workspace approvers, not chat contacts, so it doesn't need recent-report-based suggestions. Setting includeRecentReports to false matches the pattern used by other non-chat invite flows (DynamicWorkspaceInvitePage, MoneyRequestAttendeeSelector, DomainAddAdminPage) and lets the search results rely solely on availableOptions.personalDetails, which is no longer filtered against recentOptions.

…sults excludeLogins (via getExcludedUsers) intentionally leaves pending-delete and error-state policy employees unfiltered so they remain searchable, but the isMember check was blocking pending-delete employees from resurfacing in this search. Dedup against the members already in the list (selected approvers, active workspace members, userToInvite) already covers duplicates, so isMember was both redundant and incorrectly restrictive.

shubham1206agra · 2026-06-26T03:23:27Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Screen.Recording.2026-06-25.at.10.44.28.PM.mov

OSBotify · 2026-06-26T08:58:50Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-06-26T09:03:02Z

🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-06-26T09:08:42Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #94179.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-76bc3755842-27a47d6-06048e2c665b2703fba72549cab52a8fe26622c0/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-76bc375-27a47d6-ee4d785f142bddcbfd4fe470126bb5db5e50b773/index.html

Web 🕸️
https://94179.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-06-26T20:00:42Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.4.21-2 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-06-29T12:37:28Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.4.21-9 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android

melvin-bot Bot assigned hoangzinh Jun 22, 2026

hoangzinh marked this pull request as ready for review June 22, 2026 17:19

hoangzinh requested review from a team as code owners June 22, 2026 17:19

melvin-bot Bot requested review from joekaufmanexpensify and shubham1206agra and removed request for a team June 22, 2026 17:19

melvin-bot Bot requested review from a team and mountiny and removed request for a team June 22, 2026 17:19

chatgpt-codex-connector Bot reviewed Jun 22, 2026

View reviewed changes

Comment thread src/pages/iou/request/MoneyRequestAttendeeSelector.tsx Outdated

Comment thread src/pages/iou/request/MoneyRequestAttendeeSelector.tsx

joekaufmanexpensify removed their request for review June 22, 2026 21:28

hoangzinh force-pushed the refactor-useSearchSelector-5 branch from d423ed8 to 54a5108 Compare June 23, 2026 11:28

Merge branch 'main' into refactor-useSearchSelector-5

5c89f52

shubham1206agra reviewed Jun 24, 2026

View reviewed changes

hoangzinh added 3 commits June 24, 2026 18:39

Merge branch 'main' into refactor-useSearchSelector-5

c155aee

shubham1206agra approved these changes Jun 26, 2026

View reviewed changes

mountiny approved these changes Jun 26, 2026

View reviewed changes

mountiny merged commit 76bc375 into Expensify:main Jun 26, 2026
34 of 36 checks passed

OSBotify mentioned this pull request Jun 26, 2026

Deploy Checklist: New Expensify 2026-06-26 #94730

Closed

55 tasks

melvin-bot Bot mentioned this pull request Jun 29, 2026

Migrate useSearchSelector.base.ts from useOptionsList to useFilteredOptions #82191

Open

Uh oh!

Conversation

hoangzinh commented Jun 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented Jun 22, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot Bot commented Jun 22, 2026

Uh oh!

melvin-bot Bot commented Jun 22, 2026

Uh oh!

shubham1206agra commented Jun 22, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

joekaufmanexpensify commented Jun 22, 2026

Uh oh!

hoangzinh commented Jun 23, 2026

Uh oh!

shubham1206agra commented Jun 23, 2026

Uh oh!

hoangzinh commented Jun 23, 2026

Uh oh!

mountiny commented Jun 23, 2026

Uh oh!

shubham1206agra Jun 24, 2026

Choose a reason for hiding this comment

Uh oh!

hoangzinh Jun 24, 2026

Choose a reason for hiding this comment

Uh oh!

shubham1206agra Jun 24, 2026

Choose a reason for hiding this comment

Uh oh!

hoangzinh Jun 24, 2026

Choose a reason for hiding this comment

Uh oh!

shubham1206agra commented Jun 26, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

OSBotify commented Jun 26, 2026

Uh oh!

github-actions Bot commented Jun 26, 2026

Uh oh!

github-actions Bot commented Jun 26, 2026

Uh oh!

OSBotify commented Jun 26, 2026

Uh oh!

OSBotify commented Jun 29, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

hoangzinh commented Jun 22, 2026 •

edited

Loading

codecov Bot commented Jun 22, 2026 •

edited by github-actions Bot

Loading